Title: [119960] trunk/Source/WebCore
- Revision
- 119960
- Author
- [email protected]
- Date
- 2012-06-11 01:17:14 -0700 (Mon, 11 Jun 2012)
Log Message
Spellchecker crash in async scenario.
https://bugs.webkit.org/show_bug.cgi?id=88617
Reviewed by Tony Chang.
SpellCheckRequest::invokeRequest() can be reached after the frame is detached.
SpellCheckRequest should ignore such a request since TextCheckerClient is not available
for detached Frames.
No new tests. It's hard to reproduce this.
* editing/SpellChecker.cpp:
(WebCore::SpellChecker::invokeRequest):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (119959 => 119960)
--- trunk/Source/WebCore/ChangeLog 2012-06-11 08:11:59 UTC (rev 119959)
+++ trunk/Source/WebCore/ChangeLog 2012-06-11 08:17:14 UTC (rev 119960)
@@ -1,3 +1,19 @@
+2012-06-11 MORITA Hajime <[email protected]>
+
+ Spellchecker crash in async scenario.
+ https://bugs.webkit.org/show_bug.cgi?id=88617
+
+ Reviewed by Tony Chang.
+
+ SpellCheckRequest::invokeRequest() can be reached after the frame is detached.
+ SpellCheckRequest should ignore such a request since TextCheckerClient is not available
+ for detached Frames.
+
+ No new tests. It's hard to reproduce this.
+
+ * editing/SpellChecker.cpp:
+ (WebCore::SpellChecker::invokeRequest):
+
2012-06-11 Ryuan Choi <[email protected]>
[EFL] Extract CursorMap from WidgetEfl.cpp.
Modified: trunk/Source/WebCore/editing/SpellChecker.cpp (119959 => 119960)
--- trunk/Source/WebCore/editing/SpellChecker.cpp 2012-06-11 08:11:59 UTC (rev 119959)
+++ trunk/Source/WebCore/editing/SpellChecker.cpp 2012-06-11 08:17:14 UTC (rev 119960)
@@ -178,6 +178,10 @@
void SpellChecker::invokeRequest(PassRefPtr<SpellCheckRequest> request)
{
ASSERT(!m_processingRequest);
+ if (!client()) {
+ request->didCancel();
+ return;
+ }
m_processingRequest = request;
client()->requestCheckingOfString(m_processingRequest);
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
