Title: [119962] trunk
- Revision
- 119962
- Author
- [email protected]
- Date
- 2012-06-11 01:24:02 -0700 (Mon, 11 Jun 2012)
Log Message
[JSC] Web Inspector: implement breaking from native callback
https://bugs.webkit.org/show_bug.cgi?id=43332
Patch by Peter Wang <[email protected]> on 2012-06-11
Reviewed by Pavel Feldman.
These test cases were enabled:
LayoutTests/inspector/debugger/dom-breakpoints.html
LayoutTests/inspector/debugger/event-listener-breakpoints.html
LayoutTests/inspector/debugger/step-through-event-listeners.html
LayoutTests/inspector/debugger/xhr-breakpoints.html
* bindings/js/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::breakProgram):
* bindings/js/ScriptDebugServer.h:
(WebCore::supportsNativeBreakpoints):
Modified Paths
Diff
Modified: trunk/LayoutTests/platform/qt/Skipped (119961 => 119962)
--- trunk/LayoutTests/platform/qt/Skipped 2012-06-11 08:23:01 UTC (rev 119961)
+++ trunk/LayoutTests/platform/qt/Skipped 2012-06-11 08:24:02 UTC (rev 119962)
@@ -271,12 +271,6 @@
fast/text/hyphens.html
fast/text/soft-hyphen-4.html
-# https://bugs.webkit.org/show_bug.cgi?id=43332
-inspector/debugger/dom-breakpoints.html
-inspector/debugger/event-listener-breakpoints.html
-inspector/debugger/step-through-event-listeners.html
-inspector/debugger/xhr-breakpoints.html
-
# JSC doesn't support heap profiling
# https://bugs.webkit.org/show_bug.cgi?id=50485
inspector/profiler/heap-snapshot-inspect-dom-wrapper.html
Modified: trunk/Source/WebCore/ChangeLog (119961 => 119962)
--- trunk/Source/WebCore/ChangeLog 2012-06-11 08:23:01 UTC (rev 119961)
+++ trunk/Source/WebCore/ChangeLog 2012-06-11 08:24:02 UTC (rev 119962)
@@ -1,3 +1,21 @@
+2012-06-11 Peter Wang <[email protected]>
+
+ [JSC] Web Inspector: implement breaking from native callback
+ https://bugs.webkit.org/show_bug.cgi?id=43332
+
+ Reviewed by Pavel Feldman.
+
+ These test cases were enabled:
+ LayoutTests/inspector/debugger/dom-breakpoints.html
+ LayoutTests/inspector/debugger/event-listener-breakpoints.html
+ LayoutTests/inspector/debugger/step-through-event-listeners.html
+ LayoutTests/inspector/debugger/xhr-breakpoints.html
+
+ * bindings/js/ScriptDebugServer.cpp:
+ (WebCore::ScriptDebugServer::breakProgram):
+ * bindings/js/ScriptDebugServer.h:
+ (WebCore::supportsNativeBreakpoints):
+
2012-06-11 MORITA Hajime <[email protected]>
Spellchecker crash in async scenario.
Modified: trunk/Source/WebCore/bindings/js/ScriptDebugServer.cpp (119961 => 119962)
--- trunk/Source/WebCore/bindings/js/ScriptDebugServer.cpp 2012-06-11 08:23:01 UTC (rev 119961)
+++ trunk/Source/WebCore/bindings/js/ScriptDebugServer.cpp 2012-06-11 08:24:02 UTC (rev 119962)
@@ -152,7 +152,11 @@
void ScriptDebugServer::breakProgram()
{
- // FIXME(WK43332): implement this.
+ if (m_paused || !m_currentCallFrame)
+ return;
+
+ m_pauseOnNextStatement = true;
+ pauseIfNeeded(m_currentCallFrame->dynamicGlobalObject());
}
void ScriptDebugServer::continueProgram()
Modified: trunk/Source/WebCore/bindings/js/ScriptDebugServer.h (119961 => 119962)
--- trunk/Source/WebCore/bindings/js/ScriptDebugServer.h 2012-06-11 08:23:01 UTC (rev 119961)
+++ trunk/Source/WebCore/bindings/js/ScriptDebugServer.h 2012-06-11 08:24:02 UTC (rev 119962)
@@ -85,7 +85,8 @@
bool setScriptSource(const String& sourceID, const String& newContent, bool preview, String* error, ScriptValue* newCallFrames, ScriptObject* result);
bool causesRecompilation() { return true; }
- bool supportsNativeBreakpoints() { return false; }
+ // FIXME: Need to remove this. Refer to bug: 88759.
+ bool supportsNativeBreakpoints() { return true; }
void recompileAllJSFunctionsSoon();
virtual void recompileAllJSFunctions(Timer<ScriptDebugServer>* = 0) = 0;
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
