Title: [120022] trunk/Source/WebKit/blackberry
- Revision
- 120022
- Author
- [email protected]
- Date
- 2012-06-11 17:32:10 -0700 (Mon, 11 Jun 2012)
Log Message
[BlackBerry] Autofill feature implementation for BlackBerry porting
https://bugs.webkit.org/show_bug.cgi?id=85577
Patch by Jonathan Dong <[email protected]> on 2012-06-11
Reviewed by Rob Buis.
Remove the autofill saving procedure out of dispatchWillSubmitForm, this procedure
is same as the procedure in dispatchWillSendSubmitEvent.
Some sites will redirect to other url in its login process, which will cause the
user get notified to save credentials for this provisional redirecting url if we
put this saving procedure in dispatchWillSubmitForm. So we should remove it to make
sure we only save the autofill data before the submit event is fired.
* WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::dispatchWillSubmitForm):
Modified Paths
Diff
Modified: trunk/Source/WebKit/blackberry/ChangeLog (120021 => 120022)
--- trunk/Source/WebKit/blackberry/ChangeLog 2012-06-12 00:29:34 UTC (rev 120021)
+++ trunk/Source/WebKit/blackberry/ChangeLog 2012-06-12 00:32:10 UTC (rev 120022)
@@ -1,3 +1,20 @@
+2012-06-11 Jonathan Dong <[email protected]>
+
+ [BlackBerry] Autofill feature implementation for BlackBerry porting
+ https://bugs.webkit.org/show_bug.cgi?id=85577
+
+ Reviewed by Rob Buis.
+
+ Remove the autofill saving procedure out of dispatchWillSubmitForm, this procedure
+ is same as the procedure in dispatchWillSendSubmitEvent.
+ Some sites will redirect to other url in its login process, which will cause the
+ user get notified to save credentials for this provisional redirecting url if we
+ put this saving procedure in dispatchWillSubmitForm. So we should remove it to make
+ sure we only save the autofill data before the submit event is fired.
+
+ * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
+ (WebCore::FrameLoaderClientBlackBerry::dispatchWillSubmitForm):
+
2012-06-11 Antonio Gomes <[email protected]>
[BlackBerry] [BlackBerry] browser video player fullscreen mode (portrait) does not play well with rotation
Modified: trunk/Source/WebKit/blackberry/WebCoreSupport/FrameLoaderClientBlackBerry.cpp (120021 => 120022)
--- trunk/Source/WebKit/blackberry/WebCoreSupport/FrameLoaderClientBlackBerry.cpp 2012-06-12 00:29:34 UTC (rev 120021)
+++ trunk/Source/WebKit/blackberry/WebCoreSupport/FrameLoaderClientBlackBerry.cpp 2012-06-12 00:32:10 UTC (rev 120022)
@@ -704,17 +704,8 @@
}
}
-void FrameLoaderClientBlackBerry::dispatchWillSubmitForm(FramePolicyFunction function, PassRefPtr<FormState> formState)
+void FrameLoaderClientBlackBerry::dispatchWillSubmitForm(FramePolicyFunction function, PassRefPtr<FormState>)
{
- if (!m_webPagePrivate->m_webSettings->isPrivateBrowsingEnabled()) {
- if (m_webPagePrivate->m_webSettings->isFormAutofillEnabled())
- m_webPagePrivate->m_autofillManager->saveTextFields(formState->form());
-#if ENABLE(BLACKBERRY_CREDENTIAL_PERSIST)
- if (m_webPagePrivate->m_webSettings->isCredentialAutofillEnabled())
- credentialManager().saveCredentialIfConfirmed(m_webPagePrivate, CredentialTransformData(formState->form()));
-#endif
- }
-
// FIXME: Stub.
(m_frame->loader()->policyChecker()->*function)(PolicyUse);
}
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
