Title: [120212] trunk/Tools
- Revision
- 120212
- Author
- [email protected]
- Date
- 2012-06-13 08:15:44 -0700 (Wed, 13 Jun 2012)
Log Message
check-webkit-style needs to respect Qt API coding style
https://bugs.webkit.org/show_bug.cgi?id=88995
Reviewed by Csaba Osztrogonác.
Add -whitespace/declaration exception to Qt API files.
* Scripts/webkitpy/style/checker.py:
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (120211 => 120212)
--- trunk/Tools/ChangeLog 2012-06-13 15:14:33 UTC (rev 120211)
+++ trunk/Tools/ChangeLog 2012-06-13 15:15:44 UTC (rev 120212)
@@ -1,3 +1,14 @@
+2012-06-13 Zoltan Horvath <[email protected]>
+
+ check-webkit-style needs to respect Qt API coding style
+ https://bugs.webkit.org/show_bug.cgi?id=88995
+
+ Reviewed by Csaba Osztrogonác.
+
+ Add -whitespace/declaration exception to Qt API files.
+
+ * Scripts/webkitpy/style/checker.py:
+
2012-06-13 Christophe Dumez <[email protected]>
[WK2] Add implementation for dispatchIntent in WebFrameLoaderClient
Modified: trunk/Tools/Scripts/webkitpy/style/checker.py (120211 => 120212)
--- trunk/Tools/Scripts/webkitpy/style/checker.py 2012-06-13 15:14:33 UTC (rev 120211)
+++ trunk/Tools/Scripts/webkitpy/style/checker.py 2012-06-13 15:15:44 UTC (rev 120212)
@@ -140,11 +140,17 @@
# Qt code uses '_' in some places (such as private slots
# and on test xxx_data methos on tests)
"Source/_javascript_Core/qt/",
- "Source/WebKit/qt/Api/",
"Source/WebKit/qt/tests/",
"Source/WebKit/qt/declarative/",
"Source/WebKit/qt/examples/"],
["-readability/naming"]),
+
+ ([# The Qt APIs use Qt declaration style, it puts the * to
+ # the variable name, not to the class.
+ "Source/WebKit/qt/Api/"],
+ ["-readability/naming",
+ "-whitespace/declaration"]),
+
([# Qt's MiniBrowser has no config.h
"Tools/MiniBrowser/qt"],
["-build/include"]),
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
