Title: [120214] trunk/Source/WebCore
- Revision
- 120214
- Author
- [email protected]
- Date
- 2012-06-13 08:35:06 -0700 (Wed, 13 Jun 2012)
Log Message
Web Inspector: Errors when pending console messages are attached to _javascript_SourceFrame.
https://bugs.webkit.org/show_bug.cgi?id=88712
Reviewed by Pavel Feldman.
* inspector/front-end/PresentationConsoleMessageHelper.js:
(WebInspector.PresentationConsoleMessageHelper):
(WebInspector.PresentationConsoleMessageHelper.prototype._addPendingConsoleMessage):
(WebInspector.PresentationConsoleMessageHelper.prototype._parsedScriptSource):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (120213 => 120214)
--- trunk/Source/WebCore/ChangeLog 2012-06-13 15:29:34 UTC (rev 120213)
+++ trunk/Source/WebCore/ChangeLog 2012-06-13 15:35:06 UTC (rev 120214)
@@ -1,3 +1,15 @@
+2012-06-09 Vsevolod Vlasov <[email protected]>
+
+ Web Inspector: Errors when pending console messages are attached to _javascript_SourceFrame.
+ https://bugs.webkit.org/show_bug.cgi?id=88712
+
+ Reviewed by Pavel Feldman.
+
+ * inspector/front-end/PresentationConsoleMessageHelper.js:
+ (WebInspector.PresentationConsoleMessageHelper):
+ (WebInspector.PresentationConsoleMessageHelper.prototype._addPendingConsoleMessage):
+ (WebInspector.PresentationConsoleMessageHelper.prototype._parsedScriptSource):
+
2012-06-13 Alexander Pavlov <[email protected]>
Web Inspector: Support user attributes in DOMNode
Modified: trunk/Source/WebCore/inspector/front-end/PresentationConsoleMessageHelper.js (120213 => 120214)
--- trunk/Source/WebCore/inspector/front-end/PresentationConsoleMessageHelper.js 2012-06-13 15:29:34 UTC (rev 120213)
+++ trunk/Source/WebCore/inspector/front-end/PresentationConsoleMessageHelper.js 2012-06-13 15:35:06 UTC (rev 120214)
@@ -34,6 +34,9 @@
*/
WebInspector.PresentationConsoleMessageHelper = function(uiSourceCodeProvider)
{
+ /**
+ * @type {Object.<string, Array.<WebInspector.ConsoleMessage>>}
+ */
this._pendingConsoleMessages = {};
this._presentationConsoleMessages = [];
this._uiSourceCodeProvider = uiSourceCodeProvider;
@@ -77,6 +80,8 @@
*/
_addPendingConsoleMessage: function(message)
{
+ if (!message.url)
+ return;
if (!this._pendingConsoleMessages[message.url])
this._pendingConsoleMessages[message.url] = [];
this._pendingConsoleMessages[message.url].push(message);
@@ -98,7 +103,7 @@
var message = messages[i];
var rawLocation = message.location();
if (script.scriptId === rawLocation.scriptId)
- this._addConsoleMessageToScript(messages, rawLocation);
+ this._addConsoleMessageToScript(message, rawLocation);
else
pendingMessages.push(message);
}
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
