Title: [120228] trunk
Revision
120228
Author
[email protected]
Date
2012-06-13 11:21:58 -0700 (Wed, 13 Jun 2012)

Log Message

[Gtk] Enable link prefetch support in the developer builds
https://bugs.webkit.org/show_bug.cgi?id=89011

Reviewed by Martin Robinson.

.: 

Rather export an automake conditional than define a preprocessor
macro for enabling link prefetch support.

* configure.ac:

Source/WebCore: 

Handle the ENABLE_LINK_PREFETCH conditional in standard way.

No new tests - covered by existing link prefetch tests.

* GNUmakefile.am:

Tools: 

Enable the link prefetch support for Gtk by default in developer
builds.

* Scripts/webkitperl/FeatureList.pm:

LayoutTests: 

Remove expectations for link prefetch tests that now pass and
recategorise a few failures that now fail due to missing
dumpResourceResponseMIMETypes implementation in DumpRenderTree.

* platform/gtk/TestExpectations:

Modified Paths

Diff

Modified: trunk/ChangeLog (120227 => 120228)


--- trunk/ChangeLog	2012-06-13 18:11:04 UTC (rev 120227)
+++ trunk/ChangeLog	2012-06-13 18:21:58 UTC (rev 120228)
@@ -1,3 +1,15 @@
+2012-06-13  Zan Dobersek  <[email protected]>
+
+        [Gtk] Enable link prefetch support in the developer builds
+        https://bugs.webkit.org/show_bug.cgi?id=89011
+
+        Reviewed by Martin Robinson.
+
+        Rather export an automake conditional than define a preprocessor
+        macro for enabling link prefetch support.
+
+        * configure.ac:
+
 2012-06-13  Robin Cao  <[email protected]>
 
         [BlackBerry] Enable MEDIA_STREAM by default

Modified: trunk/LayoutTests/ChangeLog (120227 => 120228)


--- trunk/LayoutTests/ChangeLog	2012-06-13 18:11:04 UTC (rev 120227)
+++ trunk/LayoutTests/ChangeLog	2012-06-13 18:21:58 UTC (rev 120228)
@@ -1,3 +1,16 @@
+2012-06-13  Zan Dobersek  <[email protected]>
+
+        [Gtk] Enable link prefetch support in the developer builds
+        https://bugs.webkit.org/show_bug.cgi?id=89011
+
+        Reviewed by Martin Robinson.
+
+        Remove expectations for link prefetch tests that now pass and
+        recategorise a few failures that now fail due to missing
+        dumpResourceResponseMIMETypes implementation in DumpRenderTree.
+
+        * platform/gtk/TestExpectations:
+
 2012-06-13  Julien Chaffraix  <[email protected]>
 
         Unreviewed flakiness removal.

Modified: trunk/LayoutTests/platform/gtk/TestExpectations (120227 => 120228)


--- trunk/LayoutTests/platform/gtk/TestExpectations	2012-06-13 18:11:04 UTC (rev 120227)
+++ trunk/LayoutTests/platform/gtk/TestExpectations	2012-06-13 18:21:58 UTC (rev 120228)
@@ -638,9 +638,7 @@
 BUGWKGTK : http/tests/media/video-play-stall.html = TEXT
 
 BUGWKGTK : http/tests/misc/acid3.html = TEXT
-BUGWKGTK : http/tests/misc/link-rel-prefetch-and-subresource.html = TEXT
 BUGWKGTK : http/tests/misc/policy-delegate-called-twice.html = TEXT
-BUGWKGTK : http/tests/misc/prefetch-purpose.html = TEXT
 BUGWKGTK : http/tests/misc/redirect-to-external-url.html = TEXT
 BUGWKGTK : http/tests/misc/window-dot-stop.html = TEXT
 BUGWKGTK : http/tests/multipart/policy-ignore-crash.php = TEXT
@@ -818,15 +816,6 @@
 BUGWKGTK : fast/forms/range/slider-mouse-events.html = TEXT
 BUGWKGTK : fast/forms/range/slider-zoomed.html = TEXT
 
-// Link prefetch is disabled by default
-BUGWKGTK : fast/dom/HTMLLinkElement/link-and-subresource-test.html = TEXT
-BUGWKGTK : fast/dom/HTMLLinkElement/link-and-subresource-test-nonexistent.html = TEXT
-BUGWKGTK : fast/dom/HTMLLinkElement/prefetch.html = TEXT
-BUGWKGTK : fast/dom/HTMLLinkElement/prefetch-beforeload.html = TEXT
-BUGWKGTK : fast/dom/HTMLLinkElement/prefetch-onerror.html = TEXT
-BUGWKGTK : fast/dom/HTMLLinkElement/prefetch-onload.html = TEXT
-BUGWKGTK : fast/dom/HTMLLinkElement/subresource.html = TEXT
-
 // Tests failing because the context menu is grabbing mouse events.
 BUGWK40601 : fast/events/mouse-click-events.html = TEXT
 BUGWK40601 : fast/events/mouseup-from-button2.html = TEXT
@@ -834,10 +823,14 @@
 BUGWK40601 : editing/selection/5354455-1.html = TEXT
 
 // Gtk doesn't implement dumpResourceResponseMIMETypes which is required for the preloader tests.
+BUGWK58222 : fast/dom/HTMLLinkElement/link-and-subresource-test.html = TEXT
+BUGWK58222 : fast/dom/HTMLLinkElement/prefetch.html = TEXT
+BUGWK58222 : fast/dom/HTMLLinkElement/subresource.html = TEXT
 BUGWK58222 : fast/preloader = TEXT
 BUGWK58222 : fast/preloader/scan-body-from-head-import.html = PASS
 BUGWK58222 : fast/preloader/scan-body-from-head-script.html = PASS
 BUGWK58222 : http/tests/mime/uppercase-mime-type.html = TEXT
+BUGWK58222 : http/tests/misc/prefetch-purpose.html = PASS
 
 // The middle circle on both rectangles is missing in the pixel output.
 BUGWKGTK : svg/custom/circular-marker-reference-2.svg = TEXT

Modified: trunk/Source/WebCore/ChangeLog (120227 => 120228)


--- trunk/Source/WebCore/ChangeLog	2012-06-13 18:11:04 UTC (rev 120227)
+++ trunk/Source/WebCore/ChangeLog	2012-06-13 18:21:58 UTC (rev 120228)
@@ -1,3 +1,16 @@
+2012-06-13  Zan Dobersek  <[email protected]>
+
+        [Gtk] Enable link prefetch support in the developer builds
+        https://bugs.webkit.org/show_bug.cgi?id=89011
+
+        Reviewed by Martin Robinson.
+
+        Handle the ENABLE_LINK_PREFETCH conditional in standard way.
+
+        No new tests - covered by existing link prefetch tests.
+
+        * GNUmakefile.am:
+
 2012-06-13  Amy Ousterhout  <[email protected]>
 
         Rename currentDeviceMotion to lastMotion in DeviceMotionClient

Modified: trunk/Source/WebCore/GNUmakefile.am (120227 => 120228)


--- trunk/Source/WebCore/GNUmakefile.am	2012-06-13 18:11:04 UTC (rev 120227)
+++ trunk/Source/WebCore/GNUmakefile.am	2012-06-13 18:21:58 UTC (rev 120228)
@@ -707,6 +707,14 @@
 webcore_cppflags += -DENABLE_CSS3_FLEXBOX=1
 endif  # END ENABLE_CSS3_FLEXBOX
 
+# ---
+# Link prefetch support
+# ---
+if ENABLE_LINK_PREFETCH
+FEATURE_DEFINES += ENABLE_LINK_PREFETCH=1
+webcore_cppflags += -DENABLE_LINK_PREFETCH=1
+endif  # END ENABLE_LINK_PREFETCH
+
 DerivedSources/WebCore/CSSPropertyNames.cpp: DerivedSources/WebCore/CSSPropertyNames.h
 DerivedSources/WebCore/CSSPropertyNames.h: $(WEBCORE_CSS_PROPERTY_NAMES) $(WebCore)/css/makeprop.pl
 	$(AM_V_GEN)

Modified: trunk/Tools/ChangeLog (120227 => 120228)


--- trunk/Tools/ChangeLog	2012-06-13 18:11:04 UTC (rev 120227)
+++ trunk/Tools/ChangeLog	2012-06-13 18:21:58 UTC (rev 120228)
@@ -1,3 +1,15 @@
+2012-06-13  Zan Dobersek  <[email protected]>
+
+        [Gtk] Enable link prefetch support in the developer builds
+        https://bugs.webkit.org/show_bug.cgi?id=89011
+
+        Reviewed by Martin Robinson.
+
+        Enable the link prefetch support for Gtk by default in developer
+        builds.
+
+        * Scripts/webkitperl/FeatureList.pm:
+
 2012-06-13  Csaba Osztrogonác  <[email protected]>
 
         Update buildbot master in autoinstaller to match build.webkit.org

Modified: trunk/Tools/Scripts/webkitperl/FeatureList.pm (120227 => 120228)


--- trunk/Tools/Scripts/webkitperl/FeatureList.pm	2012-06-13 18:11:04 UTC (rev 120227)
+++ trunk/Tools/Scripts/webkitperl/FeatureList.pm	2012-06-13 18:21:58 UTC (rev 120228)
@@ -264,7 +264,7 @@
       define => "ENABLE_LEGACY_WEBKIT_BLOB_BUILDER", default => (isGtk() || isChromium() || isBlackBerry() || isEfl()), value => \$legacyWebKitBlobBuilderSupport },
 
     { option => "link-prefetch", desc => "Toggle Link Prefetch support",
-      define => "ENABLE_LINK_PREFETCH", default => 0, value => \$linkPrefetchSupport },
+      define => "ENABLE_LINK_PREFETCH", default => isGtk(), value => \$linkPrefetchSupport },
 
     { option => "link-prerender", desc => "Toggle Link Prerender support",
       define => "ENABLE_LINK_PRERENDER", default => 0, value => \$linkPrerenderSupport },

Modified: trunk/configure.ac (120227 => 120228)


--- trunk/configure.ac	2012-06-13 18:11:04 UTC (rev 120227)
+++ trunk/configure.ac	2012-06-13 18:21:58 UTC (rev 120228)
@@ -1041,10 +1041,6 @@
   [],[enable_link_prefetch=no])
 AC_MSG_RESULT([$enable_link_prefetch])
 
-if test "$enable_link_prefetch" = "yes"; then 
-  AC_DEFINE([ENABLE_LINK_PREFETCH], [1], [Define to enable link prefetch support])
-fi
-
 # GObject Introspection
 AC_MSG_CHECKING([whether to enable GObject introspection support])
 AC_ARG_ENABLE([introspection],
@@ -1437,6 +1433,7 @@
 AM_CONDITIONAL([ENABLE_WEBKIT2],[test "$enable_webkit2" = "yes"])
 AM_CONDITIONAL([ENABLE_PLUGIN_PROCESS],[test "$enable_plugin_process" = "yes"])
 AM_CONDITIONAL([ENABLE_SPELLCHECK],[test "$enable_spellcheck" = "yes"])
+AM_CONDITIONAL([ENABLE_LINK_PREFETCH],[test "$enable_link_prefetch" = "yes"])
 AM_CONDITIONAL([ENABLE_ANIMATION_API],[test "$enable_animation_api" = "yes"])
 AM_CONDITIONAL([ENABLE_REQUEST_ANIMATION_FRAME],[test "$enable_request_animation_frame" = "yes"])
 AM_CONDITIONAL([ENABLE_TOUCH_ICON_LOADING],[test "$enable_touch_icon_loading" = "yes"])
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to