Title: [120237] trunk/LayoutTests
Revision
120237
Author
[email protected]
Date
2012-06-13 12:45:39 -0700 (Wed, 13 Jun 2012)

Log Message

REGRESSION(r120108): It made http/tests/loading/gmail-assert-on-load.html fail
https://bugs.webkit.org/show_bug.cgi?id=88923

Patch by Shrey Banga <[email protected]> on 2012-06-13
Reviewed by Csaba Osztrogonác.

* http/tests/loading/gmail-assert-on-load-expected.txt: Removed.
* http/tests/misc/gmail-assert-on-load-expected.txt: Added.
* http/tests/misc/gmail-assert-on-load.html: Renamed from LayoutTests/http/tests/loading/gmail-assert-on-load.html.
All tests in http/tests/loading dump frame load events, which are not
consistent or relevant for this test. So it had to be moved out of
http/tests/loading.
* platform/qt/Skipped: This test can be unskipped now

Modified Paths

Added Paths

Removed Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (120236 => 120237)


--- trunk/LayoutTests/ChangeLog	2012-06-13 19:40:50 UTC (rev 120236)
+++ trunk/LayoutTests/ChangeLog	2012-06-13 19:45:39 UTC (rev 120237)
@@ -1,3 +1,18 @@
+2012-06-13  Shrey Banga  <[email protected]>
+
+        REGRESSION(r120108): It made http/tests/loading/gmail-assert-on-load.html fail
+        https://bugs.webkit.org/show_bug.cgi?id=88923
+
+        Reviewed by Csaba Osztrogonác.
+
+        * http/tests/loading/gmail-assert-on-load-expected.txt: Removed.
+        * http/tests/misc/gmail-assert-on-load-expected.txt: Added.
+        * http/tests/misc/gmail-assert-on-load.html: Renamed from LayoutTests/http/tests/loading/gmail-assert-on-load.html.
+        All tests in http/tests/loading dump frame load events, which are not
+        consistent or relevant for this test. So it had to be moved out of
+        http/tests/loading.
+        * platform/qt/Skipped: This test can be unskipped now
+
 2012-06-13  Vineet Chaudhary  <[email protected]>
 
         REGRESSION (r120204-r120206): 37 fast/profiler tests failing on GTK Linux 64-bit Release

Deleted: trunk/LayoutTests/http/tests/loading/gmail-assert-on-load-expected.txt (120236 => 120237)


--- trunk/LayoutTests/http/tests/loading/gmail-assert-on-load-expected.txt	2012-06-13 19:40:50 UTC (rev 120236)
+++ trunk/LayoutTests/http/tests/loading/gmail-assert-on-load-expected.txt	2012-06-13 19:45:39 UTC (rev 120237)
@@ -1,13 +0,0 @@
-main frame - didStartProvisionalLoadForFrame
-main frame - didCommitLoadForFrame
-frame "<!--framePath //<!--frame0-->-->" - didStartProvisionalLoadForFrame
-main frame - didFinishDocumentLoadForFrame
-frame "<!--framePath //<!--frame0-->-->" - didCommitLoadForFrame
-frame "<!--framePath //<!--frame0-->-->" - didFinishDocumentLoadForFrame
-main frame - didHandleOnloadEventsForFrame
-main frame - didFinishLoadForFrame
-This test provokes HTMLTokenizer::timerFired to be called and from within timerFired we want to call WebCore::pageDestroyed.
-
-You pass this test if you don't see an ASSERT. This is from http://bugs.webkit.org/show_bug.cgi?id=15765.
-
-

Deleted: trunk/LayoutTests/http/tests/loading/gmail-assert-on-load.html (120236 => 120237)


--- trunk/LayoutTests/http/tests/loading/gmail-assert-on-load.html	2012-06-13 19:40:50 UTC (rev 120236)
+++ trunk/LayoutTests/http/tests/loading/gmail-assert-on-load.html	2012-06-13 19:45:39 UTC (rev 120237)
@@ -1,11 +0,0 @@
-<html>
-<script>
-if (window.testRunner) {
-    testRunner.dumpAsText();
-}
-</script>
-<body>
-<p>This test provokes HTMLTokenizer::timerFired to be called and from within timerFired we want to call WebCore::pageDestroyed.</p>
-<p>You pass this test if you don't see an ASSERT. This is from http://bugs.webkit.org/show_bug.cgi?id=15765.</p>
-<iframe src=""
-</body>

Added: trunk/LayoutTests/http/tests/misc/gmail-assert-on-load-expected.txt (0 => 120237)


--- trunk/LayoutTests/http/tests/misc/gmail-assert-on-load-expected.txt	                        (rev 0)
+++ trunk/LayoutTests/http/tests/misc/gmail-assert-on-load-expected.txt	2012-06-13 19:45:39 UTC (rev 120237)
@@ -0,0 +1,5 @@
+This test provokes HTMLTokenizer::timerFired to be called and from within timerFired we want to call WebCore::pageDestroyed.
+
+You pass this test if you don't see an ASSERT. This is from http://bugs.webkit.org/show_bug.cgi?id=15765.
+
+

Copied: trunk/LayoutTests/http/tests/misc/gmail-assert-on-load.html (from rev 120236, trunk/LayoutTests/http/tests/loading/gmail-assert-on-load.html) (0 => 120237)


--- trunk/LayoutTests/http/tests/misc/gmail-assert-on-load.html	                        (rev 0)
+++ trunk/LayoutTests/http/tests/misc/gmail-assert-on-load.html	2012-06-13 19:45:39 UTC (rev 120237)
@@ -0,0 +1,11 @@
+<html>
+<script>
+if (window.layoutTestController) {
+    layoutTestController.dumpAsText();
+}
+</script>
+<body>
+<p>This test provokes HTMLTokenizer::timerFired to be called and from within timerFired we want to call WebCore::pageDestroyed.</p>
+<p>You pass this test if you don't see an ASSERT. This is from http://bugs.webkit.org/show_bug.cgi?id=15765.</p>
+<iframe src=""
+</body>

Modified: trunk/LayoutTests/platform/qt/Skipped (120236 => 120237)


--- trunk/LayoutTests/platform/qt/Skipped	2012-06-13 19:40:50 UTC (rev 120236)
+++ trunk/LayoutTests/platform/qt/Skipped	2012-06-13 19:45:39 UTC (rev 120237)
@@ -2511,10 +2511,6 @@
 # https://bugs.webkit.org/show_bug.cgi?id=88859
 http/tests/xmlhttprequest/response-blob-size.html
 
-# REGRESSION(r120108): It made http/tests/loading/gmail-assert-on-load.html fail
-# https://bugs.webkit.org/show_bug.cgi?id=88923
-http/tests/loading/gmail-assert-on-load.html
-
 # [Qt]REGRESSION(r120107): It made http/tests/xmlhttprequest/origin-exact-matching.html fails
 # https://bugs.webkit.org/show_bug.cgi?id=88913
 http/tests/xmlhttprequest/origin-exact-matching.html
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to