Title: [120254] trunk/Source/WebKit/chromium
- Revision
- 120254
- Author
- [email protected]
- Date
- 2012-06-13 15:58:31 -0700 (Wed, 13 Jun 2012)
Log Message
[Chromium] Crash when WebViewImpl::setIsTransparent is called before the WebLayerTreeView has been initialized.
https://bugs.webkit.org/show_bug.cgi?id=89013
Patch by David Reveman <[email protected]> on 2012-06-13
Reviewed by James Robinson.
Add !m_layerTreeView.isNull() check to WebViewImpl::setIsTransparent.
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setIsTransparent):
Modified Paths
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (120253 => 120254)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-06-13 22:55:18 UTC (rev 120253)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-06-13 22:58:31 UTC (rev 120254)
@@ -1,3 +1,15 @@
+2012-06-13 David Reveman <[email protected]>
+
+ [Chromium] Crash when WebViewImpl::setIsTransparent is called before the WebLayerTreeView has been initialized.
+ https://bugs.webkit.org/show_bug.cgi?id=89013
+
+ Reviewed by James Robinson.
+
+ Add !m_layerTreeView.isNull() check to WebViewImpl::setIsTransparent.
+
+ * src/WebViewImpl.cpp:
+ (WebKit::WebViewImpl::setIsTransparent):
+
2012-06-13 Sheriff Bot <[email protected]>
Unreviewed, rolling out r120220.
Modified: trunk/Source/WebKit/chromium/src/WebViewImpl.cpp (120253 => 120254)
--- trunk/Source/WebKit/chromium/src/WebViewImpl.cpp 2012-06-13 22:55:18 UTC (rev 120253)
+++ trunk/Source/WebKit/chromium/src/WebViewImpl.cpp 2012-06-13 22:58:31 UTC (rev 120254)
@@ -3034,7 +3034,8 @@
if (m_nonCompositedContentHost)
m_nonCompositedContentHost->setOpaque(!isTransparent);
- m_layerTreeView.setHasTransparentBackground(isTransparent);
+ if (!m_layerTreeView.isNull())
+ m_layerTreeView.setHasTransparentBackground(isTransparent);
}
bool WebViewImpl::isTransparent() const
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
