Title: [120434] trunk/Source/WebKit/blackberry
Revision
120434
Author
[email protected]
Date
2012-06-15 02:58:10 -0700 (Fri, 15 Jun 2012)

Log Message

Unreviewed, rolling out r120404.
http://trac.webkit.org/changeset/120404
https://bugs.webkit.org/show_bug.cgi?id=89193

This patch breaks [BlackBerry]'s text selection handles moving
in editable elements. (Requested by Sean1 on #webkit).

Patch by Sheriff Bot <[email protected]> on 2012-06-15

* WebKitSupport/SelectionHandler.cpp:
(BlackBerry::WebKit::visiblePositionForPointIgnoringClipping):

Modified Paths

Diff

Modified: trunk/Source/WebKit/blackberry/ChangeLog (120433 => 120434)


--- trunk/Source/WebKit/blackberry/ChangeLog	2012-06-15 09:57:13 UTC (rev 120433)
+++ trunk/Source/WebKit/blackberry/ChangeLog	2012-06-15 09:58:10 UTC (rev 120434)
@@ -1,3 +1,15 @@
+2012-06-15  Sheriff Bot  <[email protected]>
+
+        Unreviewed, rolling out r120404.
+        http://trac.webkit.org/changeset/120404
+        https://bugs.webkit.org/show_bug.cgi?id=89193
+
+        This patch breaks [BlackBerry]'s text selection handles moving
+        in editable elements. (Requested by Sean1 on #webkit).
+
+        * WebKitSupport/SelectionHandler.cpp:
+        (BlackBerry::WebKit::visiblePositionForPointIgnoringClipping):
+
 2012-06-14  Sean Wang  <[email protected]>
 
         [BlackBerry] Selection - Crash when manipulating selection by dragging handle

Modified: trunk/Source/WebKit/blackberry/WebKitSupport/SelectionHandler.cpp (120433 => 120434)


--- trunk/Source/WebKit/blackberry/WebKitSupport/SelectionHandler.cpp	2012-06-15 09:57:13 UTC (rev 120433)
+++ trunk/Source/WebKit/blackberry/WebKitSupport/SelectionHandler.cpp	2012-06-15 09:58:10 UTC (rev 120434)
@@ -152,7 +152,7 @@
     // outside the visible rect. To work around the bug, this is a copy of
     // visiblePositionAtPoint which which passes ignoreClipping=true.
     // See RIM Bug #4315.
-    HitTestResult result = frame.eventHandler()->hitTestResultAtPoint(framePoint, false /* allowShadowContent */, true /* ignoreClipping */);
+    HitTestResult result = frame.eventHandler()->hitTestResultAtPoint(framePoint, true /* allowShadowContent */, true /* ignoreClipping */);
 
     Node* node = result.innerNode();
     if (!node || node->document() != frame.document())
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to