Title: [120614] trunk/Tools
- Revision
- 120614
- Author
- [email protected]
- Date
- 2012-06-18 12:02:37 -0700 (Mon, 18 Jun 2012)
Log Message
[garden-o-matic] Builder names without underscores cause incorrect BuildSelector behavior
https://bugs.webkit.org/show_bug.cgi?id=89362
Reviewed by Simon Fraser.
Replace white spaces, braces and dots in the builder name with underscores. This
way the JQuery tabs will be properly matched with the according container.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
Modified Paths
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js (120613 => 120614)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js 2012-06-18 18:52:35 UTC (rev 120613)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js 2012-06-18 19:02:37 UTC (rev 120614)
@@ -442,4 +442,8 @@
);
}
+base.underscoredBuilderName = function(builderName) {
+ return builderName.replace(/[ .()]/g, '_');
+}
+
})();
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js (120613 => 120614)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js 2012-06-18 18:52:35 UTC (rev 120613)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js 2012-06-18 19:02:37 UTC (rev 120614)
@@ -76,7 +76,7 @@
useDirectoryListingForOldBuilds: true,
useFlakinessDashboard: true,
resultsDirectoryNameFromBuilderName: function(builderName) {
- return builderName.replace(/[ .()]/g, '_');
+ return base.underscoredBuilderName(builderName);
},
resultsDirectoryForBuildNumber: function(buildNumber, revision) {
return buildNumber;
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js (120613 => 120614)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js 2012-06-18 18:52:35 UTC (rev 120613)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js 2012-06-18 19:02:37 UTC (rev 120614)
@@ -367,14 +367,14 @@
var tabStrip = this.appendChild(document.createElement('ul'));
Object.keys(resultsByBuilder).sort().forEach(function(builderName) {
- var builderDirectory = results.directoryForBuilder(builderName);
+ var builderHash = base.underscoredBuilderName(builderName);
var link = document.createElement('a');
- $(link).attr('href', "#" + builderDirectory).text(ui.displayNameForBuilder(builderName));
+ $(link).attr('href', "#" + builderHash).text(ui.displayNameForBuilder(builderName));
tabStrip.appendChild(document.createElement('li')).appendChild(link);
var content = this._delegate.contentForTestAndBuilder(testName, builderName);
- content.id = builderDirectory;
+ content.id = builderHash;
this.appendChild(content);
}, this);
Modified: trunk/Tools/ChangeLog (120613 => 120614)
--- trunk/Tools/ChangeLog 2012-06-18 18:52:35 UTC (rev 120613)
+++ trunk/Tools/ChangeLog 2012-06-18 19:02:37 UTC (rev 120614)
@@ -1,3 +1,15 @@
+2012-06-18 Zan Dobersek <[email protected]>
+
+ [garden-o-matic] Builder names without underscores cause incorrect BuildSelector behavior
+ https://bugs.webkit.org/show_bug.cgi?id=89362
+
+ Reviewed by Simon Fraser.
+
+ Replace white spaces, braces and dots in the builder name with underscores. This
+ way the JQuery tabs will be properly matched with the according container.
+
+ * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
+
2012-06-18 Dirk Pranke <[email protected]>
nrwt: metered output doesn't handle ^C cleanly
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
