Title: [120638] trunk
- Revision
- 120638
- Author
- [email protected]
- Date
- 2012-06-18 16:09:36 -0700 (Mon, 18 Jun 2012)
Log Message
REGRESSION(r118414): some pages on concursolutions.com doesn't show up
https://bugs.webkit.org/show_bug.cgi?id=89399
Reviewed by Adam Barth.
Source/WebCore:
The bug was caused by insertAdjacentHTML's not passing context element to createFragmentForInnerOuterHTML.
Test: fast/html/adjacent-html-context-element.html
* html/HTMLElement.cpp:
(WebCore::HTMLElement::insertAdjacentHTML):
LayoutTests:
Add a regression test.
* fast/html/adjacent-html-context-element-expected.txt: Added.
* fast/html/adjacent-html-context-element.html: Added.
Modified Paths
Added Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (120637 => 120638)
--- trunk/LayoutTests/ChangeLog 2012-06-18 23:03:31 UTC (rev 120637)
+++ trunk/LayoutTests/ChangeLog 2012-06-18 23:09:36 UTC (rev 120638)
@@ -1,3 +1,15 @@
+2012-06-18 Ryosuke Niwa <[email protected]>
+
+ REGRESSION(r118414): some pages on concursolutions.com doesn't show up
+ https://bugs.webkit.org/show_bug.cgi?id=89399
+
+ Reviewed by Adam Barth.
+
+ Add a regression test.
+
+ * fast/html/adjacent-html-context-element-expected.txt: Added.
+ * fast/html/adjacent-html-context-element.html: Added.
+
2012-06-18 Andrew Wilson <[email protected]>
Unreviewed expectations update for chromium after r120602.
Added: trunk/LayoutTests/fast/html/adjacent-html-context-element-expected.txt (0 => 120638)
--- trunk/LayoutTests/fast/html/adjacent-html-context-element-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/html/adjacent-html-context-element-expected.txt 2012-06-18 23:09:36 UTC (rev 120638)
@@ -0,0 +1,3 @@
+This tests inserting a td element "beforeBegin" of another td element using insertAdjacentHTML. If the context element was not properly adjusted, then td will be stripped by the parser.
+
+PASS
Added: trunk/LayoutTests/fast/html/adjacent-html-context-element.html (0 => 120638)
--- trunk/LayoutTests/fast/html/adjacent-html-context-element.html (rev 0)
+++ trunk/LayoutTests/fast/html/adjacent-html-context-element.html 2012-06-18 23:09:36 UTC (rev 120638)
@@ -0,0 +1,19 @@
+<!DOCTYPE html>
+<html>
+<body>
+<p>This tests inserting a td element "beforeBegin" of another td element using insertAdjacentHTML.
+If the context element was not properly adjusted, then td will be stripped by the parser.</p>
+<table><tr><td></td></tr></table>
+<script>
+
+if (window.testRunner)
+ testRunner.dumpAsText();
+
+var td = document.querySelector('td');
+td.insertAdjacentHTML('beforeBegin', '<td></td>');
+
+document.write(document.getElementsByTagName('td').length == 2 ? 'PASS' : 'FAIL');
+
+</script>
+</body>
+</html>
Modified: trunk/Source/WebCore/ChangeLog (120637 => 120638)
--- trunk/Source/WebCore/ChangeLog 2012-06-18 23:03:31 UTC (rev 120637)
+++ trunk/Source/WebCore/ChangeLog 2012-06-18 23:09:36 UTC (rev 120638)
@@ -1,3 +1,17 @@
+2012-06-18 Ryosuke Niwa <[email protected]>
+
+ REGRESSION(r118414): some pages on concursolutions.com doesn't show up
+ https://bugs.webkit.org/show_bug.cgi?id=89399
+
+ Reviewed by Adam Barth.
+
+ The bug was caused by insertAdjacentHTML's not passing context element to createFragmentForInnerOuterHTML.
+
+ Test: fast/html/adjacent-html-context-element.html
+
+ * html/HTMLElement.cpp:
+ (WebCore::HTMLElement::insertAdjacentHTML):
+
2012-06-18 Zhenyao Mo <[email protected]>
Fix framebuffer-object-attachment.html failures
Modified: trunk/Source/WebCore/html/HTMLElement.cpp (120637 => 120638)
--- trunk/Source/WebCore/html/HTMLElement.cpp 2012-06-18 23:03:31 UTC (rev 120637)
+++ trunk/Source/WebCore/html/HTMLElement.cpp 2012-06-18 23:09:36 UTC (rev 120638)
@@ -578,7 +578,7 @@
Element* contextElement = contextElementForInsertion(where, this, ec);
if (!contextElement)
return;
- RefPtr<DocumentFragment> fragment = createFragmentForInnerOuterHTML(markup, this, AllowScriptingContent, ec);
+ RefPtr<DocumentFragment> fragment = createFragmentForInnerOuterHTML(markup, contextElement, AllowScriptingContent, ec);
if (!fragment)
return;
insertAdjacent(where, fragment.get(), ec);
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
