Title: [120680] trunk/Source/WebCore
- Revision
- 120680
- Author
- [email protected]
- Date
- 2012-06-18 23:33:44 -0700 (Mon, 18 Jun 2012)
Log Message
[Mac] Editor::fontAttributesForSelectionStart() leaks a NSShadow
https://bugs.webkit.org/show_bug.cgi?id=89424
Reviewed by Dan Bernstein.
* editing/mac/EditorMac.mm:
(WebCore::Editor::fontAttributesForSelectionStart): Store the NSShadow
in a RetainPtr so that it's released before going out of scope.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (120679 => 120680)
--- trunk/Source/WebCore/ChangeLog 2012-06-19 06:20:48 UTC (rev 120679)
+++ trunk/Source/WebCore/ChangeLog 2012-06-19 06:33:44 UTC (rev 120680)
@@ -1,3 +1,14 @@
+2012-06-18 Andy Estes <[email protected]>
+
+ [Mac] Editor::fontAttributesForSelectionStart() leaks a NSShadow
+ https://bugs.webkit.org/show_bug.cgi?id=89424
+
+ Reviewed by Dan Bernstein.
+
+ * editing/mac/EditorMac.mm:
+ (WebCore::Editor::fontAttributesForSelectionStart): Store the NSShadow
+ in a RetainPtr so that it's released before going out of scope.
+
2012-06-18 Kent Tamura <[email protected]>
Refactoring: Introduce a class to represent restoring state of a form control
Modified: trunk/Source/WebCore/editing/mac/EditorMac.mm (120679 => 120680)
--- trunk/Source/WebCore/editing/mac/EditorMac.mm 2012-06-19 06:20:48 UTC (rev 120679)
+++ trunk/Source/WebCore/editing/mac/EditorMac.mm 2012-06-19 06:33:44 UTC (rev 120680)
@@ -204,11 +204,11 @@
const ShadowData* shadow = style->textShadow();
if (shadow) {
- NSShadow* s = [[NSShadow alloc] init];
- [s setShadowOffset:NSMakeSize(shadow->x(), shadow->y())];
- [s setShadowBlurRadius:shadow->blur()];
- [s setShadowColor:nsColor(shadow->color())];
- [result setObject:s forKey:NSShadowAttributeName];
+ RetainPtr<NSShadow> s(AdoptNS, [[NSShadow alloc] init]);
+ [s.get() setShadowOffset:NSMakeSize(shadow->x(), shadow->y())];
+ [s.get() setShadowBlurRadius:shadow->blur()];
+ [s.get() setShadowColor:nsColor(shadow->color())];
+ [result setObject:s.get() forKey:NSShadowAttributeName];
}
int decoration = style->textDecorationsInEffect();
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
