Title: [120697] trunk/Source/WTF
Revision
120697
Author
[email protected]
Date
2012-06-19 02:12:19 -0700 (Tue, 19 Jun 2012)

Log Message

REGRESSION(r120552): Many tests timing out on Windows
https://bugs.webkit.org/show_bug.cgi?id=89433

Reviewed by Andy Estes.

* wtf/CurrentTime.cpp:
(WTF::lowResUTCTime):
It looks like there were two bugs:
1) the function was converting from 100ths of nanoseconds to seconds
   rather than 100s of nanoseconds to seconds by dividing by
   (nsPerSecond * 100) rather than (nsPerSecond / 100)
2) the function should've been returning milliseconds, not seconds

Modified Paths

Diff

Modified: trunk/Source/WTF/ChangeLog (120696 => 120697)


--- trunk/Source/WTF/ChangeLog	2012-06-19 09:10:09 UTC (rev 120696)
+++ trunk/Source/WTF/ChangeLog	2012-06-19 09:12:19 UTC (rev 120697)
@@ -1,3 +1,18 @@
+2012-06-19  Jon Honeycutt  <[email protected]>
+
+        REGRESSION(r120552): Many tests timing out on Windows
+        https://bugs.webkit.org/show_bug.cgi?id=89433
+
+        Reviewed by Andy Estes.
+
+        * wtf/CurrentTime.cpp:
+        (WTF::lowResUTCTime):
+        It looks like there were two bugs:
+        1) the function was converting from 100ths of nanoseconds to seconds
+           rather than 100s of nanoseconds to seconds by dividing by
+           (nsPerSecond * 100) rather than (nsPerSecond / 100)
+        2) the function should've been returning milliseconds, not seconds
+
 2012-06-18  Tony Payne  <[email protected]>
 
         [chromium] Add iccjpeg and qcms to chromium port.

Modified: trunk/Source/WTF/wtf/CurrentTime.cpp (120696 => 120697)


--- trunk/Source/WTF/wtf/CurrentTime.cpp	2012-06-19 09:10:09 UTC (rev 120696)
+++ trunk/Source/WTF/wtf/CurrentTime.cpp	2012-06-19 09:12:19 UTC (rev 120697)
@@ -71,7 +71,7 @@
 
 // Number of 100 nanosecond between January 1, 1601 and January 1, 1970.
 static const ULONGLONG epochBias = 116444736000000000ULL;
-static const double nsPerSecond = 1000000000.0;
+static const double hundredsOfNanosecondsPerMillisecond = 10000;
 
 static double lowResUTCTime()
 {
@@ -91,7 +91,7 @@
     memcpy(&dateTime, &fileTime, sizeof(dateTime));
 
     // Windows file times are in 100s of nanoseconds.
-    return (dateTime.QuadPart - epochBias) / (100 * nsPerSecond);
+    return (dateTime.QuadPart - epochBias) / hundredsOfNanosecondsPerMillisecond;
 }
 
 #if USE(QUERY_PERFORMANCE_COUNTER)
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to