Title: [120726] trunk/Source/WebKit/mac
- Revision
- 120726
- Author
- [email protected]
- Date
- 2012-06-19 10:09:32 -0700 (Tue, 19 Jun 2012)
Log Message
[Mac] -[WebPDFView _menuItemsFromPDFKitForEvent:] leaks NSMenuItems
https://bugs.webkit.org/show_bug.cgi?id=89434
Reviewed by Darin Adler.
* WebView/WebPDFView.mm:
(-[WebPDFView _menuItemsFromPDFKitForEvent:]): Release copied
NSMenuItems once they're stored in copiedItems.
Modified Paths
Diff
Modified: trunk/Source/WebKit/mac/ChangeLog (120725 => 120726)
--- trunk/Source/WebKit/mac/ChangeLog 2012-06-19 16:37:40 UTC (rev 120725)
+++ trunk/Source/WebKit/mac/ChangeLog 2012-06-19 17:09:32 UTC (rev 120726)
@@ -1,3 +1,14 @@
+2012-06-18 Andy Estes <[email protected]>
+
+ [Mac] -[WebPDFView _menuItemsFromPDFKitForEvent:] leaks NSMenuItems
+ https://bugs.webkit.org/show_bug.cgi?id=89434
+
+ Reviewed by Darin Adler.
+
+ * WebView/WebPDFView.mm:
+ (-[WebPDFView _menuItemsFromPDFKitForEvent:]): Release copied
+ NSMenuItems once they're stored in copiedItems.
+
2012-06-19 Mike West <[email protected]>
Introduce ENABLE_CSP_NEXT configuration flag.
Modified: trunk/Source/WebKit/mac/WebView/WebPDFView.mm (120725 => 120726)
--- trunk/Source/WebKit/mac/WebView/WebPDFView.mm 2012-06-19 16:37:40 UTC (rev 120725)
+++ trunk/Source/WebKit/mac/WebView/WebPDFView.mm 2012-06-19 17:09:32 UTC (rev 120726)
@@ -1151,6 +1151,7 @@
// want to modify the original menu supplied by PDFKit.
NSMenuItem *itemCopy = [item copy];
[copiedItems addObject:itemCopy];
+ [itemCopy release];
// Include all of PDFKit's separators for now. At the end we'll remove any ones that were made
// useless by removing PDFKit's menu items.
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
