Title: [120743] trunk/Tools
- Revision
- 120743
- Author
- [email protected]
- Date
- 2012-06-19 12:22:21 -0700 (Tue, 19 Jun 2012)
Log Message
Fix regression introduced in r120646 where the svn revision isn't saved in results.json
Unreviewed, build fix.
It turns out that we store the svn revision two different ways
in the JSON, and I only caught one of them :(. This should fix
the other.
Also, this part of the code is poorly tested. I will investigate
adding at least a basic test for this in a separate fix.
* Scripts/webkitpy/layout_tests/controllers/manager.py:
(summarize_results):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (120742 => 120743)
--- trunk/Tools/ChangeLog 2012-06-19 19:17:31 UTC (rev 120742)
+++ trunk/Tools/ChangeLog 2012-06-19 19:22:21 UTC (rev 120743)
@@ -1,5 +1,21 @@
2012-06-19 Dirk Pranke <[email protected]>
+ Fix regression introduced in r120646 where the svn revision isn't saved in results.json
+
+ Unreviewed, build fix.
+
+ It turns out that we store the svn revision two different ways
+ in the JSON, and I only caught one of them :(. This should fix
+ the other.
+
+ Also, this part of the code is poorly tested. I will investigate
+ adding at least a basic test for this in a separate fix.
+
+ * Scripts/webkitpy/layout_tests/controllers/manager.py:
+ (summarize_results):
+
+2012-06-19 Dirk Pranke <[email protected]>
+
REGRESSION (NRWT): Results for new non-text-only tests are always put in the most-specific platform directory
https://bugs.webkit.org/show_bug.cgi?id=78127
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py (120742 => 120743)
--- trunk/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py 2012-06-19 19:17:31 UTC (rev 120742)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py 2012-06-19 19:22:21 UTC (rev 120743)
@@ -242,6 +242,7 @@
# We only use the svn revision for using trac links in the results.html file,
# Don't do this by default since it takes >100ms.
if use_trac_links_in_results_html(port_obj):
+ port_obj.host._initialize_scm()
results['revision'] = port_obj.host.scm().head_svn_revision()
except Exception, e:
_log.warn("Failed to determine svn revision for checkout (cwd: %s, webkit_base: %s), leaving 'revision' key blank in full_results.json.\n%s" % (port_obj._filesystem.getcwd(), port_obj.path_from_webkit_base(), e))
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
