Title: [120785] trunk/Tools
- Revision
- 120785
- Author
- [email protected]
- Date
- 2012-06-19 18:31:29 -0700 (Tue, 19 Jun 2012)
Log Message
webkitpy: Simplify fetch_bugs_matching_search()
https://bugs.webkit.org/show_bug.cgi?id=89497
Patch by Thiago Marcos P. Santos <[email protected]> on 2012-06-19
Reviewed by Adam Barth.
Removed parameter with default value. It's not being used
and the handling of the parameter was wrong. Saves a check.
* Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
(BugzillaQueries.fetch_bugs_matching_search):
* Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
(MockBugzillaQueries.fetch_bugs_matching_search):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (120784 => 120785)
--- trunk/Tools/ChangeLog 2012-06-20 01:29:26 UTC (rev 120784)
+++ trunk/Tools/ChangeLog 2012-06-20 01:31:29 UTC (rev 120785)
@@ -1,3 +1,18 @@
+2012-06-19 Thiago Marcos P. Santos <[email protected]>
+
+ webkitpy: Simplify fetch_bugs_matching_search()
+ https://bugs.webkit.org/show_bug.cgi?id=89497
+
+ Reviewed by Adam Barth.
+
+ Removed parameter with default value. It's not being used
+ and the handling of the parameter was wrong. Saves a check.
+
+ * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
+ (BugzillaQueries.fetch_bugs_matching_search):
+ * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
+ (MockBugzillaQueries.fetch_bugs_matching_search):
+
2012-06-19 Dirk Pranke <[email protected]>
webkitpy: remove unneeded imports in layout_tests/port/chromium.py
Modified: trunk/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py (120784 => 120785)
--- trunk/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py 2012-06-20 01:29:26 UTC (rev 120784)
+++ trunk/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py 2012-06-20 01:31:29 UTC (rev 120785)
@@ -209,12 +209,10 @@
# Currently this returns all bugs across all components.
# In the future we may wish to extend this API to construct more restricted searches.
- def fetch_bugs_matching_search(self, search_string, author_email=None):
+ def fetch_bugs_matching_search(self, search_string):
query = "buglist.cgi?query_format=advanced"
if search_string:
query += "&short_desc_type=allwordssubstr&short_desc=%s" % urllib.quote(search_string)
- if author_email:
- query += "&emailreporter1=1&emailtype1=substring&email1=%s" % urllib.quote(search_string)
return self._fetch_bugs_from_advanced_query(query)
def fetch_patches_from_pending_commit_list(self):
Modified: trunk/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py (120784 => 120785)
--- trunk/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py 2012-06-20 01:29:26 UTC (rev 120784)
+++ trunk/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py 2012-06-20 01:31:29 UTC (rev 120785)
@@ -269,7 +269,7 @@
def fetch_patches_from_pending_commit_list(self):
return sum([bug.reviewed_patches() for bug in self._all_bugs()], [])
- def fetch_bugs_matching_search(self, search_string, author_email=None):
+ def fetch_bugs_matching_search(self, search_string):
return [self._bugzilla.fetch_bug(50004), self._bugzilla.fetch_bug(50003)]
def fetch_bugs_matching_quicksearch(self, search_string):
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
