Diff
Modified: trunk/LayoutTests/ChangeLog (120796 => 120797)
--- trunk/LayoutTests/ChangeLog 2012-06-20 04:26:13 UTC (rev 120796)
+++ trunk/LayoutTests/ChangeLog 2012-06-20 04:31:37 UTC (rev 120797)
@@ -1,3 +1,18 @@
+2012-06-19 Takashi Sakamoto <[email protected]>
+
+ [Shadow DOM] ShadowRoot.host should be gone
+ https://bugs.webkit.org/show_bug.cgi?id=88387
+
+ Reviewed by Dimitri Glazkov.
+
+ * fast/css/style-scoped/style-scoped-in-shadow-expected.txt:
+ * fast/css/style-scoped/style-scoped-in-shadow.html:
+ * fast/dom/shadow/resources/shadow-dom.js:
+ (isShadowRoot):
+ * fast/dom/shadow/shadow-root-js-api-expected.txt:
+ * fast/dom/shadow/shadow-root-js-api.html:
+ Just removed references to shadow root's host attribute.
+
2012-06-19 Kent Tamura <[email protected]>
Fix a form restore test broken by HTML5 parser
Modified: trunk/LayoutTests/fast/css/style-scoped/style-scoped-in-shadow-expected.txt (120796 => 120797)
--- trunk/LayoutTests/fast/css/style-scoped/style-scoped-in-shadow-expected.txt 2012-06-20 04:26:13 UTC (rev 120796)
+++ trunk/LayoutTests/fast/css/style-scoped/style-scoped-in-shadow-expected.txt 2012-06-20 04:31:37 UTC (rev 120797)
@@ -3,7 +3,6 @@
PASS window.internals is defined.
PASS window.internals.ensureShadowRoot is defined.
PASS WebKitShadowRoot is defined.
-PASS shadow.host is defined.
PASS shadow.innerHTML is defined.
PASS shadow.getElementById is defined.
A: rgb(0, 0, 0)
Modified: trunk/LayoutTests/fast/css/style-scoped/style-scoped-in-shadow.html (120796 => 120797)
--- trunk/LayoutTests/fast/css/style-scoped/style-scoped-in-shadow.html 2012-06-20 04:26:13 UTC (rev 120796)
+++ trunk/LayoutTests/fast/css/style-scoped/style-scoped-in-shadow.html 2012-06-20 04:31:37 UTC (rev 120797)
@@ -17,7 +17,6 @@
var a = document.getElementById("A");
var b = document.getElementById("B");
shadow = new WebKitShadowRoot(b);
- shouldBeDefined("shadow.host");
shouldBeDefined("shadow.innerHTML");
shouldBeDefined("shadow.getElementById");
shadow.innerHTML = "<style scoped>div { color: red; }</style><content></content><div id='C'>CCC</div>";
Modified: trunk/LayoutTests/fast/dom/shadow/resources/shadow-dom.js (120796 => 120797)
--- trunk/LayoutTests/fast/dom/shadow/resources/shadow-dom.js 2012-06-20 04:26:13 UTC (rev 120796)
+++ trunk/LayoutTests/fast/dom/shadow/resources/shadow-dom.js 2012-06-20 04:31:37 UTC (rev 120797)
@@ -42,7 +42,7 @@
function isShadowRoot(node)
{
// FIXME: window.internals should have internals.isShadowRoot(node).
- return node.nodeName == "#shadow-root" || node.host;
+ return node.nodeName == "#shadow-root";
}
function isIframeElement(element)
Modified: trunk/LayoutTests/fast/dom/shadow/shadow-root-js-api-expected.txt (120796 => 120797)
--- trunk/LayoutTests/fast/dom/shadow/shadow-root-js-api-expected.txt 2012-06-20 04:26:13 UTC (rev 120796)
+++ trunk/LayoutTests/fast/dom/shadow/shadow-root-js-api-expected.txt 2012-06-20 04:31:37 UTC (rev 120797)
@@ -7,9 +7,6 @@
PASS new WebKitShadowRoot(undefined) threw exception Error: HIERARCHY_REQUEST_ERR: DOM Exception 3.
PASS new WebKitShadowRoot(null) threw exception Error: HIERARCHY_REQUEST_ERR: DOM Exception 3.
PASS new WebKitShadowRoot(1) threw exception Error: HIERARCHY_REQUEST_ERR: DOM Exception 3.
-PASS shadowHost is shadowRoot.host
-The previous test should not have side effects.
-PASS shadowHost is shadowRoot.host
PASS shadowRoot.getElementById('div1') is div1
PASS shadowRoot.getElementById('foo') is null
PASS shadowRoot.getElementsByClassName('class2') is [div2]
Modified: trunk/LayoutTests/fast/dom/shadow/shadow-root-js-api.html (120796 => 120797)
--- trunk/LayoutTests/fast/dom/shadow/shadow-root-js-api.html 2012-06-20 04:26:13 UTC (rev 120796)
+++ trunk/LayoutTests/fast/dom/shadow/shadow-root-js-api.html 2012-06-20 04:31:37 UTC (rev 120797)
@@ -21,9 +21,6 @@
var shadowHost = document.createElement('div');
document.body.appendChild(shadowHost);
var shadowRoot = new WebKitShadowRoot(shadowHost);
-shouldBe("shadowHost", "shadowRoot.host");
-debug('The previous test should not have side effects.');
-shouldBe("shadowHost", "shadowRoot.host");
var div1 = document.createElement("div");
div1.setAttribute("id", "div1");
Modified: trunk/Source/WebCore/ChangeLog (120796 => 120797)
--- trunk/Source/WebCore/ChangeLog 2012-06-20 04:26:13 UTC (rev 120796)
+++ trunk/Source/WebCore/ChangeLog 2012-06-20 04:31:37 UTC (rev 120797)
@@ -1,3 +1,19 @@
+2012-06-19 Takashi Sakamoto <[email protected]>
+
+ [Shadow DOM] ShadowRoot.host should be gone
+ https://bugs.webkit.org/show_bug.cgi?id=88387
+
+ According to the w3c spec change,
+ i.e. https://www.w3.org/Bugs/Public/show_bug.cgi?id=16764
+ Removed host attribute from ShadowRoot.idl.
+
+ Reviewed by Dimitri Glazkov.
+
+ No new tests, because this change modified only idl.
+
+ * dom/ShadowRoot.idl:
+ Just removed host attribute.
+
2012-06-19 Adam Klein <[email protected]>
Pass ScriptValue by const ref where possible
Modified: trunk/Source/WebCore/dom/ShadowRoot.idl (120796 => 120797)
--- trunk/Source/WebCore/dom/ShadowRoot.idl 2012-06-20 04:26:13 UTC (rev 120796)
+++ trunk/Source/WebCore/dom/ShadowRoot.idl 2012-06-20 04:31:37 UTC (rev 120797)
@@ -32,7 +32,6 @@
ConstructorRaisesException,
JSGenerateToJSObject
] ShadowRoot : DocumentFragment {
- readonly attribute Element host;
readonly attribute Element activeElement;
attribute boolean applyAuthorStyles;
attribute boolean resetStyleInheritance;
