Title: [120917] trunk/Tools
- Revision
- 120917
- Author
- [email protected]
- Date
- 2012-06-21 05:01:39 -0700 (Thu, 21 Jun 2012)
Log Message
[Qt] DRT in standalone mode hangs after the first test
https://bugs.webkit.org/show_bug.cgi?id=89613
Reviewed by Csaba Osztrogonác.
Break an inline signal slot chain that ends up in setting
LayoutTestController::m_hasDumped too early. In LayoutTestController::maybeDump()
we emit done() which starts the chain that finishes in DumpRenderTree::open().
The next line in maybeDump sets m_hasDumped to true. We could simply reorder
these two lines but it seems to be wrong in general to start the next load
from this call chain. The server mode (when DRT is runned by the test harness)
also uses a queued connection to read the next test from stdin.
* DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::DumpRenderTree::processArgsLine):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (120916 => 120917)
--- trunk/Tools/ChangeLog 2012-06-21 11:38:06 UTC (rev 120916)
+++ trunk/Tools/ChangeLog 2012-06-21 12:01:39 UTC (rev 120917)
@@ -1,3 +1,21 @@
+2012-06-21 Balazs Kelemen <[email protected]>
+
+ [Qt] DRT in standalone mode hangs after the first test
+ https://bugs.webkit.org/show_bug.cgi?id=89613
+
+ Reviewed by Csaba Osztrogonác.
+
+ Break an inline signal slot chain that ends up in setting
+ LayoutTestController::m_hasDumped too early. In LayoutTestController::maybeDump()
+ we emit done() which starts the chain that finishes in DumpRenderTree::open().
+ The next line in maybeDump sets m_hasDumped to true. We could simply reorder
+ these two lines but it seems to be wrong in general to start the next load
+ from this call chain. The server mode (when DRT is runned by the test harness)
+ also uses a queued connection to read the next test from stdin.
+
+ * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
+ (WebCore::DumpRenderTree::processArgsLine):
+
2012-06-20 Hans Wennborg <[email protected]>
Speech _javascript_ API: SpeechRecognition should hook up with ActiveDOMObject more
Modified: trunk/Tools/DumpRenderTree/qt/DumpRenderTreeQt.cpp (120916 => 120917)
--- trunk/Tools/DumpRenderTree/qt/DumpRenderTreeQt.cpp 2012-06-21 11:38:06 UTC (rev 120916)
+++ trunk/Tools/DumpRenderTree/qt/DumpRenderTreeQt.cpp 2012-06-21 12:01:39 UTC (rev 120917)
@@ -666,7 +666,7 @@
for (int i = 0; i < m_standAloneModeTestList.size(); ++i)
m_standAloneModeTestList[i] = folderEntry.absoluteFilePath(m_standAloneModeTestList[i]);
}
- connect(this, SIGNAL(ready()), this, SLOT(loadNextTestInStandAloneMode()));
+ connect(this, SIGNAL(ready()), this, SLOT(loadNextTestInStandAloneMode()), Qt::QueuedConnection);
if (!m_standAloneModeTestList.isEmpty()) {
QString first = m_standAloneModeTestList.takeFirst();
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
