Title: [120977] trunk/Tools
Revision
120977
Author
[email protected]
Date
2012-06-21 16:32:04 -0700 (Thu, 21 Jun 2012)

Log Message

DRT/WTR python interface handles about:blank incorrectly
https://bugs.webkit.org/show_bug.cgi?id=89563

Reviewed by Dirk Pranke.

Currently DRT/WTR python interface's _command_from_driver_input function
puts the test directory path before about:blank. Remove this incorrect behavior.

* Scripts/webkitpy/layout_tests/port/webkit.py:
(WebKitDriver._command_from_driver_input):

Modified Paths

Property Changed

Diff

Modified: trunk/Tools/ChangeLog (120976 => 120977)


--- trunk/Tools/ChangeLog	2012-06-21 23:28:43 UTC (rev 120976)
+++ trunk/Tools/ChangeLog	2012-06-21 23:32:04 UTC (rev 120977)
@@ -1,3 +1,16 @@
+2012-06-21  Zoltan Horvath  <[email protected]>
+
+        DRT/WTR python interface handles about:blank incorrectly
+        https://bugs.webkit.org/show_bug.cgi?id=89563
+
+        Reviewed by Dirk Pranke.
+
+        Currently DRT/WTR python interface's _command_from_driver_input function
+        puts the test directory path before about:blank. Remove this incorrect behavior.
+
+        * Scripts/webkitpy/layout_tests/port/webkit.py:
+        (WebKitDriver._command_from_driver_input):
+
 2012-06-21  Dirk Pranke  <[email protected]>
 
         reenable perf tests on win

Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit.py (120976 => 120977)


--- trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit.py	2012-06-21 23:28:43 UTC (rev 120976)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit.py	2012-06-21 23:32:04 UTC (rev 120977)
@@ -525,7 +525,7 @@
 
     def _command_from_driver_input(self, driver_input):
         # FIXME: performance tests pass in full URLs instead of test names.
-        if driver_input.test_name.startswith('http://') or driver_input.test_name.startswith('https://'):
+        if driver_input.test_name.startswith('http://') or driver_input.test_name.startswith('https://')  or driver_input.test_name == ('about:blank'):
             command = driver_input.test_name
         elif self.is_http_test(driver_input.test_name):
             command = self.test_to_uri(driver_input.test_name)
Property changes on: trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit.py
___________________________________________________________________

Added: svn:executable

_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to