Title: [120995] trunk/Source/WebKit/chromium
- Revision
- 120995
- Author
- [email protected]
- Date
- 2012-06-21 19:39:22 -0700 (Thu, 21 Jun 2012)
Log Message
[chromium] Initialize compositor's visibility state upon initialization
https://bugs.webkit.org/show_bug.cgi?id=89712
Patch by James Robinson <[email protected]> on 2012-06-21
Reviewed by Adrienne Walker.
A given WebViewImpl's visibility state might change any number of times before compositing is enabled. If the
visibility state is not the default (visible) when the compositor is initialized, we need to let it know the
correct visibility state or it will start ticking uselessly in threaded mode.
Tested manually, there's no way to create a new WebViewImpl in a non-visible state in a WebKit test that I know
of.
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
Modified Paths
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (120994 => 120995)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-06-22 02:37:07 UTC (rev 120994)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-06-22 02:39:22 UTC (rev 120995)
@@ -1,3 +1,20 @@
+2012-06-21 James Robinson <[email protected]>
+
+ [chromium] Initialize compositor's visibility state upon initialization
+ https://bugs.webkit.org/show_bug.cgi?id=89712
+
+ Reviewed by Adrienne Walker.
+
+ A given WebViewImpl's visibility state might change any number of times before compositing is enabled. If the
+ visibility state is not the default (visible) when the compositor is initialized, we need to let it know the
+ correct visibility state or it will start ticking uselessly in threaded mode.
+
+ Tested manually, there's no way to create a new WebViewImpl in a non-visible state in a WebKit test that I know
+ of.
+
+ * src/WebViewImpl.cpp:
+ (WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
+
2012-06-21 Sadrul Habib Chowdhury <[email protected]>
[chromium] Add touch-event support for WebPluginContainerImpl
Modified: trunk/Source/WebKit/chromium/src/WebViewImpl.cpp (120994 => 120995)
--- trunk/Source/WebKit/chromium/src/WebViewImpl.cpp 2012-06-22 02:37:07 UTC (rev 120994)
+++ trunk/Source/WebKit/chromium/src/WebViewImpl.cpp 2012-06-22 02:39:22 UTC (rev 120995)
@@ -3537,6 +3537,8 @@
setDeviceScaleFactor(m_deviceScaleInCompositor);
}
+ bool visible = page()->visibilityState() == PageVisibilityStateVisible;
+ m_layerTreeView.setVisible(visible);
m_layerTreeView.setPageScaleFactorAndLimits(pageScaleFactor(), m_minimumPageScaleFactor, m_maximumPageScaleFactor);
if (m_compositorSurfaceReady)
m_layerTreeView.setSurfaceReady();
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
