Title: [121143] trunk/Source/WebKit2
- Revision
- 121143
- Author
- [email protected]
- Date
- 2012-06-25 01:42:39 -0700 (Mon, 25 Jun 2012)
Log Message
[GTK] Test /webkit2/WebKitWebView/permission-requests fails due to a runtime warning
https://bugs.webkit.org/show_bug.cgi?id=89858
Reviewed by Xan Lopez.
* UIProcess/API/gtk/tests/TestWebKitWebView.cpp:
(testWebViewPermissionRequests): Make runtime warnings non-fatal
for test /webkit2/WebKitWebView/permission-requests.
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (121142 => 121143)
--- trunk/Source/WebKit2/ChangeLog 2012-06-25 07:18:03 UTC (rev 121142)
+++ trunk/Source/WebKit2/ChangeLog 2012-06-25 08:42:39 UTC (rev 121143)
@@ -1,3 +1,14 @@
+2012-06-25 Carlos Garcia Campos <[email protected]>
+
+ [GTK] Test /webkit2/WebKitWebView/permission-requests fails due to a runtime warning
+ https://bugs.webkit.org/show_bug.cgi?id=89858
+
+ Reviewed by Xan Lopez.
+
+ * UIProcess/API/gtk/tests/TestWebKitWebView.cpp:
+ (testWebViewPermissionRequests): Make runtime warnings non-fatal
+ for test /webkit2/WebKitWebView/permission-requests.
+
2012-06-25 Huang Dongsung <[email protected]>
[GTK] Remove unused code in LayerTreeHostGtk.
Modified: trunk/Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitWebView.cpp (121142 => 121143)
--- trunk/Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitWebView.cpp 2012-06-25 07:18:03 UTC (rev 121142)
+++ trunk/Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitWebView.cpp 2012-06-25 08:42:39 UTC (rev 121143)
@@ -555,6 +555,10 @@
static void testWebViewPermissionRequests(UIClientTest* test, gconstpointer)
{
+ // Some versions of geoclue give a runtime warning because it tries
+ // to register the error quark twice. See https://bugs.webkit.org/show_bug.cgi?id=89858.
+ // Make warnings non-fatal for this test to make it pass.
+ test->removeLogFatalFlag(G_LOG_LEVEL_WARNING);
test->showInWindowAndWaitUntilMapped();
static const char* geolocationRequestHTML =
"<html>"
@@ -587,6 +591,7 @@
// Check that we did not get the PERMISSION_DENIED error now.
result = webkit_web_view_get_title(test->m_webView);
g_assert_cmpstr(result, !=, "1");
+ test->addLogFatalFlag(G_LOG_LEVEL_WARNING);
}
static void testWebViewZoomLevel(WebViewTest* test, gconstpointer)
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
