Title: [121155] trunk/Source/WebKit/blackberry
- Revision
- 121155
- Author
- [email protected]
- Date
- 2012-06-25 07:30:10 -0700 (Mon, 25 Jun 2012)
Log Message
[BlackBerry] Require text editable element to be enabled for VKB
https://bugs.webkit.org/show_bug.cgi?id=89876
Reviewed by Yong Li.
After bug 58837 got in, children of <fieldset> now can inherit the disabled
state of the fieldset. When trying for instance fast/forms/fieldset/fieldset-disabled.html,
it can be seen that when they are visually disabled, the input handling can still be triggered. So
add an extra check to isTextBasedContentEditableElement that the element is enabled.
Reviewed internally by Mike Fenton.
* WebKitSupport/DOMSupport.cpp:
(BlackBerry::WebKit::DOMSupport::isTextBasedContentEditableElement):
Modified Paths
Diff
Modified: trunk/Source/WebKit/blackberry/ChangeLog (121154 => 121155)
--- trunk/Source/WebKit/blackberry/ChangeLog 2012-06-25 14:26:48 UTC (rev 121154)
+++ trunk/Source/WebKit/blackberry/ChangeLog 2012-06-25 14:30:10 UTC (rev 121155)
@@ -1,3 +1,20 @@
+2012-06-25 Rob Buis <[email protected]>
+
+ [BlackBerry] Require text editable element to be enabled for VKB
+ https://bugs.webkit.org/show_bug.cgi?id=89876
+
+ Reviewed by Yong Li.
+
+ After bug 58837 got in, children of <fieldset> now can inherit the disabled
+ state of the fieldset. When trying for instance fast/forms/fieldset/fieldset-disabled.html,
+ it can be seen that when they are visually disabled, the input handling can still be triggered. So
+ add an extra check to isTextBasedContentEditableElement that the element is enabled.
+
+ Reviewed internally by Mike Fenton.
+
+ * WebKitSupport/DOMSupport.cpp:
+ (BlackBerry::WebKit::DOMSupport::isTextBasedContentEditableElement):
+
2012-06-24 Simon Fraser <[email protected]>
Rename isPositioned to isOutOfFlowPositioned for clarity
Modified: trunk/Source/WebKit/blackberry/WebKitSupport/DOMSupport.cpp (121154 => 121155)
--- trunk/Source/WebKit/blackberry/WebKitSupport/DOMSupport.cpp 2012-06-25 14:26:48 UTC (rev 121154)
+++ trunk/Source/WebKit/blackberry/WebKitSupport/DOMSupport.cpp 2012-06-25 14:30:10 UTC (rev 121155)
@@ -231,7 +231,7 @@
if (!element)
return false;
- if (element->isReadOnlyFormControl())
+ if (element->isReadOnlyFormControl() || !element->isEnabledFormControl())
return false;
if (isPopupInputField(element))
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
