Title: [121184] trunk/Source
Revision
121184
Author
[email protected]
Date
2012-06-25 15:01:23 -0700 (Mon, 25 Jun 2012)

Log Message

Use InterpolationLow on chromium-android
https://bugs.webkit.org/show_bug.cgi?id=89849

Reviewed by Daniel Bates.

Source/WebCore:

Min Qin writes:

  Using InterpolationHigh is very very expensive when resampling
  images.  For example, it took 1400ms to decode an image on
  http://www.crossfitsunnyvale.com/blog/, but it took 2800 ms to do the
  resampling Switch to InterpolationLow will result in linear
  resampling. It is much faster as the time it tooks is almost
  non-noticable [sic] on the trace.

* platform/graphics/skia/PlatformContextSkia.cpp:
(WebCore::PlatformContextSkia::State::State):

Source/WTF:

Introduce a USE macro to control image interpolation quality.

* wtf/Platform.h:

Modified Paths

Diff

Modified: trunk/Source/WTF/ChangeLog (121183 => 121184)


--- trunk/Source/WTF/ChangeLog	2012-06-25 21:57:14 UTC (rev 121183)
+++ trunk/Source/WTF/ChangeLog	2012-06-25 22:01:23 UTC (rev 121184)
@@ -1,3 +1,14 @@
+2012-06-25  Adam Barth  <[email protected]>
+
+        Use InterpolationLow on chromium-android
+        https://bugs.webkit.org/show_bug.cgi?id=89849
+
+        Reviewed by Daniel Bates.
+
+        Introduce a USE macro to control image interpolation quality.
+
+        * wtf/Platform.h:
+
 2012-06-25  Kent Tamura  <[email protected]>
 
         Change the serialization format of form control state to make the code simple

Modified: trunk/Source/WTF/wtf/Platform.h (121183 => 121184)


--- trunk/Source/WTF/wtf/Platform.h	2012-06-25 21:57:14 UTC (rev 121183)
+++ trunk/Source/WTF/wtf/Platform.h	2012-06-25 22:01:23 UTC (rev 121184)
@@ -474,6 +474,7 @@
 #define WTF_USE_QCMSLIB 1
 #elif OS(ANDROID)
 #define WTF_USE_SKIA 1
+#define WTF_USE_LOW_QUALITY_IMAGE_INTERPOLATION 1
 #else
 #define WTF_USE_SKIA 1
 #define WTF_USE_ICCJPEG 1

Modified: trunk/Source/WebCore/ChangeLog (121183 => 121184)


--- trunk/Source/WebCore/ChangeLog	2012-06-25 21:57:14 UTC (rev 121183)
+++ trunk/Source/WebCore/ChangeLog	2012-06-25 22:01:23 UTC (rev 121184)
@@ -1,3 +1,22 @@
+2012-06-25  Adam Barth  <[email protected]>
+
+        Use InterpolationLow on chromium-android
+        https://bugs.webkit.org/show_bug.cgi?id=89849
+
+        Reviewed by Daniel Bates.
+
+        Min Qin writes:
+
+          Using InterpolationHigh is very very expensive when resampling
+          images.  For example, it took 1400ms to decode an image on
+          http://www.crossfitsunnyvale.com/blog/, but it took 2800 ms to do the
+          resampling Switch to InterpolationLow will result in linear
+          resampling. It is much faster as the time it tooks is almost
+          non-noticable [sic] on the trace.
+
+        * platform/graphics/skia/PlatformContextSkia.cpp:
+        (WebCore::PlatformContextSkia::State::State):
+
 2012-06-25  Joshua Bell  <[email protected]>
 
         IndexedDB: Remove unused backend property accessors

Modified: trunk/Source/WebCore/platform/graphics/skia/PlatformContextSkia.cpp (121183 => 121184)


--- trunk/Source/WebCore/platform/graphics/skia/PlatformContextSkia.cpp	2012-06-25 21:57:14 UTC (rev 121183)
+++ trunk/Source/WebCore/platform/graphics/skia/PlatformContextSkia.cpp	2012-06-25 22:01:23 UTC (rev 121184)
@@ -122,7 +122,11 @@
     , m_lineJoin(SkPaint::kDefault_Join)
     , m_dash(0)
     , m_textDrawingMode(TextModeFill)
+#if USE(LOW_QUALITY_IMAGE_INTERPOLATION)
+    , m_interpolationQuality(InterpolationLow)
+#else
     , m_interpolationQuality(InterpolationHigh)
+#endif
 {
 }
 
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to