Title: [121190] trunk/Source
- Revision
- 121190
- Author
- [email protected]
- Date
- 2012-06-25 15:45:39 -0700 (Mon, 25 Jun 2012)
Log Message
Unreviewed, rolling out r121178.
http://trac.webkit.org/changeset/121178
https://bugs.webkit.org/show_bug.cgi?id=89784
New unit test added is failing on WebKit Linux (dbg)
Source/WebCore:
* platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::setBounds):
Source/WebKit/chromium:
* tests/LayerChromiumTest.cpp:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (121189 => 121190)
--- trunk/Source/WebCore/ChangeLog 2012-06-25 22:27:06 UTC (rev 121189)
+++ trunk/Source/WebCore/ChangeLog 2012-06-25 22:45:39 UTC (rev 121190)
@@ -1,5 +1,16 @@
2012-06-25 Alpha Lam <[email protected]>
+ Unreviewed, rolling out r121178.
+ http://trac.webkit.org/changeset/121178
+ https://bugs.webkit.org/show_bug.cgi?id=89784
+
+ New unit test added is failing on WebKit Linux (dbg)
+
+ * platform/graphics/chromium/LayerChromium.cpp:
+ (WebCore::LayerChromium::setBounds):
+
+2012-06-25 Alpha Lam <[email protected]>
+
Unreviewed, rolling out r121137.
http://trac.webkit.org/changeset/121137
Modified: trunk/Source/WebCore/platform/graphics/chromium/LayerChromium.cpp (121189 => 121190)
--- trunk/Source/WebCore/platform/graphics/chromium/LayerChromium.cpp 2012-06-25 22:27:06 UTC (rev 121189)
+++ trunk/Source/WebCore/platform/graphics/chromium/LayerChromium.cpp 2012-06-25 22:45:39 UTC (rev 121190)
@@ -228,7 +228,7 @@
if (bounds() == size)
return;
- bool firstResize = bounds().isEmpty() && !size.isEmpty();
+ bool firstResize = !bounds().width() && !bounds().height() && size.width() && size.height();
m_bounds = size;
Modified: trunk/Source/WebKit/chromium/ChangeLog (121189 => 121190)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-06-25 22:27:06 UTC (rev 121189)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-06-25 22:45:39 UTC (rev 121190)
@@ -1,5 +1,15 @@
2012-06-25 Alpha Lam <[email protected]>
+ Unreviewed, rolling out r121178.
+ http://trac.webkit.org/changeset/121178
+ https://bugs.webkit.org/show_bug.cgi?id=89784
+
+ New unit test added is failing on WebKit Linux (dbg)
+
+ * tests/LayerChromiumTest.cpp:
+
+2012-06-25 Alpha Lam <[email protected]>
+
Unreviewed, rolling out r121129.
http://trac.webkit.org/changeset/121129
https://bugs.webkit.org/show_bug.cgi?id=89542
Modified: trunk/Source/WebKit/chromium/tests/LayerChromiumTest.cpp (121189 => 121190)
--- trunk/Source/WebKit/chromium/tests/LayerChromiumTest.cpp 2012-06-25 22:27:06 UTC (rev 121189)
+++ trunk/Source/WebKit/chromium/tests/LayerChromiumTest.cpp 2012-06-25 22:45:39 UTC (rev 121190)
@@ -813,20 +813,4 @@
WebKit::WebCompositor::shutdown();
}
-class MockLayerChromium : public LayerChromium {
-public:
- bool needsDisplay() const { return m_needsDisplay; }
-};
-
-TEST(LayerChromiumTestWithoutFixture, setBoundsTriggersSetNeedsRedrawAfterGettingNonEmptyBounds)
-{
- MockLayerChromium layer;
- EXPECT_FALSE(layer.needsDisplay());
- layer.setBounds(IntSize(0, 10));
- EXPECT_FALSE(layer.needsDisplay());
- layer.setBounds(IntSize(10, 10));
- EXPECT_TRUE(layer.needsDisplay());
-}
-
-
} // namespace
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
