Title: [121192] trunk/Source/WebCore
- Revision
- 121192
- Author
- [email protected]
- Date
- 2012-06-25 16:15:44 -0700 (Mon, 25 Jun 2012)
Log Message
Fixing compilation failure in StyleResolver.cpp/CSSParser.cpp
https://bugs.webkit.org/show_bug.cgi?id=89892
Patch by Mike West <[email protected]> on 2012-06-25
Reviewed by Alexis Menard.
Adding CSSPropertyVariable to switch statements in CSSParser and
StyleResolver to fix compilation errors under ninja/clang. I've
added both as new cases to the switches, with FIXME comments for
implementation.
* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
* css/StyleResolver.cpp:
(WebCore::StyleResolver::collectMatchingRulesForList):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (121191 => 121192)
--- trunk/Source/WebCore/ChangeLog 2012-06-25 23:03:28 UTC (rev 121191)
+++ trunk/Source/WebCore/ChangeLog 2012-06-25 23:15:44 UTC (rev 121192)
@@ -1,3 +1,20 @@
+2012-06-25 Mike West <[email protected]>
+
+ Fixing compilation failure in StyleResolver.cpp/CSSParser.cpp
+ https://bugs.webkit.org/show_bug.cgi?id=89892
+
+ Reviewed by Alexis Menard.
+
+ Adding CSSPropertyVariable to switch statements in CSSParser and
+ StyleResolver to fix compilation errors under ninja/clang. I've
+ added both as new cases to the switches, with FIXME comments for
+ implementation.
+
+ * css/CSSParser.cpp:
+ (WebCore::CSSParser::parseValue):
+ * css/StyleResolver.cpp:
+ (WebCore::StyleResolver::collectMatchingRulesForList):
+
2012-06-25 Jay Civelli <[email protected]>
Fix for a memory leak with MHTMLArchives.
Modified: trunk/Source/WebCore/css/CSSParser.cpp (121191 => 121192)
--- trunk/Source/WebCore/css/CSSParser.cpp 2012-06-25 23:03:28 UTC (rev 121191)
+++ trunk/Source/WebCore/css/CSSParser.cpp 2012-06-25 23:15:44 UTC (rev 121192)
@@ -2663,6 +2663,11 @@
m_valueList->next();
break;
#endif
+#if ENABLE(CSS_VARIABLES)
+ case CSSPropertyVariable:
+ // FIXME: This should have an actual implementation.
+ return false;
+#endif
case CSSPropertyBorderBottomStyle:
case CSSPropertyBorderCollapse:
case CSSPropertyBorderLeftStyle:
Modified: trunk/Source/WebCore/css/StyleResolver.cpp (121191 => 121192)
--- trunk/Source/WebCore/css/StyleResolver.cpp 2012-06-25 23:03:28 UTC (rev 121191)
+++ trunk/Source/WebCore/css/StyleResolver.cpp 2012-06-25 23:15:44 UTC (rev 121192)
@@ -4160,7 +4160,11 @@
m_style->setGridItemRow(row);
return;
}
-
+#if ENABLE(CSS_VARIABLES)
+ case CSSPropertyVariable:
+ // FIXME: This should have an actual implementation.
+ return;
+#endif
// These properties are implemented in the StyleBuilder lookup table.
case CSSPropertyBackgroundAttachment:
case CSSPropertyBackgroundClip:
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
