Title: [121245] trunk/Source/WebKit/blackberry
- Revision
- 121245
- Author
- [email protected]
- Date
- 2012-06-26 03:04:40 -0700 (Tue, 26 Jun 2012)
Log Message
[BlackBerry] Use gesture SwipeDown to exit fullscreen for both video and plugin.
https://bugs.webkit.org/show_bug.cgi?id=89960
Reviewed by Antonio Gomes.
We used to use gesture swipedown to exit fullscreen for plugin, but not fullscreen
HTML5 video; When a swipe down happens, it applies this event to all the pluginviews
in a page, even though only the one in fullscreen mode will process this.
With this patch, the SwipeDown gesture will only apply to the fullscreen elemement,
which is either a plugin, or an Video element.
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPage::notifySwipeEvent):
Modified Paths
Diff
Modified: trunk/Source/WebKit/blackberry/Api/WebPage.cpp (121244 => 121245)
--- trunk/Source/WebKit/blackberry/Api/WebPage.cpp 2012-06-26 09:42:06 UTC (rev 121244)
+++ trunk/Source/WebKit/blackberry/Api/WebPage.cpp 2012-06-26 10:04:40 UTC (rev 121245)
@@ -5572,8 +5572,10 @@
void WebPage::notifySwipeEvent()
{
- FOR_EACH_PLUGINVIEW(d->m_pluginViews)
- (*it)->handleSwipeEvent();
+ if (d->m_fullScreenPluginView.get())
+ d->m_fullScreenPluginView->handleSwipeEvent();
+ else
+ notifyFullScreenVideoExited(true);
}
void WebPage::notifyScreenPowerStateChanged(bool powered)
Modified: trunk/Source/WebKit/blackberry/ChangeLog (121244 => 121245)
--- trunk/Source/WebKit/blackberry/ChangeLog 2012-06-26 09:42:06 UTC (rev 121244)
+++ trunk/Source/WebKit/blackberry/ChangeLog 2012-06-26 10:04:40 UTC (rev 121245)
@@ -1,3 +1,20 @@
+2012-06-26 Charles Wei <[email protected]>
+
+ [BlackBerry] Use gesture SwipeDown to exit fullscreen for both video and plugin.
+ https://bugs.webkit.org/show_bug.cgi?id=89960
+
+ Reviewed by Antonio Gomes.
+
+ We used to use gesture swipedown to exit fullscreen for plugin, but not fullscreen
+ HTML5 video; When a swipe down happens, it applies this event to all the pluginviews
+ in a page, even though only the one in fullscreen mode will process this.
+
+ With this patch, the SwipeDown gesture will only apply to the fullscreen elemement,
+ which is either a plugin, or an Video element.
+
+ * Api/WebPage.cpp:
+ (BlackBerry::WebKit::WebPage::notifySwipeEvent):
+
2012-06-25 Leo Yang <[email protected]>
[BlackBerry] Fill more data in device motion event
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
