Title: [121281] trunk/Source/WebKit/blackberry
Revision
121281
Author
[email protected]
Date
2012-06-26 12:52:14 -0700 (Tue, 26 Jun 2012)

Log Message

[BlackBerry] Add WebPage interface for Async spell check.
https://bugs.webkit.org/show_bug.cgi?id=89999

Reviewed by Rob Buis.

PR 124517.

Add interface for IMS async spell checking.

Reviewed Internally by Nima Ghanavatian.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPage::spellCheckingRequestProcessed):
(WebKit):
* Api/WebPage.h:
* Api/WebPageClient.h:
* WebKitSupport/InputHandler.cpp:
(WebKit):
(BlackBerry::WebKit::InputHandler::spellCheckingRequestProcessed):
* WebKitSupport/InputHandler.h:
(InputHandler):

Modified Paths

Diff

Modified: trunk/Source/WebKit/blackberry/Api/WebPage.cpp (121280 => 121281)


--- trunk/Source/WebKit/blackberry/Api/WebPage.cpp	2012-06-26 19:42:05 UTC (rev 121280)
+++ trunk/Source/WebKit/blackberry/Api/WebPage.cpp	2012-06-26 19:52:14 UTC (rev 121281)
@@ -4510,6 +4510,11 @@
     static_cast<EditorClientBlackBerry*>(d->m_page->editorClient())->enableSpellChecking(enabled);
 }
 
+void WebPage::spellCheckingRequestProcessed(int32_t id, spannable_string_t* spannableString)
+{
+    d->m_inputHandler->spellCheckingRequestProcessed(id, spannableString);
+}
+
 class DeferredTaskSelectionCancelled: public DeferredTask<&WebPagePrivate::m_wouldCancelSelection> {
 public:
     explicit DeferredTaskSelectionCancelled(WebPagePrivate* webPagePrivate)

Modified: trunk/Source/WebKit/blackberry/Api/WebPage.h (121280 => 121281)


--- trunk/Source/WebKit/blackberry/Api/WebPage.h	2012-06-26 19:42:05 UTC (rev 121280)
+++ trunk/Source/WebKit/blackberry/Api/WebPage.h	2012-06-26 19:52:14 UTC (rev 121281)
@@ -250,6 +250,7 @@
     int32_t commitText(spannable_string_t*, int32_t relativeCursorPosition);
 
     void setSpellCheckingEnabled(bool);
+    void spellCheckingRequestProcessed(int32_t id, spannable_string_t*);
 
     void setSelection(const Platform::IntPoint& startPoint, const Platform::IntPoint& endPoint);
     void setCaretPosition(const Platform::IntPoint&);

Modified: trunk/Source/WebKit/blackberry/Api/WebPageClient.h (121280 => 121281)


--- trunk/Source/WebKit/blackberry/Api/WebPageClient.h	2012-06-26 19:42:05 UTC (rev 121280)
+++ trunk/Source/WebKit/blackberry/Api/WebPageClient.h	2012-06-26 19:52:14 UTC (rev 121281)
@@ -144,6 +144,8 @@
     virtual void checkSpellingOfString(const unsigned short* text, int length, int& misspellingLocation, int& misspellingLength) = 0;
     virtual void requestSpellingSuggestionsForString(unsigned start, unsigned end) = 0;
 
+    virtual int32_t checkSpellingOfStringAsync(wchar_t* text, int length) = 0;
+
     virtual void notifySelectionDetailsChanged(const Platform::IntRect& start, const Platform::IntRect& end, const Platform::IntRectRegion&, bool overrideTouchHandling = false) = 0;
     virtual void cancelSelectionVisuals() = 0;
     virtual void notifySelectionHandlesReversed() = 0;

Modified: trunk/Source/WebKit/blackberry/ChangeLog (121280 => 121281)


--- trunk/Source/WebKit/blackberry/ChangeLog	2012-06-26 19:42:05 UTC (rev 121280)
+++ trunk/Source/WebKit/blackberry/ChangeLog	2012-06-26 19:52:14 UTC (rev 121281)
@@ -1,3 +1,27 @@
+2012-06-26  Mike Fenton  <[email protected]>
+
+        [BlackBerry] Add WebPage interface for Async spell check.
+        https://bugs.webkit.org/show_bug.cgi?id=89999
+
+        Reviewed by Rob Buis.
+
+        PR 124517.
+
+        Add interface for IMS async spell checking.
+
+        Reviewed Internally by Nima Ghanavatian.
+
+        * Api/WebPage.cpp:
+        (BlackBerry::WebKit::WebPage::spellCheckingRequestProcessed):
+        (WebKit):
+        * Api/WebPage.h:
+        * Api/WebPageClient.h:
+        * WebKitSupport/InputHandler.cpp:
+        (WebKit):
+        (BlackBerry::WebKit::InputHandler::spellCheckingRequestProcessed):
+        * WebKitSupport/InputHandler.h:
+        (InputHandler):
+
 2012-06-26  Jonathan Dong  <[email protected]>
 
         [BlackBerry] Limit session storage quota to 5MB by default

Modified: trunk/Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp (121280 => 121281)


--- trunk/Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp	2012-06-26 19:42:05 UTC (rev 121280)
+++ trunk/Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp	2012-06-26 19:52:14 UTC (rev 121281)
@@ -404,6 +404,14 @@
     sendLearnTextDetails(textInField);
 }
 
+
+void InputHandler::spellCheckingRequestProcessed(int32_t id, spannable_string_t* spannableString)
+{
+    UNUSED_PARAM(id);
+    UNUSED_PARAM(spannableString);
+    // TODO implement.
+}
+
 void InputHandler::setElementUnfocused(bool refocusOccuring)
 {
     if (isActiveTextEdit()) {

Modified: trunk/Source/WebKit/blackberry/WebKitSupport/InputHandler.h (121280 => 121281)


--- trunk/Source/WebKit/blackberry/WebKitSupport/InputHandler.h	2012-06-26 19:42:05 UTC (rev 121280)
+++ trunk/Source/WebKit/blackberry/WebKitSupport/InputHandler.h	2012-06-26 19:52:14 UTC (rev 121281)
@@ -121,6 +121,8 @@
     int32_t setComposingText(spannable_string_t*, int32_t relativeCursorPosition);
     int32_t commitText(spannable_string_t*, int32_t relativeCursorPosition);
 
+    void spellCheckingRequestProcessed(int32_t id, spannable_string_t*);
+
 private:
     enum PendingKeyboardStateChange { NoChange, Visible, NotVisible };
 
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to