Title: [121287] trunk/Tools
- Revision
- 121287
- Author
- [email protected]
- Date
- 2012-06-26 14:21:54 -0700 (Tue, 26 Jun 2012)
Log Message
Fix platform picker change handler in garden-o-matic
https://bugs.webkit.org/show_bug.cgi?id=90010
Reviewed by Simon Fraser.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
The old code never worked. This is hard to test because change handlers require
a user-initiated action and the code is changing the window's location, which would
navigate the test page.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/onebar.css:
Fix the CSS so it doesn't cause the tabstrip to be disconnected from the tabs on Linux
due to the large margin-bottom.
Modified Paths
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js (121286 => 121287)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js 2012-06-26 21:06:24 UTC (rev 121286)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js 2012-06-26 21:21:54 UTC (rev 121287)
@@ -112,8 +112,8 @@
});
platformSelect.addEventListener('change', function() {
- window.location.search = '?platform=' + platformSelect.selectedOptions[0]._platform;
- }, false);
+ window.location.search = '?platform=' + platformSelect.options[platformSelect.selectedIndex]._platform;
+ });
platformSelect.selectedIndex = currentPlatformIndex;
},
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/onebar.css (121286 => 121287)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/onebar.css 2012-06-26 21:06:24 UTC (rev 121286)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/onebar.css 2012-06-26 21:21:54 UTC (rev 121287)
@@ -43,7 +43,8 @@
#onebar #platform-picker {
float: right;
- margin: 8px;
+ margin-top: 8px;
+ margin-right: 8px;
font-size: larger;
}
Modified: trunk/Tools/ChangeLog (121286 => 121287)
--- trunk/Tools/ChangeLog 2012-06-26 21:06:24 UTC (rev 121286)
+++ trunk/Tools/ChangeLog 2012-06-26 21:21:54 UTC (rev 121287)
@@ -1,3 +1,19 @@
+2012-06-26 Ojan Vafai <[email protected]>
+
+ Fix platform picker change handler in garden-o-matic
+ https://bugs.webkit.org/show_bug.cgi?id=90010
+
+ Reviewed by Simon Fraser.
+
+ * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
+ The old code never worked. This is hard to test because change handlers require
+ a user-initiated action and the code is changing the window's location, which would
+ navigate the test page.
+
+ * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/onebar.css:
+ Fix the CSS so it doesn't cause the tabstrip to be disconnected from the tabs on Linux
+ due to the large margin-bottom.
+
2012-06-26 Thiago Marcos P. Santos <[email protected]>
webkitpy: Make webkit-patch patches-to-review useful
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
