Title: [121416] trunk/Source/WebKit2
Revision
121416
Author
[email protected]
Date
2012-06-28 00:46:54 -0700 (Thu, 28 Jun 2012)

Log Message

[Qt] KURL assert at fast/loader/opaque-base-url.html
https://bugs.webkit.org/show_bug.cgi?id=89468

Reviewed by Simon Hausmann.

Don't use the KURL(ParsedURLStringTag, const String&) constructor.
We cannot be sure that the url in encode was valid and even if it
was the message could have been corrupted.
* Shared/qt/WebCoreArgumentCodersQt.cpp:
(CoreIPC::::encode):
(CoreIPC::::decode):

Modified Paths

Diff

Modified: trunk/Source/WebKit2/ChangeLog (121415 => 121416)


--- trunk/Source/WebKit2/ChangeLog	2012-06-28 07:30:11 UTC (rev 121415)
+++ trunk/Source/WebKit2/ChangeLog	2012-06-28 07:46:54 UTC (rev 121416)
@@ -1,3 +1,17 @@
+2012-06-28  Balazs Kelemen  <[email protected]>
+
+        [Qt] KURL assert at fast/loader/opaque-base-url.html
+        https://bugs.webkit.org/show_bug.cgi?id=89468
+
+        Reviewed by Simon Hausmann.
+
+        Don't use the KURL(ParsedURLStringTag, const String&) constructor.
+        We cannot be sure that the url in encode was valid and even if it
+        was the message could have been corrupted.
+        * Shared/qt/WebCoreArgumentCodersQt.cpp:
+        (CoreIPC::::encode):
+        (CoreIPC::::decode):
+
 2012-06-27  Carlos Garcia Campos  <[email protected]>
 
         Unreviewed. Fix the build without TEXTURE_MAPPER_GL.

Modified: trunk/Source/WebKit2/Shared/qt/WebCoreArgumentCodersQt.cpp (121415 => 121416)


--- trunk/Source/WebKit2/Shared/qt/WebCoreArgumentCodersQt.cpp	2012-06-28 07:30:11 UTC (rev 121415)
+++ trunk/Source/WebKit2/Shared/qt/WebCoreArgumentCodersQt.cpp	2012-06-28 07:46:54 UTC (rev 121416)
@@ -44,13 +44,10 @@
     // FIXME: Add *more* coding implementation when we want to implement something that
     // depends on this like the policy client.
 
-    ResourceRequest request;
     String url;
     if (!decoder->decode(url))
         return false;
-    request.setURL(KURL(WebCore::ParsedURLString, url));
-
-    resourceRequest = request;
+    resourceRequest.setURL(KURL(KURL(), url));
     return true;
 }
 
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to