Title: [121468] trunk
Revision
121468
Author
[email protected]
Date
2012-06-28 14:02:30 -0700 (Thu, 28 Jun 2012)

Log Message

[EFL] Enable support for HTML5 datalist
https://bugs.webkit.org/show_bug.cgi?id=90157

Patch by Christophe Dumez <[email protected]> on 2012-06-28
Reviewed by Martin Robinson.

.:

Turn on DATALIST flag by default on EFL port to
support HTML5 datalist tag.

* Source/cmake/OptionsEfl.cmake:

Tools:

Turn on DATALIST flag by default on EFL port to
support HTML5 datalist tag.

* Scripts/webkitperl/FeatureList.pm:

LayoutTests:

* platform/efl/Skipped: Unskip fast/forms/datalist tests now that
the DATALIST flag is turned on by default on EFL port.
* platform/efl/fast/forms/datalist/input-list-expected.txt: Added.
We need platform-specific result because we don't support datalist
UI for any element yet. This should be progressively added later
on and the expected result will evolve.

Modified Paths

Added Paths

Diff

Modified: trunk/ChangeLog (121467 => 121468)


--- trunk/ChangeLog	2012-06-28 20:56:29 UTC (rev 121467)
+++ trunk/ChangeLog	2012-06-28 21:02:30 UTC (rev 121468)
@@ -1,3 +1,15 @@
+2012-06-28  Christophe Dumez  <[email protected]>
+
+        [EFL] Enable support for HTML5 datalist
+        https://bugs.webkit.org/show_bug.cgi?id=90157
+
+        Reviewed by Martin Robinson.
+
+        Turn on DATALIST flag by default on EFL port to
+        support HTML5 datalist tag.
+
+        * Source/cmake/OptionsEfl.cmake:
+
 2012-06-27  Zan Dobersek  <[email protected]>
 
         [Gtk] Add support for the Gamepad API

Modified: trunk/LayoutTests/ChangeLog (121467 => 121468)


--- trunk/LayoutTests/ChangeLog	2012-06-28 20:56:29 UTC (rev 121467)
+++ trunk/LayoutTests/ChangeLog	2012-06-28 21:02:30 UTC (rev 121468)
@@ -1,3 +1,17 @@
+2012-06-28  Christophe Dumez  <[email protected]>
+
+        [EFL] Enable support for HTML5 datalist
+        https://bugs.webkit.org/show_bug.cgi?id=90157
+
+        Reviewed by Martin Robinson.
+
+        * platform/efl/Skipped: Unskip fast/forms/datalist tests now that
+        the DATALIST flag is turned on by default on EFL port.
+        * platform/efl/fast/forms/datalist/input-list-expected.txt: Added.
+        We need platform-specific result because we don't support datalist
+        UI for any element yet. This should be progressively added later
+        on and the expected result will evolve.
+
 2012-06-28  Tony Chang  <[email protected]>
 
         Enable CSS grid layout LayoutTests on platform Mac

Modified: trunk/LayoutTests/platform/efl/Skipped (121467 => 121468)


--- trunk/LayoutTests/platform/efl/Skipped	2012-06-28 20:56:29 UTC (rev 121467)
+++ trunk/LayoutTests/platform/efl/Skipped	2012-06-28 21:02:30 UTC (rev 121468)
@@ -100,9 +100,6 @@
 # EFL's LayoutTestController does not implement setMediaType
 fast/media/print-restores-previous-mediatype.html
 
-# ENABLE(DATALIST) is disabled
-fast/forms/datalist
-
 # defined(ENABLE_INPUT_TYPE_COLOR) is disabled
 fast/forms/color/input-color-onchange-event.html
 

Added: trunk/LayoutTests/platform/efl/fast/forms/datalist/input-list-expected.txt (0 => 121468)


--- trunk/LayoutTests/platform/efl/fast/forms/datalist/input-list-expected.txt	                        (rev 0)
+++ trunk/LayoutTests/platform/efl/fast/forms/datalist/input-list-expected.txt	2012-06-28 21:02:30 UTC (rev 121468)
@@ -0,0 +1,36 @@
+Test for the list attribute.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS input.list is null
+PASS input.list is null
+PASS input.list is null
+FAIL datalist.className should be former. Threw exception TypeError: 'null' is not an object (evaluating 'datalist.className')
+FAIL document.getElementById("text").list should be [object HTMLDataListElement]. Was null.
+FAIL document.getElementById("search").list should be [object HTMLDataListElement]. Was null.
+FAIL document.getElementById("url").list should be [object HTMLDataListElement]. Was null.
+FAIL document.getElementById("telephone").list should be [object HTMLDataListElement]. Was null.
+FAIL document.getElementById("email").list should be [object HTMLDataListElement]. Was null.
+FAIL document.getElementById("datetime").list should be [object HTMLDataListElement]. Was null.
+FAIL document.getElementById("date").list should be [object HTMLDataListElement]. Was null.
+FAIL document.getElementById("month").list should be [object HTMLDataListElement]. Was null.
+FAIL document.getElementById("week").list should be [object HTMLDataListElement]. Was null.
+FAIL document.getElementById("time").list should be [object HTMLDataListElement]. Was null.
+FAIL document.getElementById("datetime-local").list should be [object HTMLDataListElement]. Was null.
+FAIL document.getElementById("number").list should be [object HTMLDataListElement]. Was null.
+FAIL document.getElementById("range").list should be [object HTMLDataListElement]. Was null.
+FAIL document.getElementById("color").list should be [object HTMLDataListElement]. Was null.
+PASS document.getElementById("hidden").list is null
+PASS document.getElementById("password").list is null
+PASS document.getElementById("checkbox").list is null
+PASS document.getElementById("radio").list is null
+PASS document.getElementById("file").list is null
+PASS document.getElementById("submit").list is null
+PASS document.getElementById("image").list is null
+PASS document.getElementById("reset").list is null
+PASS document.getElementById("button").list is null
+PASS successfullyParsed is true
+
+TEST COMPLETE
+

Modified: trunk/Source/cmake/OptionsEfl.cmake (121467 => 121468)


--- trunk/Source/cmake/OptionsEfl.cmake	2012-06-28 20:56:29 UTC (rev 121467)
+++ trunk/Source/cmake/OptionsEfl.cmake	2012-06-28 21:02:30 UTC (rev 121468)
@@ -70,6 +70,7 @@
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_BATTERY_STATUS ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_BLOB ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS_IMAGE_SET ON)
+WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_DATALIST ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_DRAG_SUPPORT ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_FAST_MOBILE_SCROLLING ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_FILTERS ON)

Modified: trunk/Tools/ChangeLog (121467 => 121468)


--- trunk/Tools/ChangeLog	2012-06-28 20:56:29 UTC (rev 121467)
+++ trunk/Tools/ChangeLog	2012-06-28 21:02:30 UTC (rev 121468)
@@ -1,3 +1,15 @@
+2012-06-28  Christophe Dumez  <[email protected]>
+
+        [EFL] Enable support for HTML5 datalist
+        https://bugs.webkit.org/show_bug.cgi?id=90157
+
+        Reviewed by Martin Robinson.
+
+        Turn on DATALIST flag by default on EFL port to
+        support HTML5 datalist tag.
+
+        * Scripts/webkitperl/FeatureList.pm:
+
 2012-06-28  Tony Chang  <[email protected]>
 
         Enable CSS grid layout LayoutTests on platform Mac

Modified: trunk/Tools/Scripts/webkitperl/FeatureList.pm (121467 => 121468)


--- trunk/Tools/Scripts/webkitperl/FeatureList.pm	2012-06-28 20:56:29 UTC (rev 121467)
+++ trunk/Tools/Scripts/webkitperl/FeatureList.pm	2012-06-28 21:02:30 UTC (rev 121468)
@@ -181,7 +181,7 @@
       define => "ENABLE_CUSTOM_SCHEME_HANDLER", default => 0, value => \$customSchemeHandlerSupport },
 
     { option => "datalist", desc => "Toggle Datalist support",
-      define => "ENABLE_DATALIST", default => 0, value => \$datalistSupport },
+      define => "ENABLE_DATALIST", default => isEfl(), value => \$datalistSupport },
 
     { option => "data-transfer-items", desc => "Toggle Data Transfer Items support",
       define => "ENABLE_DATA_TRANSFER_ITEMS", default => 0, value => \$dataTransferItemsSupport },
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to