Title: [121510] trunk/Source/WebCore
- Revision
- 121510
- Author
- [email protected]
- Date
- 2012-06-28 19:37:43 -0700 (Thu, 28 Jun 2012)
Log Message
[Chromium] CTFontCopyTable of MacOSX10.5 SDK doesn't work for layout tables
https://bugs.webkit.org/show_bug.cgi?id=90235
Reviewed by Kent Tamura.
Use CGFontCopyTableForTag instead.
No new tests. css3/font-feature-settings-rendering.html should pass. I'll rebase expectations once bots get the result.
* platform/graphics/harfbuzz/ng/HarfBuzzFaceCoreText.cpp:
(WebCore::harfbuzzCoreTextGetTable):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (121509 => 121510)
--- trunk/Source/WebCore/ChangeLog 2012-06-29 02:37:04 UTC (rev 121509)
+++ trunk/Source/WebCore/ChangeLog 2012-06-29 02:37:43 UTC (rev 121510)
@@ -1,3 +1,17 @@
+2012-06-28 Kenichi Ishibashi <[email protected]>
+
+ [Chromium] CTFontCopyTable of MacOSX10.5 SDK doesn't work for layout tables
+ https://bugs.webkit.org/show_bug.cgi?id=90235
+
+ Reviewed by Kent Tamura.
+
+ Use CGFontCopyTableForTag instead.
+
+ No new tests. css3/font-feature-settings-rendering.html should pass. I'll rebase expectations once bots get the result.
+
+ * platform/graphics/harfbuzz/ng/HarfBuzzFaceCoreText.cpp:
+ (WebCore::harfbuzzCoreTextGetTable):
+
2012-06-28 Philip Rogers <[email protected]>
Add preventative assert in SVGTRefElement
Modified: trunk/Source/WebCore/platform/graphics/harfbuzz/ng/HarfBuzzFaceCoreText.cpp (121509 => 121510)
--- trunk/Source/WebCore/platform/graphics/harfbuzz/ng/HarfBuzzFaceCoreText.cpp 2012-06-29 02:37:04 UTC (rev 121509)
+++ trunk/Source/WebCore/platform/graphics/harfbuzz/ng/HarfBuzzFaceCoreText.cpp 2012-06-29 02:37:43 UTC (rev 121510)
@@ -109,8 +109,10 @@
static hb_blob_t* harfbuzzCoreTextGetTable(hb_face_t* face, hb_tag_t tag, void* userData)
{
FontPlatformData* platformData = reinterpret_cast<FontPlatformData*>(userData);
- CTFontRef ctFont = platformData->ctFont();
- CFDataRef cfData = CTFontCopyTable(ctFont, tag, kCTFontTableOptionNoOptions);
+ // It seems that CTFontCopyTable of MacOSX10.5 sdk doesn't work for
+ // OpenType layout tables(GDEF, GSUB, GPOS). Use CGFontCopyTableForTag instead.
+ CGFontRef cgFont = platformData->cgFont();
+ CFDataRef cfData = CGFontCopyTableForTag(cgFont, tag);
if (!cfData)
return 0;
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
