Title: [121607] trunk/Source/_javascript_Core
- Revision
- 121607
- Author
- [email protected]
- Date
- 2012-06-29 18:14:09 -0700 (Fri, 29 Jun 2012)
Log Message
Remove warning about protected values when the Heap is being destroyed
https://bugs.webkit.org/show_bug.cgi?id=90302
Reviewed by Geoffrey Garen.
Having to do book-keeping about whether values allocated from a certain
VM are or are not protected makes the JSC API much more difficult to use
correctly. Clients should be able to throw an entire VM away and not have
to worry about unprotecting all of the values that they protected earlier.
* heap/Heap.cpp:
(JSC::Heap::lastChanceToFinalize):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (121606 => 121607)
--- trunk/Source/_javascript_Core/ChangeLog 2012-06-30 00:58:24 UTC (rev 121606)
+++ trunk/Source/_javascript_Core/ChangeLog 2012-06-30 01:14:09 UTC (rev 121607)
@@ -1,3 +1,18 @@
+2012-06-29 Mark Hahnenberg <[email protected]>
+
+ Remove warning about protected values when the Heap is being destroyed
+ https://bugs.webkit.org/show_bug.cgi?id=90302
+
+ Reviewed by Geoffrey Garen.
+
+ Having to do book-keeping about whether values allocated from a certain
+ VM are or are not protected makes the JSC API much more difficult to use
+ correctly. Clients should be able to throw an entire VM away and not have
+ to worry about unprotecting all of the values that they protected earlier.
+
+ * heap/Heap.cpp:
+ (JSC::Heap::lastChanceToFinalize):
+
2012-06-29 Filip Pizlo <[email protected]>
JSObject wastes too much memory on unused property slots
Modified: trunk/Source/_javascript_Core/heap/Heap.cpp (121606 => 121607)
--- trunk/Source/_javascript_Core/heap/Heap.cpp 2012-06-30 00:58:24 UTC (rev 121606)
+++ trunk/Source/_javascript_Core/heap/Heap.cpp 2012-06-30 01:14:09 UTC (rev 121607)
@@ -269,10 +269,6 @@
ASSERT(!m_globalData->dynamicGlobalObject);
ASSERT(m_operationInProgress == NoOperation);
- // FIXME: Make this a release-mode crash once we're sure no one's doing this.
- if (size_t size = m_protectedValues.size())
- WTFLogAlways("ERROR: _javascript_Core heap deallocated while %ld values were still protected", static_cast<unsigned long>(size));
-
m_objectSpace.lastChanceToFinalize();
#if ENABLE(SIMPLE_HEAP_PROFILING)
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
