Title: [121635] trunk
- Revision
- 121635
- Author
- [email protected]
- Date
- 2012-07-01 14:01:34 -0700 (Sun, 01 Jul 2012)
Log Message
[EFL] [GTK] [QT] fast/viewport/viewport-91.html is failing after r121555
https://bugs.webkit.org/show_bug.cgi?id=90286
Patch by Konrad Piascik <[email protected]> on 2012-07-01
Reviewed by Daniel Bates.
Source/WebCore:
Since the deprecatedTargetDPI was an int and the deviceDPI was also an int the result
was truncated. Changed deprecatedTargetDPI to a float value. Viewport test 91 now passes.
* dom/ViewportArguments.h:
(ViewportArguments):
LayoutTests:
Unskip now passing tests.
* platform/efl/TestExpectations:
* platform/gtk/TestExpectations:
* platform/qt/TestExpectations:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (121634 => 121635)
--- trunk/LayoutTests/ChangeLog 2012-07-01 17:09:25 UTC (rev 121634)
+++ trunk/LayoutTests/ChangeLog 2012-07-01 21:01:34 UTC (rev 121635)
@@ -1,3 +1,16 @@
+2012-07-01 Konrad Piascik <[email protected]>
+
+ [EFL] [GTK] [QT] fast/viewport/viewport-91.html is failing after r121555
+ https://bugs.webkit.org/show_bug.cgi?id=90286
+
+ Reviewed by Daniel Bates.
+
+ Unskip now passing tests.
+
+ * platform/efl/TestExpectations:
+ * platform/gtk/TestExpectations:
+ * platform/qt/TestExpectations:
+
2012-06-30 Emil A Eklund <[email protected]>
Unreviewed chromium rebaseline for svg/zoom.
Modified: trunk/LayoutTests/platform/efl/TestExpectations (121634 => 121635)
--- trunk/LayoutTests/platform/efl/TestExpectations 2012-07-01 17:09:25 UTC (rev 121634)
+++ trunk/LayoutTests/platform/efl/TestExpectations 2012-07-01 21:01:34 UTC (rev 121635)
@@ -715,7 +715,4 @@
BUGWK90007 : http/tests/security/mixedContent/insecure-audio-video-in-main-frame.html = TEXT
-// Failing after r121555
-BUGWK90286 : fast/viewport/viewport-91.html = TEXT
-
BUGWK90334 : css3/flexbox/anonymous-block.html = IMAGE
Modified: trunk/LayoutTests/platform/gtk/TestExpectations (121634 => 121635)
--- trunk/LayoutTests/platform/gtk/TestExpectations 2012-07-01 17:09:25 UTC (rev 121634)
+++ trunk/LayoutTests/platform/gtk/TestExpectations 2012-07-01 21:01:34 UTC (rev 121635)
@@ -1239,9 +1239,6 @@
BUGWK90007 : http/tests/security/mixedContent/insecure-audio-video-in-main-frame.html = TEXT
-// Failing after r121555
-BUGWK90286 : fast/viewport/viewport-91.html = TEXT
-
BUGWK90334 : css3/flexbox/anonymous-block.html = IMAGE
//////////////////////////////////////////////////////////////////////////////////////////
Modified: trunk/LayoutTests/platform/qt/TestExpectations (121634 => 121635)
--- trunk/LayoutTests/platform/qt/TestExpectations 2012-07-01 17:09:25 UTC (rev 121634)
+++ trunk/LayoutTests/platform/qt/TestExpectations 2012-07-01 21:01:34 UTC (rev 121635)
@@ -101,6 +101,3 @@
BUGWK88794 SKIP : webaudio/codec-tests = PASS
BUGWK90007 : http/tests/security/mixedContent/insecure-audio-video-in-main-frame.html = TEXT
-
-// Failing after r121555
-BUGWK90286 : fast/viewport/viewport-91.html = TEXT
Modified: trunk/Source/WebCore/ChangeLog (121634 => 121635)
--- trunk/Source/WebCore/ChangeLog 2012-07-01 17:09:25 UTC (rev 121634)
+++ trunk/Source/WebCore/ChangeLog 2012-07-01 21:01:34 UTC (rev 121635)
@@ -1,3 +1,16 @@
+2012-07-01 Konrad Piascik <[email protected]>
+
+ [EFL] [GTK] [QT] fast/viewport/viewport-91.html is failing after r121555
+ https://bugs.webkit.org/show_bug.cgi?id=90286
+
+ Reviewed by Daniel Bates.
+
+ Since the deprecatedTargetDPI was an int and the deviceDPI was also an int the result
+ was truncated. Changed deprecatedTargetDPI to a float value. Viewport test 91 now passes.
+
+ * dom/ViewportArguments.h:
+ (ViewportArguments):
+
2012-06-30 Ian Vollick <[email protected]>
[chromium] CanvasLayerTextureUpdater needs to convert opaque rects back to content space.
Modified: trunk/Source/WebCore/dom/ViewportArguments.h (121634 => 121635)
--- trunk/Source/WebCore/dom/ViewportArguments.h 2012-07-01 17:09:25 UTC (rev 121634)
+++ trunk/Source/WebCore/dom/ViewportArguments.h 2012-07-01 21:01:34 UTC (rev 121635)
@@ -110,7 +110,7 @@
}
// FIXME: We're going to keep this constant around until all embedders
// refactor their code to no longer need it.
- static const int deprecatedTargetDPI = 160;
+ static const float deprecatedTargetDPI = 160;
};
ViewportAttributes computeViewportAttributes(ViewportArguments args, int desktopWidth, int deviceWidth, int deviceHeight, float devicePixelRatio, IntSize visibleViewport);
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
