Diff
Modified: trunk/LayoutTests/ChangeLog (121660 => 121661)
--- trunk/LayoutTests/ChangeLog 2012-07-02 07:10:21 UTC (rev 121660)
+++ trunk/LayoutTests/ChangeLog 2012-07-02 07:35:28 UTC (rev 121661)
@@ -1,3 +1,16 @@
+2012-07-02 Konrad Piascik <[email protected]>
+
+ [EFL] [GTK] [QT] fast/viewport/viewport-91.html is failing after r121555
+ https://bugs.webkit.org/show_bug.cgi?id=90286
+
+ Reviewed by Daniel Bates.
+
+ Unskip now passing tests.
+
+ * platform/efl/TestExpectations:
+ * platform/gtk/TestExpectations:
+ * platform/qt/TestExpectations:
+
2012-07-02 Kristóf Kosztyó <[email protected]>
[Qt] Unreviewed gardening, skip new failing test.
Modified: trunk/LayoutTests/platform/efl/TestExpectations (121660 => 121661)
--- trunk/LayoutTests/platform/efl/TestExpectations 2012-07-02 07:10:21 UTC (rev 121660)
+++ trunk/LayoutTests/platform/efl/TestExpectations 2012-07-02 07:35:28 UTC (rev 121661)
@@ -718,7 +718,4 @@
BUGWK90007 : http/tests/security/mixedContent/insecure-audio-video-in-main-frame.html = TEXT
-// Failing after r121555
-BUGWK90286 : fast/viewport/viewport-91.html = TEXT
-
BUGWK90334 : css3/flexbox/anonymous-block.html = IMAGE
Modified: trunk/LayoutTests/platform/gtk/TestExpectations (121660 => 121661)
--- trunk/LayoutTests/platform/gtk/TestExpectations 2012-07-02 07:10:21 UTC (rev 121660)
+++ trunk/LayoutTests/platform/gtk/TestExpectations 2012-07-02 07:35:28 UTC (rev 121661)
@@ -1239,9 +1239,6 @@
BUGWK90007 : http/tests/security/mixedContent/insecure-audio-video-in-main-frame.html = TEXT
-// Failing after r121555
-BUGWK90286 : fast/viewport/viewport-91.html = TEXT
-
BUGWK90334 : css3/flexbox/anonymous-block.html = IMAGE
//////////////////////////////////////////////////////////////////////////////////////////
Modified: trunk/LayoutTests/platform/qt/TestExpectations (121660 => 121661)
--- trunk/LayoutTests/platform/qt/TestExpectations 2012-07-02 07:10:21 UTC (rev 121660)
+++ trunk/LayoutTests/platform/qt/TestExpectations 2012-07-02 07:35:28 UTC (rev 121661)
@@ -101,6 +101,3 @@
BUGWK88794 SKIP : webaudio/codec-tests = PASS
BUGWK90007 : http/tests/security/mixedContent/insecure-audio-video-in-main-frame.html = TEXT
-
-// Failing after r121555
-BUGWK90286 : fast/viewport/viewport-91.html = TEXT
Modified: trunk/Source/WebCore/ChangeLog (121660 => 121661)
--- trunk/Source/WebCore/ChangeLog 2012-07-02 07:10:21 UTC (rev 121660)
+++ trunk/Source/WebCore/ChangeLog 2012-07-02 07:35:28 UTC (rev 121661)
@@ -1,3 +1,16 @@
+2012-07-02 Konrad Piascik <[email protected]>
+
+ [EFL] [GTK] [QT] fast/viewport/viewport-91.html is failing after r121555
+ https://bugs.webkit.org/show_bug.cgi?id=90286
+
+ Reviewed by Daniel Bates.
+
+ Since the deprecatedTargetDPI was an int and the deviceDPI was also an int the result
+ was truncated. Changed deprecatedTargetDPI to a float value. Viewport test 91 now passes.
+
+ * dom/ViewportArguments.h:
+ (ViewportArguments):
+
2012-06-28 Yury Semikhatsky <[email protected]>
Web Inspector: add v8 bindings memory info to the native memory graph
Modified: trunk/Source/WebCore/dom/ViewportArguments.cpp (121660 => 121661)
--- trunk/Source/WebCore/dom/ViewportArguments.cpp 2012-07-02 07:10:21 UTC (rev 121660)
+++ trunk/Source/WebCore/dom/ViewportArguments.cpp 2012-07-02 07:35:28 UTC (rev 121661)
@@ -41,6 +41,8 @@
namespace WebCore {
+const float ViewportArguments::deprecatedTargetDPI = 160;
+
ViewportAttributes computeViewportAttributes(ViewportArguments args, int desktopWidth, int deviceWidth, int deviceHeight, float devicePixelRatio, IntSize visibleViewport)
{
ViewportAttributes result;
Modified: trunk/Source/WebCore/dom/ViewportArguments.h (121660 => 121661)
--- trunk/Source/WebCore/dom/ViewportArguments.h 2012-07-02 07:10:21 UTC (rev 121660)
+++ trunk/Source/WebCore/dom/ViewportArguments.h 2012-07-02 07:35:28 UTC (rev 121661)
@@ -108,9 +108,10 @@
{
return !(*this == other);
}
+
// FIXME: We're going to keep this constant around until all embedders
// refactor their code to no longer need it.
- static const int deprecatedTargetDPI = 160;
+ static const float deprecatedTargetDPI;
};
ViewportAttributes computeViewportAttributes(ViewportArguments args, int desktopWidth, int deviceWidth, int deviceHeight, float devicePixelRatio, IntSize visibleViewport);
