Title: [121701] trunk/Tools
Revision
121701
Author
[email protected]
Date
2012-07-02 12:45:32 -0700 (Mon, 02 Jul 2012)

Log Message

REGRESSION(r121497): It switched off and broke many unittests
https://bugs.webkit.org/show_bug.cgi?id=90371

Patch by Csaba Osztrogonác <[email protected]> on 2012-07-02
Reviewed by Adam Barth.

* Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
(ChromiumMacPortTest): Use snowleopard as os_version instead of leopard, because it isn't supported anymore.
* Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py:
(ChromiumPortTestCase.test_all_test_configurations): Remove leopard testcases, because it isn't supported anymore.
* Scripts/webkitpy/layout_tests/port/port_testcase.py:
(PortTestCase): Inherit class PortTestCase from unittest.TestCase instead of object.

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (121700 => 121701)


--- trunk/Tools/ChangeLog	2012-07-02 19:25:59 UTC (rev 121700)
+++ trunk/Tools/ChangeLog	2012-07-02 19:45:32 UTC (rev 121701)
@@ -1,3 +1,17 @@
+2012-07-02  Csaba Osztrogonác  <[email protected]>
+
+        REGRESSION(r121497): It switched off and broke many unittests
+        https://bugs.webkit.org/show_bug.cgi?id=90371
+
+        Reviewed by Adam Barth.
+
+        * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
+        (ChromiumMacPortTest): Use snowleopard as os_version instead of leopard, because it isn't supported anymore.
+        * Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py:
+        (ChromiumPortTestCase.test_all_test_configurations): Remove leopard testcases, because it isn't supported anymore.
+        * Scripts/webkitpy/layout_tests/port/port_testcase.py:
+        (PortTestCase): Inherit class PortTestCase from unittest.TestCase instead of object.
+
 2012-07-02  Ojan Vafai  <[email protected]>
 
         Move rebaseline-all command from the gardening-server down into webkit-patch

Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py (121700 => 121701)


--- trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py	2012-07-02 19:25:59 UTC (rev 121700)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py	2012-07-02 19:45:32 UTC (rev 121701)
@@ -35,7 +35,7 @@
 
 class ChromiumMacPortTest(chromium_port_testcase.ChromiumPortTestCase):
     os_name = 'mac'
-    os_version = 'leopard'
+    os_version = 'snowleopard'
     port_name = 'chromium-mac'
     port_maker = chromium_mac.ChromiumMacPort
 

Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py (121700 => 121701)


--- trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py	2012-07-02 19:25:59 UTC (rev 121700)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py	2012-07-02 19:45:32 UTC (rev 121701)
@@ -64,8 +64,6 @@
         self.assertEquals(set(port.all_test_configurations()), set([
             TestConfiguration('icecreamsandwich', 'x86', 'debug'),
             TestConfiguration('icecreamsandwich', 'x86', 'release'),
-            TestConfiguration('leopard', 'x86', 'debug'),
-            TestConfiguration('leopard', 'x86', 'release'),
             TestConfiguration('snowleopard', 'x86', 'debug'),
             TestConfiguration('snowleopard', 'x86', 'release'),
             TestConfiguration('lion', 'x86', 'debug'),

Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py (121700 => 121701)


--- trunk/Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py	2012-07-02 19:25:59 UTC (rev 121700)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py	2012-07-02 19:45:32 UTC (rev 121701)
@@ -44,7 +44,7 @@
 from webkitpy.tool.mocktool import MockOptions
 
 
-class PortTestCase(object):
+class PortTestCase(unittest.TestCase):
     """Tests that all Port implementations must pass."""
     HTTP_PORTS = (8000, 8080, 8443)
     WEBSOCKET_PORTS = (8880,)
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to