Title: [121706] trunk/Tools
- Revision
- 121706
- Author
- [email protected]
- Date
- 2012-07-02 14:27:29 -0700 (Mon, 02 Jul 2012)
Log Message
Delete unused rebaseline method in gardeningserver.py
https://bugs.webkit.org/show_bug.cgi?id=90396
Reviewed by Eric Seidel.
As best I can tell, the only usage was in this unittest.
* Scripts/webkitpy/tool/servers/gardeningserver.py:
(GardeningHTTPRequestHandler.updateexpectations):
* Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
(GardeningServerTest.test_rebaseline_new_port):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (121705 => 121706)
--- trunk/Tools/ChangeLog 2012-07-02 20:48:00 UTC (rev 121705)
+++ trunk/Tools/ChangeLog 2012-07-02 21:27:29 UTC (rev 121706)
@@ -1,3 +1,17 @@
+2012-07-02 Ojan Vafai <[email protected]>
+
+ Delete unused rebaseline method in gardeningserver.py
+ https://bugs.webkit.org/show_bug.cgi?id=90396
+
+ Reviewed by Eric Seidel.
+
+ As best I can tell, the only usage was in this unittest.
+
+ * Scripts/webkitpy/tool/servers/gardeningserver.py:
+ (GardeningHTTPRequestHandler.updateexpectations):
+ * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
+ (GardeningServerTest.test_rebaseline_new_port):
+
2012-07-02 Csaba Osztrogonác <[email protected]>
REGRESSION(r121497): It switched off and broke many unittests
Modified: trunk/Tools/Scripts/webkitpy/tool/servers/gardeningserver.py (121705 => 121706)
--- trunk/Tools/Scripts/webkitpy/tool/servers/gardeningserver.py 2012-07-02 20:48:00 UTC (rev 121705)
+++ trunk/Tools/Scripts/webkitpy/tool/servers/gardeningserver.py 2012-07-02 21:27:29 UTC (rev 121706)
@@ -140,22 +140,6 @@
self._expectations_updater().update_expectations(self._read_entity_body_as_json())
self._serve_text('success')
- # FIXME: Is this dead code?
- def rebaseline(self):
- builder = self.query['builder'][0]
- command = [ 'rebaseline-test' ]
-
- if 'suffixes' in self.query:
- command.append('--suffixes')
- command.append(self.query['suffixes'][0])
-
- command.append(builder)
- command.append(self.query['test'][0])
-
- command.extend(builders.fallback_port_names_for_new_port(builder))
- self._run_webkit_patch(command)
- self._serve_text('success')
-
def rebaselineall(self):
command = ['rebaseline-all']
self.server.tool.executive.run_command([self.server.tool.path()] + command, input=self.read_entity_body(), cwd=self.server.tool.scm().checkout_root)
Modified: trunk/Tools/Scripts/webkitpy/tool/servers/gardeningserver_unittest.py (121705 => 121706)
--- trunk/Tools/Scripts/webkitpy/tool/servers/gardeningserver_unittest.py 2012-07-02 20:48:00 UTC (rev 121705)
+++ trunk/Tools/Scripts/webkitpy/tool/servers/gardeningserver_unittest.py 2012-07-02 21:27:29 UTC (rev 121706)
@@ -200,9 +200,9 @@
def test_rebaseline_new_port(self):
builders._exact_matches = {"MOCK builder": {"port_name": "test-mac-leopard", "specifiers": set(["mock-specifier"]), "move_overwritten_baselines_to": ["mock-port-fallback", "mock-port-fallback2"]}}
- expected_stderr = "MOCK run_command: ['echo', 'rebaseline-test', '--suffixes', 'txt,png', 'MOCK builder', 'user-scripts/another-test.html', 'mock-port-fallback', 'mock-port-fallback2'], cwd=/mock-checkout\n"
+ expected_stderr = 'MOCK run_command: [\'echo\', \'rebaseline-all\'], cwd=/mock-checkout, input={"user-scripts/another-test.html":{"MOCK builder": ["txt","png"]}}\n'
expected_stdout = "== Begin Response ==\nsuccess\n== End Response ==\n"
- self._post_to_path("/rebaseline?builder=MOCK+builder&test=user-scripts/another-test.html&suffixes=txt,png", expected_stderr=expected_stderr, expected_stdout=expected_stdout)
+ self._post_to_path("/rebaselineall", body='{"user-scripts/another-test.html":{"MOCK builder": ["txt","png"]}}', expected_stderr=expected_stderr, expected_stdout=expected_stdout)
def test_updateexpectations(self):
expected_stderr = ""
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
