[webkit-changes] [121722] trunk

Mon, 02 Jul 2012 19:23:00 -0700

Title: [121722] trunk
Revision
121722
Author
[email protected]
Date
2012-07-02 19:22:46 -0700 (Mon, 02 Jul 2012)

Log Message

Position replaced elements on pixel bounds
https://bugs.webkit.org/show_bug.cgi?id=90354

Reviewed by Eric Seidel.

To avoid sizing and repaint issues we should layout replaced elements on
pixel bounds. We already ensure that replaced elements are sized in full
pixels and that they are painted on pixel bounds. By also ensuring that
they are placed on pixel bounds we avoid pixel having the size be
expanded by pixel snapping and repainting/invalidation rect issues when
scrolling.

Test: fast/repaint/repaint-during-scroll-with-zoom.html

* rendering/RenderBox.cpp:
(WebCore::RenderBox::computePositionedLogicalWidthReplaced):
(WebCore::RenderBox::computePositionedLogicalHeightReplaced):

Modified Paths

Added Paths

Diff

Added: trunk/LayoutTests/fast/repaint/repaint-during-scroll-with-zoom.html (0 => 121722)


--- trunk/LayoutTests/fast/repaint/repaint-during-scroll-with-zoom.html	                        (rev 0)
+++ trunk/LayoutTests/fast/repaint/repaint-during-scroll-with-zoom.html	2012-07-03 02:22:46 UTC (rev 121722)
@@ -0,0 +1,51 @@
+<!DOCTYPE html>
+<html>
+<head>
+    <style>
+        body {
+            margin: 0;
+            background: silver;
+            zoom: 1.25;
+        }
+        iframe {
+            position: absolute;
+            top: 50px;
+            width: 200px;
+            height: 200px;
+            overflow: auto;
+        }
+    </style>
+</head>
+<body>
+    <iframe src=""
+    <script>
+        var frame = window.frames[0];
+        var doc = frame.document;
+        doc.body.style.backgroundColor = 'white';
+        doc.body.style.width = '2000px';
+        doc.body.style.height = '2000px';
+        doc.body.appendChild(doc.createTextNode('scroll me'));
+        frame.scrollBy(100, 100);
+    </script>
+    <script>
+        function testScrollRepaint()
+        {
+            if (window.layoutTestController) {
+                layoutTestController.waitUntilDone();
+                frame._onscroll_ = function() {
+                    if (window.layoutTestController)
+                        layoutTestController.notifyDone();
+                };
+            }
+            frame.scrollBy(-90, -90);
+        }
+
+        if (window.layoutTestController) {
+            layoutTestController.display();
+            testScrollRepaint();
+        } else {
+            setTimeout(testScrollRepaint, 100);
+        }
+    </script>
+</body>
+</html>

Added: trunk/LayoutTests/platform/chromium-linux/fast/repaint/repaint-during-scroll-with-zoom-expected.png (0 => 121722)


--- trunk/LayoutTests/platform/chromium-linux/fast/repaint/repaint-during-scroll-with-zoom-expected.png	                        (rev 0)
+++ trunk/LayoutTests/platform/chromium-linux/fast/repaint/repaint-during-scroll-with-zoom-expected.png	2012-07-03 02:22:46 UTC (rev 121722)
@@ -0,0 +1,9 @@
+\x89PNG
+
+
+IHDR X')tEXtchecksum486fb4a9cce591081e6fbe328386edd8<PI\xE6\x86IDATx\x9C\xED\xDDMh\U\xC7\xE1\xD0-\xC8HM\xA2](\xC5*XJ\xDCWA\x86.\xEC\xA6 \x88uѕ\xA1*.\x8A\xCBt\xA1\x88 \xA8EEa\xB4\x85\xA2\x9B@\x95KV\x82fPiA\xA2\xF5+.\xA4Š]4\xF3.fc?\xF3&\xFF\xCE$\x93\xE7Y\xB4g\xA6\xB7\x93\x93r\xE1\xFEr\xCF\xED\xBD\x93\x93\x93\x80\x9C\x9Bz=\x80~#\xB0\xC2@\x98\xC0Xa L`\x84	,\x800\x81&\xB0\xC2@\x98\xC0Xa L`\x84	,\x800\x81&\xB0\xC2@\x98\xC0Xa L`\x84	,\x800\x81&\xB0\xC2@\x98\xC0Xa L`\x84	,\x800\x81&\xB0\xC2@\x98\xC0Xa L`\x84	,\x800\x81&\xB0\xC2@\x98\xC0Xa L`\x84	,\x800\x81&\xB0\xC2@\x98\xC0Xa L`\x84	,\x800\x81&\xB0\xC2@\x98\xC0Xa l\xF0\xFC\xF9\xF3\xBD\x9E\xF4\xC0\xF0\xF0p\xAF\xA7@\xDFr\x8B\xCDhll\xAC\xD7S\xA0\x9F
+\xB6~\x9B\x9B\x9B\xEB\xED<`\xED\x8D\xC6\xC2\xC2\xC2\xD5\xFE\xB4R\xA9T\xAB\xD5Rʁ\xBA8)6\xA3\xC1^O2\xEA\xF5z\xADV[\xFB6\xB0v\xE1%“'O\xEEڵk\xF9\xBA\xA0\xD1h\xAC\xA4\x9Cj\xB5Z\xA3\xD1\xE8\xC2|\xD8\xE4\xC2g\xB0\x9E~\xFA\xE9\xB3g\xCF.@\cep\xD5[\xC0\xAA\x85\xCF`}\xF7\xDDw\x976\x9Bv`5\x9B\xCD\xC5\xC5ŵ\xDC\xCD7\xDF|\xC9`\xB3i\xD6\xD0\xD0\xD0\xD4\xD4\xD4\xC0\xC0@\xEB\xE5\xD2\xD2\xD2\xF3\xCF?\xBFm۶;v=z\xB4\x94\xF2\xC9'\x9F\xDC{\xEF\xBDo\xBC\xF1\xC6\xED\xB7\xDF\xFE\xE0\x83\xB66;q\xE2Ď;n\xBB\x{DDB7}\xDEzk%_\xAC\xF5!\xDF\xFF\xFD\xC4\xC4\xC4\xF0\xF0\xF0;\xEF\xBC\xF3\xCD7\xDF\xECݻ\xF7\xD6[o}\xF3\xCD7[\xDB\xFC\xFD\xF7\xDFz\xE0\x81\xBE\xFD\xF6\xDB\xF0\xB7\xCBf\xD2ٟ\xA0\xCBځu\xFA\xF4\xE9\xC7{\xAC\xF3\xEE\xF4\xF4\xF4\xF6\xED\xDB\xFD\xF5\xD7\xE9\xE9\xE9#G\x8E\x94R\x9Ex\xE2\x893gΌ\x8C\x8C\xFC\xF6\xDBo\xAD{:|\xF9\xE5\x97G\x8F\xFD\xFA믏;\xF6\xC2/\xCC\xCE\xCE^\xF7\x8BMMM\x9D9sfvv\xF6\xE4ɓ\xEF\xBE\xFB\xEEs\xCF=w\xEAԩ\xCF>\xFB죏>:|\xF8pk\x9BÇ?\xFC\xF0\xC3\xFC\xF1Ǒ#G\x9Ey\xE6\x99\xF87\xCC&Ѫ+\x8D@O\x8C\x8F\x8F\x97R\x9E|\xF2ɩ\xA9\xA9\xC1\xC1\xF65\xEF;w\x9F߶m[g\xBB.\xDCr\xCB-\xCDf\xB3\xF3\xCEC=T\xAF\xD7w\xEE\xDCYJy\xEF\xBD\xF7^y啯\xBE\xFA\xAA\x94200\xD0ڬ3\xE8\xF8믿\x86\x86\x86Zo^\xBCxqpp\xB05^ZZڲeKk<66ֹ:~hh(\xB2pI߻\xE4\xFE\x97t\xD5\xF2\xFD\xB0^\xAF\xFC\xF1ǥ\x94s\xE7\xCEumzl6\xED3X\xB3\xB3\xB3\xBBv\xED\xFA\xFC\xF3\xCF[/Ϟ=\xBB\xBC\xAEʕ\xAE\xA9\x9A\x9B\x9B\xABT*\xAD\xF1\xA3\x8F>\xBA\x92弭[\xB7v\xC6[\xB6l\xF9w7\xFD{\xAD\xFD\xEF\xBF\xFF\xDE\xFC\x87\xBAb.?k\xE5<]\xD6.\x9Bcǎ\xBD\xFD\xF6ۏ?\xFEx\xEB\xE5\xF6\xED\xDB/^\xBCx\xED\xBFy\xDF}\xF7}\xFA駭\xF1\xE2\xE2\xE2\xC4\xC4DdB\xBBw\xEF\xEE\x8C?\xF8\xE0\x83\xC8g\xB2\xA94\xAF\xA4ד`si։'FGG\xFF\xFC\xF3\xCF\xD6\xCBj\xB5:;;\xBB\xB4\xB4t\xFA\xF4\xE9\xBBﾻ\x94\xD2Z\xB6\xBBp\xE1B\xE7o\xBE\xFE\xFA\xEB\x87\xFA\xE2\x8B/\x9E}\xF6ٗ_~\xB9\x94\xF2\xE3\x8F?\x96R~\xFA\xE9\xA7\xCE`\xF9k\xBD\xF9\xF3\xCF?\x97R~\xF9\xE5\x97θ\xF5\xEB?\xFCPJٷo\xDF\xFB\x{FFFF}\xB8\xB8x\xFC\xF8\xF1?\xFC\xF0\xC6~\xF77@\xFB\xA2\xAB\xF3\xE7Ϗ\x8F\x8FOOO\xB7^\xBE\xFAꫵZ\xED\x91Gٽ{\xF7K/\xBDT\xFEy8\xEE=\xF7\xDC\xD3ʠR\xCA\xC4\xC4ġC\x87\xF6\xED۷u\xEB\xD6\xD7^{m\xEF޽\xA5\x94;Ｓ\x942::\xDA\xDAfttt\xF9Ƀ֟\x8E\x8C\x8C4\x9B\xCD;3)\xA5\xDCu\xD7]\xCDf\xF3\xC5_<x\xF0\xE0SO=u\xFF\xFD\xF7?~\xBC\xFFQ\xED\x8B\xDC=\xEC\x99
+m\xE5t\x91;]\xE0a\xCF\xF4\x89z\xBD\xDE\xEB)@[\xF8Q98\x83E\x9Fؿ\xFF\xE5o^~\xA7\x8FS\xA7Nue:lj\xCE`\x84	,\x800\x81&\xB0\xC2@\x98\xC0Xa L`\x84	,\x800\x8Fʡ\xCD\xCC\xCC,999٫\x99\xB09	,\xFAP繄\x97?\x8B\xBA\xC0!@\x983X\xF4!K\x84\xF4\x96\xC0\xA2Y"\xA0\xB7,\x849\x83E\xB2D@o	,\xFA\x90%Bz\xCB!@\x98\xC0Xa L`\x84	,\x800\x81&\xB0\xC2@\x98;\xB9\xD3'.y<\xF4\x90\xC0\xA2O\xECٳg%\x9B\xCD\xCF\xCF\xDF\xE8\x99\x80%B\x800\x81&\xB0\xC2@\x98\xC0Xa L`\x84	,\x800\x81&\xB0\xC2@\x98\xC0Xa L`\x84	,\x800\x81&\xB0\xC2@\x98\xC0Xa L`\x84	,\x800\x81&\xB0\xC2@\x98\xC0Xa L`\x84	,\x800\x81&\xB0\xC2@\x98\xC0Xa L`\x84	,\x800\x81&\xB0\xC2@\x98\xC0Xa L`\x84	,\x800\x81&\xB0\xC2@\x98\xC0Xa L`\x84	,\x800\x81&\xB0\xC2@\x98\xC0Xa L`\x84	,\x800\x81&\xB0\xC2@\x98\xC0Xa L`\x84	,\x800\x81&\xB0\xC2@\x98\xC0Xa L`\x84	,\x800\x81&\xB0\xC2@\x98\xC0Xa L`\x84	,\x800\x81&\xB0\xC2@\x98\xC0Xa L`\x84	,\x800\x81&\xB0\xC2@\x98\xC0Xa L`\x84	,\x800\x81&\xB0\xC2@\x98\xC0Xa L`\x84	,\x800\x81&\xB0\xC2@\x98\xC0Xa L`\x84	,\x800\x81&\xB0\xC2@\x98\xC0Xa L`\x84	,\x800\x81&\xB0\xC2@\x98\xC0Xa L`\x84	,\x800\x81&\xB0\xC2@\x98\xC0Xa L`\x84	,\x800\x81&\xB0\xC2@\x98\xC0Xa L`\x84	,\x800\x81&\xB0\xC2@\x98\xC0Xa L`\x84	,\x800\x81&\xB0\xC2@\x98\xC0Xa L`\x84	,\x800\x81&\xB0\xC2@\x98\xC0Xa\x83\xBD\x9Ed\xCC\xCF\xCF\xF7z
+\xD0&\xB0\xE8\xB5Zm%\x9B\xD5\xEB\xF5=\xB0D&\xB0\xC2@\x98\xC0s\x91;\xFDf``\xE0\xF27\x9B\xCDf\xF7g\xC0\xA6\xE5\xFD\xE6\xF2\x96RWt\x99\xC0\xA2-/*u@\xF7	,\xFAS\xAB\xAB\xD4=!\xB0\xE8[\xEA
+\x80^Xa\x8B~P\xA9T\xE2[\xC0\xAA	,\xFAA\xB5Z]\xC9C\xEB\xF5z\xB5Z\xED\xC2|\xD8\xE4\xDC\x8B>Q\xAB\xD5\x8D\xC6\xC2\xC2\xC2\xD56\xA8T*+| 4\xAC\xD1\xEB\xDA\xC7'Xo*\x95\xCA\xF23R\xCEN\xB0N\xFCX\xF5z}%?߷b\xF6\xEF\xDF\x9F\xCA\xCC\xCC̞={\xE2\xCB5??\xBF\xC2\xD2y)֛\xF65X\x8DF\xC3Q\x8A\x8D\xA8\xB52\xD8\xEBY\xC0\xB4\xCB\xCA \x97\xBD\x80\xF5\xE6:\xFF\x8B\xF0\x8A\xCFͅ\x9E\xB07\xB0Q\+\xB0\xD6r<\x9B\x99\x99\xB9\xDAVMc\xB0!\5\xB0\xC9X\x9F\xEC\x99\xACW,\xC70\xD63\xFB'\xEBܕo4\xDAl6\xAF}[\\\xBC\xEEGw\xB6\xB9|k\xE1)\xCE\xACsW]"tc}\xB2g\xB0\xFE]\xEB"\xF7\xB5\xC9&''\xAF6\x80USWl׹M\x83\xE3뇽\x80\x8D\xA2X\x95J\xA5\xB7\xF3\x80U\xB3\xF7\xB0޴\xABZ\xAD\xB62K\xBD^\xF7\x8Cg֛\x81\xF1\xF1\xF1R\xCA\xDC\xDC\)\xA5\xD1hx\xEAH\xA5RYE]8p\xA0\x94r\xEEܹ0#(\xA5Xccc\xBD\x9E	t\x95\xC0\xE0ƹ\xA9\xA8+\x80\xA8\xC1\xE1\xE1a?\xCA]\xE76
+\xFC\xBF@\x98\xC0Xa L`\x84	,\x800\x81&\xB0\xC2@\x98\xC0Xa L`\x84	,\x800\x81&\xB0\xC2@\x98\xC0Xa L`\x84	,\x800\x81&\xB0\xC2@\x98\xC0Xa L`\x84	,\x800\x81&\xB0\xC2@\x98\xC0Xa L`\x84	,\x800\x81&\xB0\xC2@\x98\xC0Xa L`\x84	,\x800\x81&\xB0\xC2@\x98\xC0Xa L`\x84	,\x800\x81&\xB0\xC2@\x98\xC0Xa L`\x84	,\x800\x81&\xB0\xC2@\x98\xC0Xa L`\x84	,\x800\x81&\xB0\xC2@\x98\xC0Xa L`\x84	,\x800\x81&\xB0\xC2@\x98\xC0Xa L`\x84	,\x800\x81&\xB0\xC2@\x98\xC0Xa L`\x84	,\x800\x81&\xB0\xC2@\x98\xC0Xa L`\x84	,\x800\x81&\xB0\xC2@\x98\xC0Xa L`\x84	,\x800\x81&\xB0\xC2@\x98\xC0Xa L`\x84	,\x800\x81&\xB0\xC2@\x98\xC0Xa L`\x84	,\x800\x81&\xB0\xC2@\x98\xC0Xa L`\x84	,\x800\x81&\xB0\xC2@\x98\xC0Xa L`\x84	,\x800\x81&\xB0\xC2@\x98\xC0Xa L`\x84	,\x800\x81&\xB0\xC2@\x98\xC0Xa L`\x84	,\x800\x81&\xB0\xC2@\x98\xC0Xa L`\x84	,\x800\x81&\xB0\xC2@\x98\xC0Xa L`\x84	,\x800\x81&\xB0\xC2@\x98\xC0Xa L`\x84	,\x800\x81&\xB0\xC2@\x98\xC0Xa L`\x84	,\x800\x81&\xB0\xC2@\x98\xC0Xa L`\x84	,\x800\x81&\xB0\xC2@\x98\xC0Xa L`\x84	,\x800\x81&\xB0\xC2@\x98\xC0Xa L`\x84	,\x800\x81&\xB0\xC2@\x98\xC0Xa L`\x84	,\x800\x81&\xB0\xC2@\x98\xC0Xa L`\x84	,\x800\x81&\xB0\xC2@\x98\xC0Xa L`\x84	,\x800\x81&\xB0\xC2@\x98\xC0Xa L`\x84	,\x800\x81&\xB0\xC2@\x98\xC0Xa L`\x84	,\x800\x81&\xB0\xC2@\x98\xC0Xa L`\x84	,\x800\x81&\xB0\xC2@\x98\xC0Xa L`\x84	,\x800\x81&\xB0\xC2@\x98\xC0Xa L`\x84	,\x800\x81&\xB0\xC2@\xD8\xFF\xE35L<?1\xA6\xB7IEND\xAEB`\x82
\ No newline at end of file

Added: trunk/LayoutTests/platform/chromium-linux/fast/repaint/repaint-during-scroll-with-zoom-expected.txt (0 => 121722)


--- trunk/LayoutTests/platform/chromium-linux/fast/repaint/repaint-during-scroll-with-zoom-expected.txt	                        (rev 0)
+++ trunk/LayoutTests/platform/chromium-linux/fast/repaint/repaint-during-scroll-with-zoom-expected.txt	2012-07-03 02:22:46 UTC (rev 121722)
@@ -0,0 +1,14 @@
+layer at (0,0) size 800x600
+  RenderView at (0,0) size 800x600
+layer at (0,0) size 800x0
+  RenderBlock {HTML} at (0,0) size 800x0
+    RenderBody {BODY} at (0,0) size 800x0 [bgcolor=#C0C0C0]
+layer at (0,63) size 254x254
+  RenderPartObject {IFRAME} at (0,63) size 254x254 [border: (2px inset #000000)]
+    layer at (0,0) size 2008x2016
+      RenderView at (0,0) size 235x235
+    layer at (0,0) size 235x2016
+      RenderBlock {HTML} at (0,0) size 235x2016
+        RenderBody {BODY} at (8,8) size 2000x2000 [bgcolor=#FFFFFF]
+          RenderText {#text} at (0,0) size 54x19
+            text run at (0,0) width 54: "scroll me"

Modified: trunk/LayoutTests/platform/chromium-win/fast/box-sizing/box-sizing-expected.txt (121721 => 121722)


--- trunk/LayoutTests/platform/chromium-win/fast/box-sizing/box-sizing-expected.txt	2012-07-03 02:19:01 UTC (rev 121721)
+++ trunk/LayoutTests/platform/chromium-win/fast/box-sizing/box-sizing-expected.txt	2012-07-03 02:22:46 UTC (rev 121722)
@@ -81,10 +81,10 @@
     RenderBR {BR} at (6,26) size 0x19
     RenderBR {BR} at (6,46) size 0x19
 layer at (13,757) size 20x20
-  RenderImage {IMG} at (13,757) size 20x21 [color=#FFFFFF] [bgcolor=#FFA500] [border: (2px solid #000000)]
+  RenderImage {IMG} at (13,757) size 20x20 [color=#FFFFFF] [bgcolor=#FFA500] [border: (2px solid #000000)]
 layer at (43,757) size 20x20
-  RenderImage {IMG} at (43,757) size 20x21 [color=#FFFFFF] [bgcolor=#FFA500] [border: (2px solid #000000)]
+  RenderImage {IMG} at (43,757) size 20x20 [color=#FFFFFF] [bgcolor=#FFA500] [border: (2px solid #000000)]
 layer at (73,757) size 20x20
-  RenderImage {IMG} at (73,757) size 20x21 [color=#FFFFFF] [bgcolor=#FFA500] [border: (2px solid #000000)]
+  RenderImage {IMG} at (73,757) size 20x20 [color=#FFFFFF] [bgcolor=#FFA500] [border: (2px solid #000000)]
 layer at (103,757) size 20x20
-  RenderImage {IMG} at (103,757) size 20x21 [color=#FFFFFF] [bgcolor=#FFA500] [border: (2px solid #000000)]
+  RenderImage {IMG} at (103,757) size 20x20 [color=#FFFFFF] [bgcolor=#FFA500] [border: (2px solid #000000)]

Modified: trunk/LayoutTests/platform/chromium-win/media/media-document-audio-repaint-expected.txt (121721 => 121722)


--- trunk/LayoutTests/platform/chromium-win/media/media-document-audio-repaint-expected.txt	2012-07-03 02:19:01 UTC (rev 121721)
+++ trunk/LayoutTests/platform/chromium-win/media/media-document-audio-repaint-expected.txt	2012-07-03 02:22:46 UTC (rev 121722)
@@ -15,7 +15,7 @@
             RenderBlock {HTML} at (0,0) size 380x330
               RenderBody {BODY} at (8,8) size 364x314 [bgcolor=#000000]
           layer at (40,165) size 300x1
-            RenderVideo {VIDEO} at (40,164) size 300x2
+            RenderVideo {VIDEO} at (40,165) size 300x1
           layer at (40,165) size 300x1
             RenderDeprecatedFlexibleBox (relative positioned) {DIV} at (0,0) size 300x1
               RenderBlock {DIV} at (0,0) size 300x35

Modified: trunk/LayoutTests/platform/chromium-win/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.png


(Binary files differ)

Modified: trunk/LayoutTests/platform/chromium-win/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.txt (121721 => 121722)


--- trunk/LayoutTests/platform/chromium-win/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.txt	2012-07-03 02:19:01 UTC (rev 121721)
+++ trunk/LayoutTests/platform/chromium-win/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.txt	2012-07-03 02:22:46 UTC (rev 121722)
@@ -14,7 +14,7 @@
             RenderSVGRoot {svg} at (0,0) size 250x113
               RenderSVGRect {rect} at (0,0) size 250x113 [fill={[type=SOLID] [color=#ADD8E6]}] [x=0.00] [y=0.00] [width=250.00] [height=112.50]
               RenderSVGRect {rect} at (12,5) size 226x102 [fill={[type=SOLID] [color=#008000]}] [x=12.50] [y=5.63] [width=225.00] [height=101.25]
-layer at (0,118) size 250x112
-  RenderSVGRoot {svg} at (0,117) size 250x113
-    RenderSVGRect {rect} at (0,117) size 250x113 [fill={[type=SOLID] [color=#ADD8E6]}] [x=0.00] [y=0.00] [width=100.00] [height=100.00]
-    RenderSVGRect {rect} at (12,122) size 226x103 [fill={[type=SOLID] [color=#008000]}] [x=5.00] [y=5.00] [width=90.00] [height=90.00]
+layer at (0,118) size 250x113
+  RenderSVGRoot {svg} at (0,118) size 250x113
+    RenderSVGRect {rect} at (0,118) size 250x113 [fill={[type=SOLID] [color=#ADD8E6]}] [x=0.00] [y=0.00] [width=100.00] [height=100.00]
+    RenderSVGRect {rect} at (12,123) size 226x102 [fill={[type=SOLID] [color=#008000]}] [x=5.00] [y=5.00] [width=90.00] [height=90.00]

Modified: trunk/LayoutTests/platform/chromium-win/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.png


(Binary files differ)

Modified: trunk/LayoutTests/platform/chromium-win/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.txt (121721 => 121722)


--- trunk/LayoutTests/platform/chromium-win/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.txt	2012-07-03 02:19:01 UTC (rev 121721)
+++ trunk/LayoutTests/platform/chromium-win/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.txt	2012-07-03 02:22:46 UTC (rev 121722)
@@ -14,7 +14,7 @@
             RenderSVGRoot {svg} at (0,0) size 125x113
               RenderSVGRect {rect} at (0,0) size 125x113 [fill={[type=SOLID] [color=#ADD8E6]}] [x=0.00] [y=0.00] [width=125.00] [height=112.50]
               RenderSVGRect {rect} at (6,5) size 113x102 [fill={[type=SOLID] [color=#008000]}] [x=6.25] [y=5.63] [width=112.50] [height=101.25]
-layer at (0,118) size 125x112
-  RenderSVGRoot {svg} at (0,117) size 125x113
-    RenderSVGRect {rect} at (0,117) size 125x113 [fill={[type=SOLID] [color=#ADD8E6]}] [x=0.00] [y=0.00] [width=100.00] [height=100.00]
-    RenderSVGRect {rect} at (6,122) size 113x103 [fill={[type=SOLID] [color=#008000]}] [x=5.00] [y=5.00] [width=90.00] [height=90.00]
+layer at (0,118) size 125x113
+  RenderSVGRoot {svg} at (0,118) size 125x113
+    RenderSVGRect {rect} at (0,118) size 125x113 [fill={[type=SOLID] [color=#ADD8E6]}] [x=0.00] [y=0.00] [width=100.00] [height=100.00]
+    RenderSVGRect {rect} at (6,123) size 113x102 [fill={[type=SOLID] [color=#008000]}] [x=5.00] [y=5.00] [width=90.00] [height=90.00]

Modified: trunk/Source/WebCore/ChangeLog (121721 => 121722)


--- trunk/Source/WebCore/ChangeLog	2012-07-03 02:19:01 UTC (rev 121721)
+++ trunk/Source/WebCore/ChangeLog	2012-07-03 02:22:46 UTC (rev 121722)
@@ -1,3 +1,23 @@
+2012-07-02  Emil A Eklund  <[email protected]>
+
+        Position replaced elements on pixel bounds
+        https://bugs.webkit.org/show_bug.cgi?id=90354
+
+        Reviewed by Eric Seidel.
+
+        To avoid sizing and repaint issues we should layout replaced elements on
+        pixel bounds. We already ensure that replaced elements are sized in full
+        pixels and that they are painted on pixel bounds. By also ensuring that
+        they are placed on pixel bounds we avoid pixel having the size be
+        expanded by pixel snapping and repainting/invalidation rect issues when
+        scrolling.
+
+        Test: fast/repaint/repaint-during-scroll-with-zoom.html
+
+        * rendering/RenderBox.cpp:
+        (WebCore::RenderBox::computePositionedLogicalWidthReplaced):
+        (WebCore::RenderBox::computePositionedLogicalHeightReplaced):
+
 2012-07-02  Nico Weber  <[email protected]>
 
         Fix new -Wunused-private-field violations

Modified: trunk/Source/WebCore/rendering/RenderBox.cpp (121721 => 121722)


--- trunk/Source/WebCore/rendering/RenderBox.cpp	2012-07-03 02:19:01 UTC (rev 121721)
+++ trunk/Source/WebCore/rendering/RenderBox.cpp	2012-07-03 02:22:46 UTC (rev 121722)
@@ -3265,7 +3265,7 @@
 
     LayoutUnit logicalLeftPos = logicalLeftValue + marginLogicalLeftAlias;
     computeLogicalLeftPositionedOffset(logicalLeftPos, this, logicalWidth(), containerBlock, containerLogicalWidth);
-    setLogicalLeft(logicalLeftPos);
+    setLogicalLeft(logicalLeftPos.round());
 }
 
 void RenderBox::computePositionedLogicalHeightReplaced()
@@ -3394,7 +3394,7 @@
     // Use computed values to calculate the vertical position.
     LayoutUnit logicalTopPos = logicalTopValue + marginBeforeAlias;
     computeLogicalTopPositionedOffset(logicalTopPos, this, logicalHeight(), containerBlock, containerLogicalHeight);
-    setLogicalTop(logicalTopPos);
+    setLogicalTop(logicalTopPos.round());
 }
 
 LayoutRect RenderBox::localCaretRect(InlineBox* box, int caretOffset, LayoutUnit* extraWidthToEndOfLine)

_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to