Title: [121790] trunk/Source/WebCore
- Revision
- 121790
- Author
- [email protected]
- Date
- 2012-07-03 10:47:24 -0700 (Tue, 03 Jul 2012)
Log Message
Web Inspector: Anonymous scripts (evals) should not be added to Workspace.
https://bugs.webkit.org/show_bug.cgi?id=90467
Reviewed by Pavel Feldman.
* inspector/front-end/ResourceScriptMapping.js:
(WebInspector.ResourceScriptMapping.prototype.rawLocationToUILocation):
(WebInspector.ResourceScriptMapping.prototype._uiSourceCodeAdded):
(WebInspector.ResourceScriptMapping.prototype._uiSourceCodeReplaced):
(WebInspector.ResourceScriptMapping.prototype._uiSourceCodeRemoved):
* inspector/front-end/ScriptSnippetModel.js:
(WebInspector.ScriptSnippetModel.prototype._createUISourceCodeForScript):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._uiSourceCodeAdded):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (121789 => 121790)
--- trunk/Source/WebCore/ChangeLog 2012-07-03 17:41:35 UTC (rev 121789)
+++ trunk/Source/WebCore/ChangeLog 2012-07-03 17:47:24 UTC (rev 121790)
@@ -1,3 +1,20 @@
+2012-07-03 Vsevolod Vlasov <[email protected]>
+
+ Web Inspector: Anonymous scripts (evals) should not be added to Workspace.
+ https://bugs.webkit.org/show_bug.cgi?id=90467
+
+ Reviewed by Pavel Feldman.
+
+ * inspector/front-end/ResourceScriptMapping.js:
+ (WebInspector.ResourceScriptMapping.prototype.rawLocationToUILocation):
+ (WebInspector.ResourceScriptMapping.prototype._uiSourceCodeAdded):
+ (WebInspector.ResourceScriptMapping.prototype._uiSourceCodeReplaced):
+ (WebInspector.ResourceScriptMapping.prototype._uiSourceCodeRemoved):
+ * inspector/front-end/ScriptSnippetModel.js:
+ (WebInspector.ScriptSnippetModel.prototype._createUISourceCodeForScript):
+ * inspector/front-end/ScriptsPanel.js:
+ (WebInspector.ScriptsPanel.prototype._uiSourceCodeAdded):
+
2012-07-03 Robert Hogan <[email protected]>
CSS 2.1 failure: floats-wrap-top-below-inline-* fail
Modified: trunk/Source/WebCore/inspector/front-end/ResourceScriptMapping.js (121789 => 121790)
--- trunk/Source/WebCore/inspector/front-end/ResourceScriptMapping.js 2012-07-03 17:41:35 UTC (rev 121789)
+++ trunk/Source/WebCore/inspector/front-end/ResourceScriptMapping.js 2012-07-03 17:47:24 UTC (rev 121790)
@@ -161,6 +161,8 @@
*/
_uiSourceCodeAdded: function(rawSourceCode, uiSourceCode)
{
+ if (!uiSourceCode.url)
+ return;
this._rawSourceCodeForUISourceCode.put(uiSourceCode, rawSourceCode);
this.dispatchEventToListeners(WebInspector.UISourceCodeProvider.Events.UISourceCodeAdded, uiSourceCode);
},
@@ -172,6 +174,8 @@
*/
_uiSourceCodeReplaced: function(rawSourceCode, oldUISourceCode, uiSourceCode)
{
+ if (!uiSourceCode.url)
+ return;
this._rawSourceCodeForUISourceCode.remove(oldUISourceCode);
this._rawSourceCodeForUISourceCode.put(uiSourceCode, rawSourceCode);
@@ -188,6 +192,8 @@
*/
_uiSourceCodeRemoved: function(rawSourceCode, uiSourceCode)
{
+ if (!uiSourceCode.url)
+ return;
this._rawSourceCodeForUISourceCode.remove(uiSourceCode);
this.dispatchEventToListeners(WebInspector.UISourceCodeProvider.Events.UISourceCodeRemoved, uiSourceCode);
},
Modified: trunk/Source/WebCore/inspector/front-end/ScriptSnippetModel.js (121789 => 121790)
--- trunk/Source/WebCore/inspector/front-end/ScriptSnippetModel.js 2012-07-03 17:41:35 UTC (rev 121789)
+++ trunk/Source/WebCore/inspector/front-end/ScriptSnippetModel.js 2012-07-03 17:47:24 UTC (rev 121790)
@@ -289,7 +289,6 @@
uiSourceCode.isSnippetEvaluation = true;
this._uiSourceCodeForScriptId[script.scriptId] = uiSourceCode;
this._scriptForUISourceCode.put(uiSourceCode, script);
- this._snippetScriptMapping._fireUISourceCodeAdded(uiSourceCode);
script.setSourceMapping(this._snippetScriptMapping);
},
Modified: trunk/Source/WebCore/inspector/front-end/ScriptsPanel.js (121789 => 121790)
--- trunk/Source/WebCore/inspector/front-end/ScriptsPanel.js 2012-07-03 17:41:35 UTC (rev 121789)
+++ trunk/Source/WebCore/inspector/front-end/ScriptsPanel.js 2012-07-03 17:47:24 UTC (rev 121790)
@@ -247,11 +247,6 @@
*/
_uiSourceCodeAdded: function(uiSourceCode)
{
- if (!uiSourceCode.url || uiSourceCode.isSnippetEvaluation) {
- // Anonymous sources and snippets evaluations are shown only when stepping.
- return;
- }
-
this._addUISourceCode(uiSourceCode);
},
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
