Title: [121875] trunk/Source/WebCore
- Revision
- 121875
- Author
- [email protected]
- Date
- 2012-07-04 18:25:08 -0700 (Wed, 04 Jul 2012)
Log Message
Remove inline keywords from functions which can not be inlined in ComposedShadowTreeWalker
https://bugs.webkit.org/show_bug.cgi?id=90432
Reviewed by Hajime Morita.
No new tests - no functional changes.
* dom/ComposedShadowTreeWalker.cpp:
(WebCore::ComposedShadowTreeWalker::traverseParent):
(WebCore::ComposedShadowTreeWalker::traverseParentBackToYoungerShadowRootOrHost):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (121874 => 121875)
--- trunk/Source/WebCore/ChangeLog 2012-07-05 00:15:54 UTC (rev 121874)
+++ trunk/Source/WebCore/ChangeLog 2012-07-05 01:25:08 UTC (rev 121875)
@@ -1,3 +1,16 @@
+2012-07-04 Hayato Ito <[email protected]>
+
+ Remove inline keywords from functions which can not be inlined in ComposedShadowTreeWalker
+ https://bugs.webkit.org/show_bug.cgi?id=90432
+
+ Reviewed by Hajime Morita.
+
+ No new tests - no functional changes.
+
+ * dom/ComposedShadowTreeWalker.cpp:
+ (WebCore::ComposedShadowTreeWalker::traverseParent):
+ (WebCore::ComposedShadowTreeWalker::traverseParentBackToYoungerShadowRootOrHost):
+
2012-07-04 Luke Macpherson <[email protected]>
Inspector crashes when trying to inspect a page with CSS variables
Modified: trunk/Source/WebCore/dom/ComposedShadowTreeWalker.cpp (121874 => 121875)
--- trunk/Source/WebCore/dom/ComposedShadowTreeWalker.cpp 2012-07-05 00:15:54 UTC (rev 121874)
+++ trunk/Source/WebCore/dom/ComposedShadowTreeWalker.cpp 2012-07-05 01:25:08 UTC (rev 121875)
@@ -220,7 +220,9 @@
assertPostcondition();
}
-inline Node* ComposedShadowTreeWalker::traverseParent(const Node* node, ParentTranversalDetails* details) const
+// FIXME: Use an iterative algorithm so that it can be inlined.
+// https://bugs.webkit.org/show_bug.cgi?id=90415
+Node* ComposedShadowTreeWalker::traverseParent(const Node* node, ParentTranversalDetails* details) const
{
if (!canCrossUpperBoundary() && node->isShadowRoot()) {
ASSERT(toShadowRoot(node)->isYoungest());
@@ -248,7 +250,7 @@
return 0;
}
-inline Node* ComposedShadowTreeWalker::traverseParentBackToYoungerShadowRootOrHost(const ShadowRoot* shadowRoot, ParentTranversalDetails* details) const
+Node* ComposedShadowTreeWalker::traverseParentBackToYoungerShadowRootOrHost(const ShadowRoot* shadowRoot, ParentTranversalDetails* details) const
{
ASSERT(shadowRoot);
if (shadowRoot->isYoungest()) {
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
