Title: [121878] trunk/Tools
- Revision
- 121878
- Author
- [email protected]
- Date
- 2012-07-04 20:48:03 -0700 (Wed, 04 Jul 2012)
Log Message
[Tools] webkit_unittest.py got assertion
https://bugs.webkit.org/show_bug.cgi?id=90579
Reviewed by Hajime Morita.
This patch updates expectation of assertion in test_skipped_directories_for_symbols().
r121874 added new (exclude) directory (inspector/styles/variables), however it didn't
update one of two assertions.
* Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (121877 => 121878)
--- trunk/Tools/ChangeLog 2012-07-05 03:30:32 UTC (rev 121877)
+++ trunk/Tools/ChangeLog 2012-07-05 03:48:03 UTC (rev 121878)
@@ -1,3 +1,16 @@
+2012-07-04 Yoshifumi Inoue <[email protected]>
+
+ [Tools] webkit_unittest.py got assertion
+ https://bugs.webkit.org/show_bug.cgi?id=90579
+
+ Reviewed by Hajime Morita.
+
+ This patch updates expectation of assertion in test_skipped_directories_for_symbols().
+ r121874 added new (exclude) directory (inspector/styles/variables), however it didn't
+ update one of two assertions.
+
+ * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
+
2012-07-04 Balazs Ankes <[email protected]>
webkit-patch should add reviewer if "Reviewed by NOBODY ..." is missing
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit_unittest.py (121877 => 121878)
--- trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit_unittest.py 2012-07-05 03:30:32 UTC (rev 121877)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit_unittest.py 2012-07-05 03:48:03 UTC (rev 121878)
@@ -113,7 +113,7 @@
000000000124f670 s __ZZN7WebCore13GraphicsLayer13addChildBelowEPS0_S1_E19__PRETTY_FUNCTION__
"""
# Note 'compositing' is not in the list of skipped directories (hence the parsing of GraphicsLayer worked):
- expected_directories = set(['mathml', 'transforms/3d', 'compositing/webgl', 'fast/canvas/webgl', 'animations/3d', 'mhtml', 'http/tests/canvas/webgl', 'fast/css/variables'])
+ expected_directories = set(['mathml', 'transforms/3d', 'compositing/webgl', 'fast/canvas/webgl', 'animations/3d', 'mhtml', 'http/tests/canvas/webgl', 'fast/css/variables', 'inspector/styles/variables'])
result_directories = set(TestWebKitPort(symbols_string, None)._skipped_tests_for_unsupported_features(test_list=['mathml/foo.html']))
self.assertEqual(result_directories, expected_directories)
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes