Title: [122022] releases/WebKitGTK/webkit-1.8
- Revision
- 122022
- Author
- [email protected]
- Date
- 2012-07-06 13:19:43 -0700 (Fri, 06 Jul 2012)
Log Message
Merge 108152 - Avoid inconsistency in Node::inDocument due to DOMSubtreeModified dispatch
https://bugs.webkit.org/show_bug.cgi?id=76087
Patch by Adam Klein <[email protected]> on 2012-02-17
Reviewed by Ryosuke Niwa.
Source/WebCore:
Move post-removal notifications after call to Node::removeFromDocument
to avoid inconsistent state of Node::inDocument() and thus avoid
inconsistent state in DocumentOrderedMap.
Tests: fast/dom/getElementById-consistency.html
fast/dom/getElementById-consistency2.html
* dom/ContainerNode.cpp:
(WebCore::ContainerNode::removeChild):
* svg/SVGTRefElement.cpp:
(WebCore::SVGTRefElement::updateReferencedText): Fixed to work with new timing of DOMSubtreeModified dispatch.
LayoutTests:
* fast/dom/getElementById-consistency-expected.txt: Added.
* fast/dom/getElementById-consistency.html: Added.
* fast/dom/getElementById-consistency2-expected.txt: Added.
* fast/dom/getElementById-consistency2.html: Added.
Modified Paths
Diff
Modified: releases/WebKitGTK/webkit-1.8/LayoutTests/ChangeLog (122021 => 122022)
--- releases/WebKitGTK/webkit-1.8/LayoutTests/ChangeLog 2012-07-06 20:19:36 UTC (rev 122021)
+++ releases/WebKitGTK/webkit-1.8/LayoutTests/ChangeLog 2012-07-06 20:19:43 UTC (rev 122022)
@@ -1,3 +1,15 @@
+2012-02-17 Adam Klein <[email protected]>
+
+ Avoid inconsistency in Node::inDocument due to DOMSubtreeModified dispatch
+ https://bugs.webkit.org/show_bug.cgi?id=76087
+
+ Reviewed by Ryosuke Niwa.
+
+ * fast/dom/getElementById-consistency-expected.txt: Added.
+ * fast/dom/getElementById-consistency.html: Added.
+ * fast/dom/getElementById-consistency2-expected.txt: Added.
+ * fast/dom/getElementById-consistency2.html: Added.
+
2012-03-25 Abhishek Arya <[email protected]>
Crash in ContainerNode::resumePostAttachCallbacks.
Modified: releases/WebKitGTK/webkit-1.8/Source/WebCore/ChangeLog (122021 => 122022)
--- releases/WebKitGTK/webkit-1.8/Source/WebCore/ChangeLog 2012-07-06 20:19:36 UTC (rev 122021)
+++ releases/WebKitGTK/webkit-1.8/Source/WebCore/ChangeLog 2012-07-06 20:19:43 UTC (rev 122022)
@@ -1,3 +1,22 @@
+2012-02-17 Adam Klein <[email protected]>
+
+ Avoid inconsistency in Node::inDocument due to DOMSubtreeModified dispatch
+ https://bugs.webkit.org/show_bug.cgi?id=76087
+
+ Reviewed by Ryosuke Niwa.
+
+ Move post-removal notifications after call to Node::removeFromDocument
+ to avoid inconsistent state of Node::inDocument() and thus avoid
+ inconsistent state in DocumentOrderedMap.
+
+ Tests: fast/dom/getElementById-consistency.html
+ fast/dom/getElementById-consistency2.html
+
+ * dom/ContainerNode.cpp:
+ (WebCore::ContainerNode::removeChild):
+ * svg/SVGTRefElement.cpp:
+ (WebCore::SVGTRefElement::updateReferencedText): Fixed to work with new timing of DOMSubtreeModified dispatch.
+
2012-03-25 Abhishek Arya <[email protected]>
Crash in ContainerNode::resumePostAttachCallbacks.
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes