Title: [122059] trunk/Source/WebCore
- Revision
- 122059
- Author
- [email protected]
- Date
- 2012-07-08 02:04:05 -0700 (Sun, 08 Jul 2012)
Log Message
Web Inspector: CodeGeneratorInspector.py should not generate statements with no effect
https://bugs.webkit.org/show_bug.cgi?id=90697
Patch by Vivek Galatage <[email protected]> on 2012-07-08
Reviewed by Vsevolod Vlasov.
Fix to remove the statements with no effect. The check for errors is added only when some valid
statements exist.
No new tests as generator related patch.
* inspector/CodeGeneratorInspector.py:
(Generator.process_command):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (122058 => 122059)
--- trunk/Source/WebCore/ChangeLog 2012-07-08 04:03:40 UTC (rev 122058)
+++ trunk/Source/WebCore/ChangeLog 2012-07-08 09:04:05 UTC (rev 122059)
@@ -1,3 +1,18 @@
+2012-07-08 Vivek Galatage <[email protected]>
+
+ Web Inspector: CodeGeneratorInspector.py should not generate statements with no effect
+ https://bugs.webkit.org/show_bug.cgi?id=90697
+
+ Reviewed by Vsevolod Vlasov.
+
+ Fix to remove the statements with no effect. The check for errors is added only when some valid
+ statements exist.
+
+ No new tests as generator related patch.
+
+ * inspector/CodeGeneratorInspector.py:
+ (Generator.process_command):
+
2012-07-06 Lauro Neto <[email protected]>
[Qt] Avoid deep copy of QImage in GraphicsContext3D::getImageData()
Modified: trunk/Source/WebCore/inspector/CodeGeneratorInspector.py (122058 => 122059)
--- trunk/Source/WebCore/inspector/CodeGeneratorInspector.py 2012-07-08 04:03:40 UTC (rev 122058)
+++ trunk/Source/WebCore/inspector/CodeGeneratorInspector.py 2012-07-08 09:04:05 UTC (rev 122059)
@@ -1789,8 +1789,7 @@
if (!protocolErrors->length()) {
$agentField->$methodName(&error$agentCallParams);
- if (!error.length()) {
-${responseCook} }
+${responseCook}
}
sendResponse(callId, result, String::format("Some arguments of method '%s' can't be processed", "$domainName.$methodName"), protocolErrors, error);
}
@@ -2804,6 +2803,9 @@
response_cook_text = join(response_cook_list, "")
+ if len(response_cook_text) != 0:
+ response_cook_text = " if (!error.length()) {\n" + response_cook_text + " }"
+
Generator.backend_method_implementation_list.append(Templates.backend_method.substitute(None,
domainName=domain_name, methodName=json_command_name,
agentField="m_" + agent_field_name,
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
