Title: [122188] trunk
- Revision
- 122188
- Author
- [email protected]
- Date
- 2012-07-09 20:18:15 -0700 (Mon, 09 Jul 2012)
Log Message
REGRESSION(r114862-r114886): Fix a crash by switching the input type to hidden.
https://bugs.webkit.org/show_bug.cgi?id=90774
Reviewed by Andreas Kling.
Source/WebCore:
Test: fast/forms/hidden/change-type-to-hidden-after-updating-value.html
* dom/Element.cpp:
(WebCore::Element::setAttributeInternal):
Pass a copy of the existing Attribute object.
LayoutTests:
* fast/forms/hidden/change-type-to-hidden-after-updating-value.html: Added.
* fast/forms/hidden/change-type-to-hidden-after-updating-value-expected.txt: Added.
Modified Paths
Added Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (122187 => 122188)
--- trunk/LayoutTests/ChangeLog 2012-07-10 02:38:21 UTC (rev 122187)
+++ trunk/LayoutTests/ChangeLog 2012-07-10 03:18:15 UTC (rev 122188)
@@ -1,3 +1,13 @@
+2012-07-09 Kent Tamura <[email protected]>
+
+ REGRESSION(r114862-r114886): Fix a crash by switching the input type to hidden.
+ https://bugs.webkit.org/show_bug.cgi?id=90774
+
+ Reviewed by Andreas Kling.
+
+ * fast/forms/hidden/change-type-to-hidden-after-updating-value.html: Added.
+ * fast/forms/hidden/change-type-to-hidden-after-updating-value-expected.txt: Added.
+
2012-07-09 Hayato Ito <[email protected]>
Unreviewed gardening. Update TestExpectations.
Added: trunk/LayoutTests/fast/forms/hidden/change-type-to-hidden-after-updating-value-expected.txt (0 => 122188)
--- trunk/LayoutTests/fast/forms/hidden/change-type-to-hidden-after-updating-value-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/forms/hidden/change-type-to-hidden-after-updating-value-expected.txt 2012-07-10 03:18:15 UTC (rev 122188)
@@ -0,0 +1 @@
+PASS unless crashed.
Property changes on: trunk/LayoutTests/fast/forms/hidden/change-type-to-hidden-after-updating-value-expected.txt
___________________________________________________________________
Added: svn:eol-style
Added: trunk/LayoutTests/fast/forms/hidden/change-type-to-hidden-after-updating-value.html (0 => 122188)
--- trunk/LayoutTests/fast/forms/hidden/change-type-to-hidden-after-updating-value.html (rev 0)
+++ trunk/LayoutTests/fast/forms/hidden/change-type-to-hidden-after-updating-value.html 2012-07-10 03:18:15 UTC (rev 122188)
@@ -0,0 +1,8 @@
+<input type="text" id="input1">
+<script>
+if (window.testRunner)
+ testRunner.dumpAsText();
+document.getElementById('input1').value = 'value';
+document.getElementById('input1').type = 'hidden';
+document.write('PASS unless crashed.');
+</script>
Property changes on: trunk/LayoutTests/fast/forms/hidden/change-type-to-hidden-after-updating-value.html
___________________________________________________________________
Added: svn:eol-style
Modified: trunk/Source/WebCore/ChangeLog (122187 => 122188)
--- trunk/Source/WebCore/ChangeLog 2012-07-10 02:38:21 UTC (rev 122187)
+++ trunk/Source/WebCore/ChangeLog 2012-07-10 03:18:15 UTC (rev 122188)
@@ -1,3 +1,16 @@
+2012-07-09 Kent Tamura <[email protected]>
+
+ REGRESSION(r114862-r114886): Fix a crash by switching the input type to hidden.
+ https://bugs.webkit.org/show_bug.cgi?id=90774
+
+ Reviewed by Andreas Kling.
+
+ Test: fast/forms/hidden/change-type-to-hidden-after-updating-value.html
+
+ * dom/Element.cpp:
+ (WebCore::Element::setAttributeInternal):
+ Pass a copy of the existing Attribute object.
+
2012-07-07 Philippe Normand <[email protected]>
[GStreamer] cache video dimensions
Modified: trunk/Source/WebCore/dom/Element.cpp (122187 => 122188)
--- trunk/Source/WebCore/dom/Element.cpp 2012-07-10 02:38:21 UTC (rev 122187)
+++ trunk/Source/WebCore/dom/Element.cpp 2012-07-10 03:18:15 UTC (rev 122188)
@@ -679,7 +679,7 @@
old->setValue(value);
if (inUpdateStyleAttribute == NotInUpdateStyleAttribute)
- didModifyAttribute(*old);
+ didModifyAttribute(Attribute(old->name(), old->value()));
}
void Element::attributeChanged(const Attribute& attribute)
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
