Title: [122211] trunk/Source/WTF
- Revision
- 122211
- Author
- [email protected]
- Date
- 2012-07-10 03:49:47 -0700 (Tue, 10 Jul 2012)
Log Message
Re-enable __declspec(dl{import,export}) for MinGW when using EXPORT_MACROS
https://bugs.webkit.org/show_bug.cgi?id=90612
Patch by Jocelyn Turcotte <[email protected]> on 2012-07-10
Reviewed by Csaba Osztrogonác.
MinGW was switched to use auto import/export of symbols on r44184.
>From my understanding of the documentation, MinGW will not auto-export symbols
unless there are no explicit __declspec(dlexport) in the DLL already.
The issues that originally made us rely on the auto-import feature of MinGW
should now be resolved with the EXPORT_MACROS work. This patch re-enables them.
It also removes the GCC check for internal symbols hiding as the visibility should
already be hidden by default for both MSVC and GCC on Windows anyway.
* wtf/ExportMacros.h:
Modified Paths
Diff
Modified: trunk/Source/WTF/ChangeLog (122210 => 122211)
--- trunk/Source/WTF/ChangeLog 2012-07-10 10:20:25 UTC (rev 122210)
+++ trunk/Source/WTF/ChangeLog 2012-07-10 10:49:47 UTC (rev 122211)
@@ -1,3 +1,22 @@
+2012-07-10 Jocelyn Turcotte <[email protected]>
+
+ Re-enable __declspec(dl{import,export}) for MinGW when using EXPORT_MACROS
+ https://bugs.webkit.org/show_bug.cgi?id=90612
+
+ Reviewed by Csaba Osztrogonác.
+
+ MinGW was switched to use auto import/export of symbols on r44184.
+ From my understanding of the documentation, MinGW will not auto-export symbols
+ unless there are no explicit __declspec(dlexport) in the DLL already.
+
+ The issues that originally made us rely on the auto-import feature of MinGW
+ should now be resolved with the EXPORT_MACROS work. This patch re-enables them.
+
+ It also removes the GCC check for internal symbols hiding as the visibility should
+ already be hidden by default for both MSVC and GCC on Windows anyway.
+
+ * wtf/ExportMacros.h:
+
2012-07-09 No'am Rosenthal <[email protected]>
Shared code that is guarded with ENABLE(WEBGL) should be guarded with USE()
Modified: trunk/Source/WTF/wtf/ExportMacros.h (122210 => 122211)
--- trunk/Source/WTF/wtf/ExportMacros.h 2012-07-10 10:20:25 UTC (rev 122210)
+++ trunk/Source/WTF/wtf/ExportMacros.h 2012-07-10 10:49:47 UTC (rev 122211)
@@ -38,7 +38,7 @@
// being local to the target being generated, and thus not subject to (e.g.) ELF
// symbol interposition rules.
-#if !PLATFORM(CHROMIUM) && OS(WINDOWS) && !COMPILER(GCC)
+#if !PLATFORM(CHROMIUM) && OS(WINDOWS)
#define HAVE_INTERNAL_VISIBILITY 1
#define WTF_INTERNAL
#elif defined(__GNUC__) && !defined(__CC_ARM) && !defined(__ARMCC__)
@@ -51,7 +51,7 @@
// See note in wtf/Platform.h for more info on EXPORT_MACROS.
#if USE(EXPORT_MACROS)
-#if !PLATFORM(CHROMIUM) && OS(WINDOWS) && !COMPILER(GCC)
+#if !PLATFORM(CHROMIUM) && OS(WINDOWS)
#define WTF_EXPORT __declspec(dllexport)
#define WTF_IMPORT __declspec(dllimport)
#define WTF_HIDDEN
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
