Title: [122337] trunk/Tools
Revision
122337
Author
[email protected]
Date
2012-07-11 09:50:44 -0700 (Wed, 11 Jul 2012)

Log Message

[Android] sending an extra to the DRT apk so that DRT can be run in a seperate thread
https://bugs.webkit.org/show_bug.cgi?id=90831

Patch by Min Qin <[email protected]> on 2012-07-11
Reviewed by Adam Barth.

On android, DRT needs to run in a background thread to avoid ANR.
However, the java tests are running on UI thread by default.
We need to send an intent extra to the apk so that it can run on a sub thread.

* Scripts/webkitpy/layout_tests/port/chromium_android.py:
(ChromiumAndroidDriver._start_once):

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (122336 => 122337)


--- trunk/Tools/ChangeLog	2012-07-11 16:46:36 UTC (rev 122336)
+++ trunk/Tools/ChangeLog	2012-07-11 16:50:44 UTC (rev 122337)
@@ -1,3 +1,17 @@
+2012-07-11  Min Qin  <[email protected]>
+
+        [Android] sending an extra to the DRT apk so that DRT can be run in a seperate thread
+        https://bugs.webkit.org/show_bug.cgi?id=90831
+
+        Reviewed by Adam Barth.
+
+        On android, DRT needs to run in a background thread to avoid ANR.
+        However, the java tests are running on UI thread by default.
+        We need to send an intent extra to the apk so that it can run on a sub thread.
+
+        * Scripts/webkitpy/layout_tests/port/chromium_android.py:
+        (ChromiumAndroidDriver._start_once):
+
 2012-07-11  Csaba Osztrogonác  <[email protected]>
 
         [Qt] REGRESSION(r107171): Fix --timeout option of Qt's DRT

Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py (122336 => 122337)


--- trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py	2012-07-11 16:46:36 UTC (rev 122336)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py	2012-07-11 16:50:44 UTC (rev 122337)
@@ -518,7 +518,7 @@
     def _start_once(self, pixel_tests, per_test_args):
         self._port._run_adb_command(['logcat', '-c'])
         self._port._run_adb_command(['shell', 'echo'] + self.cmd_line(pixel_tests, per_test_args) + ['>', COMMAND_LINE_FILE])
-        start_result = self._port._run_adb_command(['shell', 'am', 'start', '-n', DRT_ACTIVITY_FULL_NAME])
+        start_result = self._port._run_adb_command(['shell', 'am', 'start', '-e', 'RunInSubThread', '-n', DRT_ACTIVITY_FULL_NAME])
         if start_result.find('Exception') != -1:
             _log.error('Failed to start DumpRenderTree application. Exception:\n' + start_result)
             return False
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to