Title: [122545] trunk/Source/WebCore
- Revision
- 122545
- Author
- [email protected]
- Date
- 2012-07-12 23:50:15 -0700 (Thu, 12 Jul 2012)
Log Message
CodeGeneratorJS.pm need to handle the attribute which has "CallWith=ScriptExecutionContext" option.
https://bugs.webkit.org/show_bug.cgi?id=91185
Patch by Dongwoo Im <[email protected]> on 2012-07-12
Reviewed by Kentaro Hara.
When an attribute has "CallWith=ScriptExecutionContext" option, 'ScriptExecutionContext*' parameter should be the last parameter.
No new tests. Covered by existing tests.
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (122544 => 122545)
--- trunk/Source/WebCore/ChangeLog 2012-07-13 06:41:18 UTC (rev 122544)
+++ trunk/Source/WebCore/ChangeLog 2012-07-13 06:50:15 UTC (rev 122545)
@@ -1,3 +1,17 @@
+2012-07-12 Dongwoo Im <[email protected]>
+
+ CodeGeneratorJS.pm need to handle the attribute which has "CallWith=ScriptExecutionContext" option.
+ https://bugs.webkit.org/show_bug.cgi?id=91185
+
+ Reviewed by Kentaro Hara.
+
+ When an attribute has "CallWith=ScriptExecutionContext" option, 'ScriptExecutionContext*' parameter should be the last parameter.
+
+ No new tests. Covered by existing tests.
+
+ * bindings/scripts/CodeGeneratorJS.pm:
+ (GenerateImplementation):
+
2012-07-12 Yoshifumi Inoue <[email protected]>
REGRESSION(r117738): [Forms] stepMismatch for input type "time" with large step value always return false.
Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm (122544 => 122545)
--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm 2012-07-13 06:41:18 UTC (rev 122544)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm 2012-07-13 06:50:15 UTC (rev 122545)
@@ -1796,7 +1796,7 @@
$functionName = "impl->${functionName}";
}
- unshift(@arguments, @callWithArgs);
+ push(@arguments, @callWithArgs);
my $jsType = NativeToJSValue($attribute->signature, 0, $implClassName, "${functionName}(" . join(", ", @arguments) . ")", "castedThis");
push(@implContent, " $implClassName* impl = static_cast<$implClassName*>(castedThis->impl());\n");
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
