Title: [122553] trunk/Source/WebCore
- Revision
- 122553
- Author
- [email protected]
- Date
- 2012-07-13 02:05:21 -0700 (Fri, 13 Jul 2012)
Log Message
CodeGeneratorJS.pm : SetterExpression should use 'push' rather than 'unshift'
https://bugs.webkit.org/show_bug.cgi?id=91198
Patch by Dongwoo Im <[email protected]> on 2012-07-13
Reviewed by Kentaro Hara.
'SetterExpression' should use 'push' to make arguments, rather than 'unshift'.
No new tests. Covered by existing tests.
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (122552 => 122553)
--- trunk/Source/WebCore/ChangeLog 2012-07-13 08:56:10 UTC (rev 122552)
+++ trunk/Source/WebCore/ChangeLog 2012-07-13 09:05:21 UTC (rev 122553)
@@ -1,3 +1,17 @@
+2012-07-13 Dongwoo Im <[email protected]>
+
+ CodeGeneratorJS.pm : SetterExpression should use 'push' rather than 'unshift'
+ https://bugs.webkit.org/show_bug.cgi?id=91198
+
+ Reviewed by Kentaro Hara.
+
+ 'SetterExpression' should use 'push' to make arguments, rather than 'unshift'.
+
+ No new tests. Covered by existing tests.
+
+ * bindings/scripts/CodeGeneratorJS.pm:
+ (GenerateImplementation):
+
2012-07-13 Yoshifumi Inoue <[email protected]>
REGRESSION(r119948): [Forms] Spin button Up/Down actions make value to zero for input type "number" when step mismatched
Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm (122552 => 122553)
--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm 2012-07-13 08:56:10 UTC (rev 122552)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm 2012-07-13 09:05:21 UTC (rev 122553)
@@ -2019,7 +2019,7 @@
$functionName = "impl->${functionName}";
}
- unshift(@arguments, GenerateCallWith($attribute->signature->extendedAttributes->{"CallWith"}, \@implContent, ""));
+ push(@arguments, GenerateCallWith($attribute->signature->extendedAttributes->{"CallWith"}, \@implContent, ""));
push(@arguments, "ec") if @{$attribute->setterExceptions};
push(@implContent, " ${functionName}(" . join(", ", @arguments) . ");\n");
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
