Title: [122635] trunk/Source/WebCore
- Revision
- 122635
- Author
- [email protected]
- Date
- 2012-07-13 15:35:11 -0700 (Fri, 13 Jul 2012)
Log Message
Threadsafety issues in WebScriptObject
https://bugs.webkit.org/show_bug.cgi?id=90849
Reviewed by Geoff Garen.
Updated fix for this bug. The JSC API lock needs to be acquired also in JSObject.
* bindings/objc/WebScriptObject.mm:
(-[WebScriptObject JSObject]):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (122634 => 122635)
--- trunk/Source/WebCore/ChangeLog 2012-07-13 22:25:14 UTC (rev 122634)
+++ trunk/Source/WebCore/ChangeLog 2012-07-13 22:35:11 UTC (rev 122635)
@@ -1,3 +1,15 @@
+2012-07-13 Enrica Casucci <[email protected]>
+
+ Threadsafety issues in WebScriptObject
+ https://bugs.webkit.org/show_bug.cgi?id=90849
+
+ Reviewed by Geoff Garen.
+
+ Updated fix for this bug. The JSC API lock needs to be acquired also in JSObject.
+
+ * bindings/objc/WebScriptObject.mm:
+ (-[WebScriptObject JSObject]):
+
2012-07-13 Raymond Toy <[email protected]>
DelayNode doesn't work if delayTime.value == delayTime.maxValue
Modified: trunk/Source/WebCore/bindings/objc/WebScriptObject.mm (122634 => 122635)
--- trunk/Source/WebCore/bindings/objc/WebScriptObject.mm 2012-07-13 22:25:14 UTC (rev 122634)
+++ trunk/Source/WebCore/bindings/objc/WebScriptObject.mm 2012-07-13 22:35:11 UTC (rev 122635)
@@ -530,6 +530,9 @@
- (JSObjectRef)JSObject
{
+ ExecState* exec = [self _rootObject]->globalObject()->globalExec();
+
+ JSLockHolder lock(exec);
if (![self _isSafeScript])
return NULL;
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
