Title: [122638] trunk/Source/WebKit/blackberry
- Revision
- 122638
- Author
- [email protected]
- Date
- 2012-07-13 15:46:41 -0700 (Fri, 13 Jul 2012)
Log Message
[BlackBerry] Fix crash due to unguarded use of renderer in select
popup.
https://bugs.webkit.org/show_bug.cgi?id=91287
Reviewed by Rob Buis.
No known testcase for this. Found in the wild.
* WebCoreSupport/SelectPopupClient.cpp:
(WebCore::SelectPopupClient::setValueAndClosePopup):
Modified Paths
Diff
Modified: trunk/Source/WebKit/blackberry/ChangeLog (122637 => 122638)
--- trunk/Source/WebKit/blackberry/ChangeLog 2012-07-13 22:44:46 UTC (rev 122637)
+++ trunk/Source/WebKit/blackberry/ChangeLog 2012-07-13 22:46:41 UTC (rev 122638)
@@ -1,3 +1,16 @@
+2012-07-13 George Staikos <[email protected]>
+
+ [BlackBerry] Fix crash due to unguarded use of renderer in select
+ popup.
+ https://bugs.webkit.org/show_bug.cgi?id=91287
+
+ Reviewed by Rob Buis.
+
+ No known testcase for this. Found in the wild.
+
+ * WebCoreSupport/SelectPopupClient.cpp:
+ (WebCore::SelectPopupClient::setValueAndClosePopup):
+
2012-07-13 Mike Fenton <[email protected]>
[BlackBerry] Add support for attributes to define keyboard and enter key type on the Virtual Keyboard
Modified: trunk/Source/WebKit/blackberry/WebCoreSupport/SelectPopupClient.cpp (122637 => 122638)
--- trunk/Source/WebKit/blackberry/WebCoreSupport/SelectPopupClient.cpp 2012-07-13 22:44:46 UTC (rev 122637)
+++ trunk/Source/WebKit/blackberry/WebCoreSupport/SelectPopupClient.cpp 2012-07-13 22:46:41 UTC (rev 122638)
@@ -168,7 +168,8 @@
// Force repaint because we do not send mouse events to the select element
// and the element doesn't automatically repaint itself.
m_element->dispatchFormControlChangeEvent();
- m_element->renderer()->repaint();
+ if (m_element->renderer())
+ m_element->renderer()->repaint();
closePopup();
}
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
