Title: [122657] trunk/Tools
- Revision
- 122657
- Author
- [email protected]
- Date
- 2012-07-13 19:09:44 -0700 (Fri, 13 Jul 2012)
Log Message
nrwt: actually print the exception name and message for otherwise unhandled exceptions
https://bugs.webkit.org/show_bug.cgi?id=91305
Reviewed by Adam Barth.
Two more places where I was printing the stack trace but not the
exception itself :(. These two spots can't easily be
unit-tested, but I tested them by hand.
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(run):
(main):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (122656 => 122657)
--- trunk/Tools/ChangeLog 2012-07-14 02:07:48 UTC (rev 122656)
+++ trunk/Tools/ChangeLog 2012-07-14 02:09:44 UTC (rev 122657)
@@ -1,3 +1,18 @@
+2012-07-13 Dirk Pranke <[email protected]>
+
+ nrwt: actually print the exception name and message for otherwise unhandled exceptions
+ https://bugs.webkit.org/show_bug.cgi?id=91305
+
+ Reviewed by Adam Barth.
+
+ Two more places where I was printing the stack trace but not the
+ exception itself :(. These two spots can't easily be
+ unit-tested, but I tested them by hand.
+
+ * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
+ (run):
+ (main):
+
2012-07-13 Josh Hawn <[email protected]>
Fix for WebContext::getWebCoreStatistics() causes crash if no m_process
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py (122656 => 122657)
--- trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py 2012-07-14 02:07:48 UTC (rev 122656)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py 2012-07-14 02:09:44 UTC (rev 122657)
@@ -132,6 +132,7 @@
except Exception:
exception_type, exception_value, exception_traceback = sys.exc_info()
if exception_type not in (KeyboardInterrupt, TestRunInterruptedException, WorkerException):
+ print >> sys.stderr, '\n%s raised: %s' % (exception_type.__name__, exception_value)
stack_utils.log_traceback(_log.error, exception_traceback)
raise
finally:
@@ -470,7 +471,8 @@
# FIXME: is this the best way to handle unsupported port names?
print >> sys.stderr, str(e)
return EXCEPTIONAL_EXIT_STATUS
- except:
+ except Exception, e:
+ print >> sys.stderr, '\n%s raised: %s' % (e.__class__.__name__, str(e))
traceback.print_exc(file=sys.stderr)
raise
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
